Re: [PATCH] drm/exynos: use logical AND in exynos_drm_plane_check_size()

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Jun 13, 2016 at 3:34 AM, Inki Dae <inki.dae@samsung.com> wrote:
> Picked it up.

Fyi it's already in drm-misc too.
-Daniel

>
> Thanks,
> Inki Dae
>
> 2016년 06월 10일 19:12에 Tobias Jakobi 이(가) 쓴 글:
>> Ping!
>>
>> - Tobias
>>
>> Tobias Jakobi wrote:
>>> The current bitwise AND should result in the same assembler
>>> but this is what the code is actually supposed to do.
>>>
>>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>>> ---
>>>  drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c
>>> index b3f3c2c..e4a1a63 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c
>>> @@ -226,7 +226,7 @@ exynos_drm_plane_check_size(const struct exynos_drm_plane_config *config,
>>>          state->v_ratio == (1 << 15))
>>>              height_ok = true;
>>>
>>> -    if (width_ok & height_ok)
>>> +    if (width_ok && height_ok)
>>>              return 0;
>>>
>>>      DRM_DEBUG_KMS("scaling mode is not supported");
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>>
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch