From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbdEDMtl (ORCPT ); Thu, 4 May 2017 08:49:41 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:34332 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbdEDMtc (ORCPT ); Thu, 4 May 2017 08:49:32 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <20170503152129.GO12629@intel.com> References: <3e1dba0cd5fc053e56f1c9c94d0cb8789ecca4ae.1493203049.git.joabreu@synopsys.com> <20170502084807.k7ioo7a5j33xtnpj@phenom.ffwll.local> <80752cfe-4bc7-b7c6-c29b-e634c356a509@synopsys.com> <9edb415e-4d0b-5a2a-a735-0dbb98d77984@synopsys.com> <20170503150031.rpd5xs2bb67mpsnc@phenom.ffwll.local> <20170503152129.GO12629@intel.com> From: Daniel Vetter Date: Thu, 4 May 2017 14:49:31 +0200 X-Google-Sender-Auth: IYCkr34nB_4E-zoGa_GQe1VijIQ Message-ID: Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Jose Abreu , dri-devel , Linux Kernel Mailing List , Carlos Palminha , Alexey Brodkin , Dave Airlie Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v44CniqQ013506 On Wed, May 3, 2017 at 5:21 PM, Ville Syrjälä wrote: > We don't actually want the codepaths to match exactly. In i915 > we allow the user to exceed some of the display/dongle limits > because those things often tell us that something shouldn't work > when in fact it does. And some users are quick to complain if > something stops working for them. The goal here is to share the source-side checking (crtc/encoder/bridges), and that should match perfectly between probe and commit. Sink-side constraints are different, and for those we should indeed not check everything. Maybe a good reason to only call connector->mode_valid in the probe paths? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback Date: Thu, 4 May 2017 14:49:31 +0200 Message-ID: References: <3e1dba0cd5fc053e56f1c9c94d0cb8789ecca4ae.1493203049.git.joabreu@synopsys.com> <20170502084807.k7ioo7a5j33xtnpj@phenom.ffwll.local> <80752cfe-4bc7-b7c6-c29b-e634c356a509@synopsys.com> <9edb415e-4d0b-5a2a-a735-0dbb98d77984@synopsys.com> <20170503150031.rpd5xs2bb67mpsnc@phenom.ffwll.local> <20170503152129.GO12629@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB8A66E1B6 for ; Thu, 4 May 2017 12:49:32 +0000 (UTC) Received: by mail-io0-x242.google.com with SMTP id x86so3474143ioe.3 for ; Thu, 04 May 2017 05:49:32 -0700 (PDT) In-Reply-To: <20170503152129.GO12629@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Jose Abreu , Alexey Brodkin , Linux Kernel Mailing List , dri-devel , Carlos Palminha List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMywgMjAxNyBhdCA1OjIxIFBNLCBWaWxsZSBTeXJqw6Rsw6QKPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiBXZSBkb24ndCBhY3R1YWxseSB3YW50IHRo ZSBjb2RlcGF0aHMgdG8gbWF0Y2ggZXhhY3RseS4gSW4gaTkxNQo+IHdlIGFsbG93IHRoZSB1c2Vy IHRvIGV4Y2VlZCBzb21lIG9mIHRoZSBkaXNwbGF5L2RvbmdsZSBsaW1pdHMKPiBiZWNhdXNlIHRo b3NlIHRoaW5ncyBvZnRlbiB0ZWxsIHVzIHRoYXQgc29tZXRoaW5nIHNob3VsZG4ndCB3b3JrCj4g d2hlbiBpbiBmYWN0IGl0IGRvZXMuIEFuZCBzb21lIHVzZXJzIGFyZSBxdWljayB0byBjb21wbGFp biBpZgo+IHNvbWV0aGluZyBzdG9wcyB3b3JraW5nIGZvciB0aGVtLgoKVGhlIGdvYWwgaGVyZSBp cyB0byBzaGFyZSB0aGUgc291cmNlLXNpZGUgY2hlY2tpbmcKKGNydGMvZW5jb2Rlci9icmlkZ2Vz KSwgYW5kIHRoYXQgc2hvdWxkIG1hdGNoIHBlcmZlY3RseSBiZXR3ZWVuIHByb2JlCmFuZCBjb21t aXQuIFNpbmstc2lkZSBjb25zdHJhaW50cyBhcmUgZGlmZmVyZW50LCBhbmQgZm9yIHRob3NlIHdl CnNob3VsZCBpbmRlZWQgbm90IGNoZWNrIGV2ZXJ5dGhpbmcuIE1heWJlIGEgZ29vZCByZWFzb24g dG8gb25seSBjYWxsCmNvbm5lY3Rvci0+bW9kZV92YWxpZCBpbiB0aGUgcHJvYmUgcGF0aHM/Ci1E YW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==