From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbdDCH6H (ORCPT ); Mon, 3 Apr 2017 03:58:07 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:35684 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbdDCH6F (ORCPT ); Mon, 3 Apr 2017 03:58:05 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:56b5:0:3dcb:681a:5b6e:8025] In-Reply-To: <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> From: Daniel Vetter Date: Mon, 3 Apr 2017 09:58:04 +0200 X-Google-Sender-Auth: pxtpW_hO1ld3J8wyz5d5N5mRZB8 Message-ID: Subject: Re: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload To: Jeffy Chen Cc: Linux Kernel Mailing List , Brian Norris , Douglas Anderson , dri-devel , Tomasz Figa , "open list:ARM/Rockchip SoC..." , Chris Zhong , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen wrote: > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index a5d83cb..5dbf011 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -246,6 +246,7 @@ static void rockchip_drm_unbind(struct device *dev) > rockchip_drm_fbdev_fini(drm_dev); > drm_kms_helper_poll_fini(drm_dev); > > + drm_crtc_force_disable_all(drm_dev); This will result in a WARN_ON in latest drm-next because rockchip is atomic, and this helper is for legacy kms drivers. You want to use drm_atomic_helper_shutdown here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload Date: Mon, 3 Apr 2017 09:58:04 +0200 Message-ID: References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jeffy Chen Cc: Douglas Anderson , Brian Norris , Linux Kernel Mailing List , dri-devel , Tomasz Figa , "open list:ARM/Rockchip SoC..." , Chris Zhong , "linux-arm-kernel@lists.infradead.org" List-Id: linux-rockchip.vger.kernel.org T24gU2F0LCBBcHIgMSwgMjAxNyBhdCAxOjM1IFBNLCBKZWZmeSBDaGVuIDxqZWZmeS5jaGVuQHJv Y2stY2hpcHMuY29tPiB3cm90ZToKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tj aGlwL3JvY2tjaGlwX2RybV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hp cF9kcm1fZHJ2LmMKPiBpbmRleCBhNWQ4M2NiLi41ZGJmMDExIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jCj4gQEAgLTI0Niw2ICsyNDYsNyBAQCBz dGF0aWMgdm9pZCByb2NrY2hpcF9kcm1fdW5iaW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiAgICAg ICAgIHJvY2tjaGlwX2RybV9mYmRldl9maW5pKGRybV9kZXYpOwo+ICAgICAgICAgZHJtX2ttc19o ZWxwZXJfcG9sbF9maW5pKGRybV9kZXYpOwo+Cj4gKyAgICAgICBkcm1fY3J0Y19mb3JjZV9kaXNh YmxlX2FsbChkcm1fZGV2KTsKClRoaXMgd2lsbCByZXN1bHQgaW4gYSBXQVJOX09OIGluIGxhdGVz dCBkcm0tbmV4dCBiZWNhdXNlIHJvY2tjaGlwIGlzCmF0b21pYywgYW5kIHRoaXMgaGVscGVyIGlz IGZvciBsZWdhY3kga21zIGRyaXZlcnMuIFlvdSB3YW50IHRvIHVzZQpkcm1fYXRvbWljX2hlbHBl cl9zaHV0ZG93biBoZXJlLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2lu ZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Mon, 3 Apr 2017 09:58:04 +0200 Subject: [PATCH v2 7/9] drm/rockchip: Force disable all crtc when unload In-Reply-To: <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> References: <1491046529-4310-1-git-send-email-jeffy.chen@rock-chips.com> <1491046529-4310-8-git-send-email-jeffy.chen@rock-chips.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Apr 1, 2017 at 1:35 PM, Jeffy Chen wrote: > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index a5d83cb..5dbf011 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -246,6 +246,7 @@ static void rockchip_drm_unbind(struct device *dev) > rockchip_drm_fbdev_fini(drm_dev); > drm_kms_helper_poll_fini(drm_dev); > > + drm_crtc_force_disable_all(drm_dev); This will result in a WARN_ON in latest drm-next because rockchip is atomic, and this helper is for legacy kms drivers. You want to use drm_atomic_helper_shutdown here. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch