From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FCDBC433EF for ; Mon, 18 Jun 2018 16:00:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D45B7208A6 for ; Mon, 18 Jun 2018 16:00:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="T0IdJ828" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D45B7208A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934599AbeFRQAO (ORCPT ); Mon, 18 Jun 2018 12:00:14 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:43250 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbeFRQAM (ORCPT ); Mon, 18 Jun 2018 12:00:12 -0400 Received: by mail-io0-f194.google.com with SMTP id t6-v6so17257958iob.10 for ; Mon, 18 Jun 2018 09:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=UC5UT7DCoM6UP9KeiiKK6268yi5oWSn9Xg9opObNozA=; b=T0IdJ828PHm7JZwJ1QodpiSu88UfTQOEU3y+jroJkoCXcWZ3EEyMDJVbn5Ela7QRJw b1J2HEoKDuJOUre+F01bvkNDzahKdrIsAEt9DigS60a8bTfkEzYS7DdkSNqutrKK8rzO I4Qz73JsVXtmKBl2oH6Eaa543WH1cJw8XbG9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=UC5UT7DCoM6UP9KeiiKK6268yi5oWSn9Xg9opObNozA=; b=qHymravnke3lQWESKrBuDozfcnOZxAYmUNw56klKe4I/Yn3VhX6PZdTPQvnObcvp87 ncsPPu90i2lMjLg8w5H7XEupLfgqUQJiJ4q+gXP3Is2eABSZxVe/IxM7hbNqzPxQC3Dy Q+MRYjTyiXOzIYRKvmQgUOLQ6vCnBDE9UmqTcW2OiSjN75KsJw7MOTX9tMJ+8yRc+4Ma brgLM+0AzYO8TUOrPSLW6fSbz93dNtuvfWSFfHDwC2cpotRN9k+2sNdfHu5pZenfLZCh iOVFoHuowni3rZctDoWNXU9cj6E6uDBJlGsZp3Gwlz0Y6FY29/3lqzfniLWLbaXMqkVQ nI2A== X-Gm-Message-State: APt69E2bZ4KwGOei5GajlL2jffkiD2sLG9dHuRFGAQ4wJoIH8hsEpMVF U0gP7YxKJ9ahSSIM0iBjYte069L3DptlkXRCUaofQw== X-Google-Smtp-Source: ADUXVKINFubr1CE1ZFwh1GxvXSnXxfsoXtERITNxlZ4/qrj0wc8TSZKRkZGV/I3lSWpuueej1BZ4OzPQSNrP9uUDPqA= X-Received: by 2002:a6b:c544:: with SMTP id v65-v6mr10422230iof.278.1529337612073; Mon, 18 Jun 2018 09:00:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:e48b:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 09:00:11 -0700 (PDT) X-Originating-IP: [2a02:168:5628:0:d0c7:bcda:eea:9e5d] In-Reply-To: References: <20180416150232.GA26745@jordon-HP-15-Notebook-PC> <20180510185138.GL33053@art_vandelay> <20180514162617.GD28661@phenom.ffwll.local> <20180524125756.GO3438@phenom.ffwll.local> From: Daniel Vetter Date: Mon, 18 Jun 2018 18:00:11 +0200 X-Google-Sender-Auth: 5rmr5DG7On7fPavoV9asu9EUoc0 Message-ID: Subject: Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t To: Souptick Joarder Cc: Sean Paul , Linux Kernel Mailing List , Matthew Wilcox , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 18, 2018 at 1:26 PM, Souptick Joarder wrote: > On Thu, May 24, 2018 at 6:27 PM, Daniel Vetter wrote: >> On Wed, May 23, 2018 at 03:05:35PM +0530, Souptick Joarder wrote: >>> On Mon, May 14, 2018 at 9:56 PM, Daniel Vetter wrote: >>> > On Thu, May 10, 2018 at 02:51:38PM -0400, Sean Paul wrote: >>> >> On Thu, May 10, 2018 at 07:58:11PM +0530, Souptick Joarder wrote: >>> >> > Hi Sean, >>> >> > >>> >> > On Mon, Apr 16, 2018 at 8:32 PM, Souptick Joarder wrote: >>> >> > > Use new return type vm_fault_t for fault handler. >>> >> > > >>> >> > > Signed-off-by: Souptick Joarder >>> >> > > Reviewed-by: Matthew Wilcox >>> >> > > --- >>> >> > > drivers/gpu/drm/vgem/vgem_drv.c | 5 ++--- >>> >> > > 1 file changed, 2 insertions(+), 3 deletions(-) >>> >> > > >>> >> > > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c >>> >> > > index 2524ff1..c64a859 100644 >>> >> > > --- a/drivers/gpu/drm/vgem/vgem_drv.c >>> >> > > +++ b/drivers/gpu/drm/vgem/vgem_drv.c >>> >> > > @@ -61,13 +61,13 @@ static void vgem_gem_free_object(struct drm_gem_object *obj) >>> >> > > kfree(vgem_obj); >>> >> > > } >>> >> > > >>> >> > > -static int vgem_gem_fault(struct vm_fault *vmf) >>> >> > > +static vm_fault_t vgem_gem_fault(struct vm_fault *vmf) >>> >> > > { >>> >> > > struct vm_area_struct *vma = vmf->vma; >>> >> > > struct drm_vgem_gem_object *obj = vma->vm_private_data; >>> >> > > /* We don't use vmf->pgoff since that has the fake offset */ >>> >> > > unsigned long vaddr = vmf->address; >>> >> > > - int ret; >>> >> > > + vm_fault_t ret = VM_FAULT_SIGBUS; >>> >> > > loff_t num_pages; >>> >> > > pgoff_t page_offset; >>> >> > > page_offset = (vaddr - vma->vm_start) >> PAGE_SHIFT; >>> >> > > @@ -77,7 +77,6 @@ static int vgem_gem_fault(struct vm_fault *vmf) >>> >> > > if (page_offset > num_pages) >>> >> > > return VM_FAULT_SIGBUS; >>> >> > > >>> >> > > - ret = -ENOENT; >>> >> > > mutex_lock(&obj->pages_lock); >>> >> > > if (obj->pages) { >>> >> > > get_page(obj->pages[page_offset]); >>> >> > > -- >>> >> > > 1.9.1 >>> >> > > >>> >> > >>> >> > Any further comment on this patch ? >>> >> >>> >> Patch looks good to me. My build test fails, though, since vm_fault_t doesn't >>> >> exist in drm-misc-next yet. >>> > >>> > vm_fault_t is already in upstream, just needs Maarten to do a backmerge. >>> > Which I think he's done by now ... Otherwise nag him more :-) >>> > -Daniel >>> > >>> >> >>> >> So, for now, >>> >> >>> >> Reviewed-by: Sean Paul >>> >> >>> >> >>> >> -- >>> >> Sean Paul, Software Engineer, Google / Chromium OS >>> >> _______________________________________________ >>> >> dri-devel mailing list >>> >> dri-devel@lists.freedesktop.org >>> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel >>> > >>> > -- >>> > Daniel Vetter >>> > Software Engineer, Intel Corporation >>> > http://blog.ffwll.ch >>> >>> Daniel/ Sean, is this patch already merged for 4.18 ? >> >> Nope, fell through the cracks. Thanks for the reminder, queued for 4.18 >> now. >> -Daniel >> > > Daniel, This patch is not available in 4.18-rc-1 :-) I mixed up my book-keeping, it was queued for 4.19. Should show up in linux-next any day (well as soon as drm-misc maintainers get their book-keeping updated). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t Date: Mon, 18 Jun 2018 18:00:11 +0200 Message-ID: References: <20180416150232.GA26745@jordon-HP-15-Notebook-PC> <20180510185138.GL33053@art_vandelay> <20180514162617.GD28661@phenom.ffwll.local> <20180524125756.GO3438@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id A917A6E0A1 for ; Mon, 18 Jun 2018 16:00:12 +0000 (UTC) Received: by mail-io0-x243.google.com with SMTP id k3-v6so17303338iog.3 for ; Mon, 18 Jun 2018 09:00:12 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Souptick Joarder Cc: dri-devel , Linux Kernel Mailing List , Matthew Wilcox List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdW4gMTgsIDIwMTggYXQgMToyNiBQTSwgU291cHRpY2sgSm9hcmRlciA8anJkci5s aW51eEBnbWFpbC5jb20+IHdyb3RlOgo+IE9uIFRodSwgTWF5IDI0LCAyMDE4IGF0IDY6MjcgUE0s IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4+IE9uIFdlZCwgTWF5IDIz LCAyMDE4IGF0IDAzOjA1OjM1UE0gKzA1MzAsIFNvdXB0aWNrIEpvYXJkZXIgd3JvdGU6Cj4+PiBP biBNb24sIE1heSAxNCwgMjAxOCBhdCA5OjU2IFBNLCBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3 bGwuY2g+IHdyb3RlOgo+Pj4gPiBPbiBUaHUsIE1heSAxMCwgMjAxOCBhdCAwMjo1MTozOFBNIC0w NDAwLCBTZWFuIFBhdWwgd3JvdGU6Cj4+PiA+PiBPbiBUaHUsIE1heSAxMCwgMjAxOCBhdCAwNzo1 ODoxMVBNICswNTMwLCBTb3VwdGljayBKb2FyZGVyIHdyb3RlOgo+Pj4gPj4gPiBIaSBTZWFuLAo+ Pj4gPj4gPgo+Pj4gPj4gPiBPbiBNb24sIEFwciAxNiwgMjAxOCBhdCA4OjMyIFBNLCBTb3VwdGlj ayBKb2FyZGVyIDxqcmRyLmxpbnV4QGdtYWlsLmNvbT4gd3JvdGU6Cj4+PiA+PiA+ID4gVXNlIG5l dyByZXR1cm4gdHlwZSB2bV9mYXVsdF90IGZvciBmYXVsdCBoYW5kbGVyLgo+Pj4gPj4gPiA+Cj4+ PiA+PiA+ID4gU2lnbmVkLW9mZi1ieTogU291cHRpY2sgSm9hcmRlciA8anJkci5saW51eEBnbWFp bC5jb20+Cj4+PiA+PiA+ID4gUmV2aWV3ZWQtYnk6IE1hdHRoZXcgV2lsY294IDxtYXdpbGNveEBt aWNyb3NvZnQuY29tPgo+Pj4gPj4gPiA+IC0tLQo+Pj4gPj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v dmdlbS92Z2VtX2Rydi5jIHwgNSArKy0tLQo+Pj4gPj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Pj4gPj4gPiA+Cj4+PiA+PiA+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92Z2VtL3ZnZW1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0v dmdlbS92Z2VtX2Rydi5jCj4+PiA+PiA+ID4gaW5kZXggMjUyNGZmMS4uYzY0YTg1OSAxMDA2NDQK Pj4+ID4+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jCj4+PiA+PiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYwo+Pj4gPj4gPiA+IEBAIC02 MSwxMyArNjEsMTMgQEAgc3RhdGljIHZvaWQgdmdlbV9nZW1fZnJlZV9vYmplY3Qoc3RydWN0IGRy bV9nZW1fb2JqZWN0ICpvYmopCj4+PiA+PiA+ID4gICAgICAgICBrZnJlZSh2Z2VtX29iaik7Cj4+ PiA+PiA+ID4gIH0KPj4+ID4+ID4gPgo+Pj4gPj4gPiA+IC1zdGF0aWMgaW50IHZnZW1fZ2VtX2Zh dWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+Pj4gPj4gPiA+ICtzdGF0aWMgdm1fZmF1bHRfdCB2 Z2VtX2dlbV9mYXVsdChzdHJ1Y3Qgdm1fZmF1bHQgKnZtZikKPj4+ID4+ID4gPiAgewo+Pj4gPj4g PiA+ICAgICAgICAgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEgPSB2bWYtPnZtYTsKPj4+ID4+ ID4gPiAgICAgICAgIHN0cnVjdCBkcm1fdmdlbV9nZW1fb2JqZWN0ICpvYmogPSB2bWEtPnZtX3By aXZhdGVfZGF0YTsKPj4+ID4+ID4gPiAgICAgICAgIC8qIFdlIGRvbid0IHVzZSB2bWYtPnBnb2Zm IHNpbmNlIHRoYXQgaGFzIHRoZSBmYWtlIG9mZnNldCAqLwo+Pj4gPj4gPiA+ICAgICAgICAgdW5z aWduZWQgbG9uZyB2YWRkciA9IHZtZi0+YWRkcmVzczsKPj4+ID4+ID4gPiAtICAgICAgIGludCBy ZXQ7Cj4+PiA+PiA+ID4gKyAgICAgICB2bV9mYXVsdF90IHJldCA9IFZNX0ZBVUxUX1NJR0JVUzsK Pj4+ID4+ID4gPiAgICAgICAgIGxvZmZfdCBudW1fcGFnZXM7Cj4+PiA+PiA+ID4gICAgICAgICBw Z29mZl90IHBhZ2Vfb2Zmc2V0Owo+Pj4gPj4gPiA+ICAgICAgICAgcGFnZV9vZmZzZXQgPSAodmFk ZHIgLSB2bWEtPnZtX3N0YXJ0KSA+PiBQQUdFX1NISUZUOwo+Pj4gPj4gPiA+IEBAIC03Nyw3ICs3 Nyw2IEBAIHN0YXRpYyBpbnQgdmdlbV9nZW1fZmF1bHQoc3RydWN0IHZtX2ZhdWx0ICp2bWYpCj4+ PiA+PiA+ID4gICAgICAgICBpZiAocGFnZV9vZmZzZXQgPiBudW1fcGFnZXMpCj4+PiA+PiA+ID4g ICAgICAgICAgICAgICAgIHJldHVybiBWTV9GQVVMVF9TSUdCVVM7Cj4+PiA+PiA+ID4KPj4+ID4+ ID4gPiAtICAgICAgIHJldCA9IC1FTk9FTlQ7Cj4+PiA+PiA+ID4gICAgICAgICBtdXRleF9sb2Nr KCZvYmotPnBhZ2VzX2xvY2spOwo+Pj4gPj4gPiA+ICAgICAgICAgaWYgKG9iai0+cGFnZXMpIHsK Pj4+ID4+ID4gPiAgICAgICAgICAgICAgICAgZ2V0X3BhZ2Uob2JqLT5wYWdlc1twYWdlX29mZnNl dF0pOwo+Pj4gPj4gPiA+IC0tCj4+PiA+PiA+ID4gMS45LjEKPj4+ID4+ID4gPgo+Pj4gPj4gPgo+ Pj4gPj4gPiBBbnkgZnVydGhlciBjb21tZW50IG9uIHRoaXMgcGF0Y2ggPwo+Pj4gPj4KPj4+ID4+ IFBhdGNoIGxvb2tzIGdvb2QgdG8gbWUuIE15IGJ1aWxkIHRlc3QgZmFpbHMsIHRob3VnaCwgc2lu Y2Ugdm1fZmF1bHRfdCBkb2Vzbid0Cj4+PiA+PiBleGlzdCBpbiBkcm0tbWlzYy1uZXh0IHlldC4K Pj4+ID4KPj4+ID4gdm1fZmF1bHRfdCBpcyBhbHJlYWR5IGluIHVwc3RyZWFtLCBqdXN0IG5lZWRz IE1hYXJ0ZW4gdG8gZG8gYSBiYWNrbWVyZ2UuCj4+PiA+IFdoaWNoIEkgdGhpbmsgaGUncyBkb25l IGJ5IG5vdyAuLi4gT3RoZXJ3aXNlIG5hZyBoaW0gbW9yZSA6LSkKPj4+ID4gLURhbmllbAo+Pj4g Pgo+Pj4gPj4KPj4+ID4+IFNvLCBmb3Igbm93LAo+Pj4gPj4KPj4+ID4+IFJldmlld2VkLWJ5OiBT ZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9yZz4KPj4+ID4+Cj4+PiA+Pgo+Pj4gPj4gLS0K Pj4+ID4+IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9T Cj4+PiA+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ Pj4gPj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+Pj4gPj4gZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+Pj4gPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwKPj4+ID4KPj4+ID4gLS0KPj4+ID4gRGFuaWVsIFZldHRlcgo+Pj4g PiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPj4+ID4gaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKPj4+Cj4+PiBEYW5pZWwvIFNlYW4sIGlzIHRoaXMgcGF0Y2ggYWxyZWFkeSBtZXJn ZWQgZm9yIDQuMTggPwo+Pgo+PiBOb3BlLCBmZWxsIHRocm91Z2ggdGhlIGNyYWNrcy4gVGhhbmtz IGZvciB0aGUgcmVtaW5kZXIsIHF1ZXVlZCBmb3IgNC4xOAo+PiBub3cuCj4+IC1EYW5pZWwKPj4K Pgo+IERhbmllbCwgVGhpcyBwYXRjaCBpcyBub3QgYXZhaWxhYmxlIGluIDQuMTgtcmMtMSA6LSkK CkkgbWl4ZWQgdXAgbXkgYm9vay1rZWVwaW5nLCBpdCB3YXMgcXVldWVkIGZvciA0LjE5LiBTaG91 bGQgc2hvdyB1cCBpbgpsaW51eC1uZXh0IGFueSBkYXkgKHdlbGwgYXMgc29vbiBhcyBkcm0tbWlz YyBtYWludGFpbmVycyBnZXQgdGhlaXIKYm9vay1rZWVwaW5nIHVwZGF0ZWQpLgotRGFuaWVsCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEg KDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=