From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915: remove the vblank_wait hack
 from HSW+
Date: Thu, 19 Dec 2013 22:17:56 +0100
Message-ID: <CAKMK7uGS85E=KMNfCrDAfOaTr72j7sF_BDf=yY5JQbpzTzdxTw@mail.gmail.com>
References: <1387487551-1612-1-git-send-email-przanoni@gmail.com>
	<1387487551-1612-3-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com
	[209.85.223.175])
	by gabe.freedesktop.org (Postfix) with ESMTP id 37BC910EC99
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 19 Dec 2013 13:17:57 -0800 (PST)
Received: by mail-ie0-f175.google.com with SMTP id x13so2117142ief.20
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 19 Dec 2013 13:17:56 -0800 (PST)
In-Reply-To: <1387487551-1612-3-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Dec 19, 2013 at 10:12 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> When I forked haswell_crtc_enable I copied all the code from
> ironlake_crtc_enable. The last piece of the function contains a big
> comment with a call to intel_wait_for_vblank. After this fork, we
> rearranged the Haswell code so that it enables the planes as the very
> last step of the modeset sequence, so we're sure that we call
> intel_enable_primary_plane after the pipe is really running, so the
> vblank waiting functions work as expected. I really believe this is
> what fixes the problem described by the big comment, so let's give it
> a try and get rid of that intel_wait_for_vblank, saving around 16ms
> per modeset (and init/resume). We can always revert if needed :)
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

If kms_flip doesn't start failing you're good. Iirc I've added some
flip vs. modeset and flip vs. dpms tests specifically for this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch