From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60EE7C433E0 for ; Wed, 24 Feb 2021 16:17:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBE4A64E85 for ; Wed, 24 Feb 2021 16:17:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBE4A64E85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4D0E6E8AB; Wed, 24 Feb 2021 16:17:25 +0000 (UTC) Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id 214936E8AB for ; Wed, 24 Feb 2021 16:17:25 +0000 (UTC) Received: by mail-ot1-x332.google.com with SMTP id s3so2661956otg.5 for ; Wed, 24 Feb 2021 08:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WoFEQ1/bfKoFI9xvg8DWul0UZStnDpuh33pXiEHG16U=; b=N4/rUSMsYrYBLT2mWYW11Tj9i5sFyWaQXEkIWwmk5faDg80d4hXBplnYGQb9fvPTVg hjP97F8wrC7M83DOiTXQ1mubWe8HtNkh9bTaT4tfOOL2gcASsySWCWKbJJpuDagAyl2R wJMirrr073YqLP+Rq4+WnrHyHvuoa6PNBGeL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WoFEQ1/bfKoFI9xvg8DWul0UZStnDpuh33pXiEHG16U=; b=lGbu8yxBjGBb3mqjydIuNPwYZt6xUSn5R7itpfmkiIwrzIlBMeNl0cq8Jf89+ap+i0 /7CfJ359CR3v+b+/FllEOfxdDFrLNI3JYT/QHMXEgH9VpEHLPOwWQBJnqZhDnu/s5G73 2gx6IHk4Ee5cnWAp+uGWEaoyiUN/8bHmCM3+JXfdvaBftUDH5p7Mh+fQn5yfSqKydAxS byaFB6pfPbCVfDZVDZQltGodGsa2afoh/SDjpN4apuZXmU4uOGQDVMqzGq0D1o9w6Gw6 mqRahsZ9JhLgf6KE8DWCGDHvA3qdrBXr9HV4FO8a0YhGYZ5Lm5NS3oxvltH7Zht8+HA3 C/xg== X-Gm-Message-State: AOAM530O2BR668U/6VVhPXg40WAViAygpvYrNTjMaErExG25UPkjqnTj QeB62sWjC1Ya0cwkZvN2aCF+dOUqbFU6m9QR5RlPTQ== X-Google-Smtp-Source: ABdhPJy5Y98h9GUiqrOFjUQF2+PwNwCz5OXAmFFcvCNRB9jriSwRzPjd90bBKiziOEProUm0GiPXnDfVdnnviyzzWx4= X-Received: by 2002:a9d:2265:: with SMTP id o92mr24849267ota.188.1614183444301; Wed, 24 Feb 2021 08:17:24 -0800 (PST) MIME-Version: 1.0 References: <54ae54f9-1ba9-900b-a56f-f48e2c9a82b0@suse.com> In-Reply-To: From: Daniel Vetter Date: Wed, 24 Feb 2021 17:17:13 +0100 Message-ID: Subject: Re: [PATCH] drm/xen: adjust Kconfig To: Oleksandr Andrushchenko X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , "dri-devel@lists.freedesktop.org" , Jan Beulich Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko wrote: > > Hello, Jan! > > On 2/23/21 6:41 PM, Jan Beulich wrote: > > By having selected DRM_XEN, I was assuming I would build the frontend > > driver. As it turns out this is a dummy option, and I have really not > > been building this (because I had DRM disabled). Make it a promptless > > one, moving the "depends on" to the other, real option, and "select"ing > > the dummy one. > > > > Signed-off-by: Jan Beulich > Reviewed-by: Oleksandr Andrushchenko Since you're maintainer/committer, I'm assuming you'll also merge this? Always confusing when there's an r-b but nothing about whether the patch will get merged or not. -Daniel > > --- a/drivers/gpu/drm/xen/Kconfig > > +++ b/drivers/gpu/drm/xen/Kconfig > > @@ -1,15 +1,11 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > config DRM_XEN > > - bool "DRM Support for Xen guest OS" > > - depends on XEN > > - help > > - Choose this option if you want to enable DRM support > > - for Xen. > > + bool > > > > config DRM_XEN_FRONTEND > > tristate "Para-virtualized frontend driver for Xen guest OS" > > - depends on DRM_XEN > > - depends on DRM > > + depends on XEN && DRM > > + select DRM_XEN > > select DRM_KMS_HELPER > > select VIDEOMODE_HELPERS > > select XEN_XENBUS_FRONTEND > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 798EEC433DB for ; Wed, 24 Feb 2021 16:17:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C16964E85 for ; Wed, 24 Feb 2021 16:17:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C16964E85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.89420.168420 (Exim 4.92) (envelope-from ) id 1lEwqu-0003LK-Fo; Wed, 24 Feb 2021 16:17:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 89420.168420; Wed, 24 Feb 2021 16:17:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEwqu-0003LD-Bx; Wed, 24 Feb 2021 16:17:28 +0000 Received: by outflank-mailman (input) for mailman id 89420; Wed, 24 Feb 2021 16:17:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lEwqs-0003L8-8O for xen-devel@lists.xenproject.org; Wed, 24 Feb 2021 16:17:27 +0000 Received: from mail-ot1-x332.google.com (unknown [2607:f8b0:4864:20::332]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c4207b38-3a37-4950-9d44-a8cfd7764962; Wed, 24 Feb 2021 16:17:24 +0000 (UTC) Received: by mail-ot1-x332.google.com with SMTP id s6so2661640otk.4 for ; Wed, 24 Feb 2021 08:17:24 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4207b38-3a37-4950-9d44-a8cfd7764962 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WoFEQ1/bfKoFI9xvg8DWul0UZStnDpuh33pXiEHG16U=; b=N4/rUSMsYrYBLT2mWYW11Tj9i5sFyWaQXEkIWwmk5faDg80d4hXBplnYGQb9fvPTVg hjP97F8wrC7M83DOiTXQ1mubWe8HtNkh9bTaT4tfOOL2gcASsySWCWKbJJpuDagAyl2R wJMirrr073YqLP+Rq4+WnrHyHvuoa6PNBGeL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WoFEQ1/bfKoFI9xvg8DWul0UZStnDpuh33pXiEHG16U=; b=HOYD93mfJbOnbLERVUPAidGlsSxoyAdQCa8nk1WAwb+74hKmobwwljmUYoGjzohBUP otebEJ8lyIouM8vO2lkFL7IMBatmCpu8/4t44gxHCa/AsmCPvhhW5Kg2hb5m9P6sIGrJ JREi5f/7HTq+S0NgojXYV+JU9dHg8IKfdYzq8oXag97PhU/D6LpvqViKzvRcdP1T2Fxb 8YHDrmd2bmkRYFtOivcy5Tqa/YytUdl6GBbx3fJnXEW2En37GGk93qoq0MzJKx13V1mU mStpbcp6pQCC4BtCqpCYsCG4WKRrOHy5GwW1gfNMg1dtvP8k9f364Ubd+I3B/yFwpg6c FeMw== X-Gm-Message-State: AOAM532mBVSX7Z4ahPJJBWDrrH2YGSSUb5fbuM43NgsMXiYPrSTmc7qO O+yKL6CVy1zCSImBcGrxcG+iwkzZ5S5vDKoeUPOzCA== X-Google-Smtp-Source: ABdhPJy5Y98h9GUiqrOFjUQF2+PwNwCz5OXAmFFcvCNRB9jriSwRzPjd90bBKiziOEProUm0GiPXnDfVdnnviyzzWx4= X-Received: by 2002:a9d:2265:: with SMTP id o92mr24849267ota.188.1614183444301; Wed, 24 Feb 2021 08:17:24 -0800 (PST) MIME-Version: 1.0 References: <54ae54f9-1ba9-900b-a56f-f48e2c9a82b0@suse.com> In-Reply-To: From: Daniel Vetter Date: Wed, 24 Feb 2021 17:17:13 +0100 Message-ID: Subject: Re: [PATCH] drm/xen: adjust Kconfig To: Oleksandr Andrushchenko Cc: Jan Beulich , "xen-devel@lists.xenproject.org" , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset="UTF-8" On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko wrote: > > Hello, Jan! > > On 2/23/21 6:41 PM, Jan Beulich wrote: > > By having selected DRM_XEN, I was assuming I would build the frontend > > driver. As it turns out this is a dummy option, and I have really not > > been building this (because I had DRM disabled). Make it a promptless > > one, moving the "depends on" to the other, real option, and "select"ing > > the dummy one. > > > > Signed-off-by: Jan Beulich > Reviewed-by: Oleksandr Andrushchenko Since you're maintainer/committer, I'm assuming you'll also merge this? Always confusing when there's an r-b but nothing about whether the patch will get merged or not. -Daniel > > --- a/drivers/gpu/drm/xen/Kconfig > > +++ b/drivers/gpu/drm/xen/Kconfig > > @@ -1,15 +1,11 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > config DRM_XEN > > - bool "DRM Support for Xen guest OS" > > - depends on XEN > > - help > > - Choose this option if you want to enable DRM support > > - for Xen. > > + bool > > > > config DRM_XEN_FRONTEND > > tristate "Para-virtualized frontend driver for Xen guest OS" > > - depends on DRM_XEN > > - depends on DRM > > + depends on XEN && DRM > > + select DRM_XEN > > select DRM_KMS_HELPER > > select VIDEOMODE_HELPERS > > select XEN_XENBUS_FRONTEND > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch