From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139AbcELKof (ORCPT ); Thu, 12 May 2016 06:44:35 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34140 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499AbcELKoa convert rfc822-to-8bit (ORCPT ); Thu, 12 May 2016 06:44:30 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:56b5:0:ac27:b86c:7764:9429] In-Reply-To: <6af69339-13f1-433e-b343-dfa4dff9734c@tronnes.org> References: <1462982962-10530-1-git-send-email-noralf@tronnes.org> <1462982962-10530-7-git-send-email-noralf@tronnes.org> <20160511170910.GU27098@phenom.ffwll.local> <20160512081119.GV27098@phenom.ffwll.local> <6af69339-13f1-433e-b343-dfa4dff9734c@tronnes.org> Date: Thu, 12 May 2016 12:44:29 +0200 X-Google-Sender-Auth: oEt14sv75QDfz27mvFyT3AV8yW4 Message-ID: Subject: Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline From: Daniel Vetter To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2016 at 12:18 PM, Noralf Trønnes wrote: > Den 12.05.2016 10:11, skrev Daniel Vetter: >> >> On Wed, May 11, 2016 at 07:09:10PM +0200, Daniel Vetter wrote: >>> >>> On Wed, May 11, 2016 at 06:09:22PM +0200, Noralf Trønnes wrote: >>>> >>>> +/** >>>> + * drm_simple_display_pipe_init - Initialize a simple display pipeline >>>> + * @dev: DRM device >>>> + * @pipe: simple display pipe object to initialize >>>> + * @funcs: callbacks for the display pipe (optional) >>>> + * @formats: array of supported formats (%DRM_FORMAT_*) >>>> + * @format_count: number of elements in @formats >>>> + * @connector: connector to attach and register >>>> + * >>>> + * Sets up a display pipeline which consist of a really simple >>>> + * plane-crtc-encoder pipe coupled with the provided connector. >>> >>> How are drivers supposed to release this stuff again? Maybe add: >>> >>> "Teardown of a simple display pipe is all handled automatically by the >>> drm >>> core through calling drm_mode_config_cleanup()." >> >> Thought a bit more about this, maybe we should also add "Drivers >> afterwards need to release the memory for the structure themselves." >> >> Btw one other thing I realized is that there's no atomic_commit for this. >> How do you plane to implement async commit? No need to address this right >> away, we can discuss it when you've rebased tinydrm and submit that for >> review. >> -Daniel > > > I don't follow you here. Isn't this atomic_commit: > > drm_atomic_helper_commit => drm_atomic_helper_commit_planes => > drm_simple_kms_plane_atomic_update => pipe->funcs->update drm_atomic_helper_commit does not implement nonblocking commits, because that's a bit tricky when there's more than 1 crtc. But if you only have 1 crtc it's easy. And without nonblocking commit the legacy pageflip stuff will also not work. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 6/6] drm: Add helper for simple display pipeline Date: Thu, 12 May 2016 12:44:29 +0200 Message-ID: References: <1462982962-10530-1-git-send-email-noralf@tronnes.org> <1462982962-10530-7-git-send-email-noralf@tronnes.org> <20160511170910.GU27098@phenom.ffwll.local> <20160512081119.GV27098@phenom.ffwll.local> <6af69339-13f1-433e-b343-dfa4dff9734c@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-oi0-x242.google.com (mail-oi0-x242.google.com [IPv6:2607:f8b0:4003:c06::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2209B6E7FE for ; Thu, 12 May 2016 10:44:30 +0000 (UTC) Received: by mail-oi0-x242.google.com with SMTP id w198so11775830oiw.2 for ; Thu, 12 May 2016 03:44:30 -0700 (PDT) In-Reply-To: <6af69339-13f1-433e-b343-dfa4dff9734c@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Cc: Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMTIsIDIwMTYgYXQgMTI6MTggUE0sIE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxm QHRyb25uZXMub3JnPiB3cm90ZToKPiBEZW4gMTIuMDUuMjAxNiAxMDoxMSwgc2tyZXYgRGFuaWVs IFZldHRlcjoKPj4KPj4gT24gV2VkLCBNYXkgMTEsIDIwMTYgYXQgMDc6MDk6MTBQTSArMDIwMCwg RGFuaWVsIFZldHRlciB3cm90ZToKPj4+Cj4+PiBPbiBXZWQsIE1heSAxMSwgMjAxNiBhdCAwNjow OToyMlBNICswMjAwLCBOb3JhbGYgVHLDuG5uZXMgd3JvdGU6Cj4+Pj4KPj4+PiArLyoqCj4+Pj4g KyAqIGRybV9zaW1wbGVfZGlzcGxheV9waXBlX2luaXQgLSBJbml0aWFsaXplIGEgc2ltcGxlIGRp c3BsYXkgcGlwZWxpbmUKPj4+PiArICogQGRldjogRFJNIGRldmljZQo+Pj4+ICsgKiBAcGlwZTog c2ltcGxlIGRpc3BsYXkgcGlwZSBvYmplY3QgdG8gaW5pdGlhbGl6ZQo+Pj4+ICsgKiBAZnVuY3M6 IGNhbGxiYWNrcyBmb3IgdGhlIGRpc3BsYXkgcGlwZSAob3B0aW9uYWwpCj4+Pj4gKyAqIEBmb3Jt YXRzOiBhcnJheSBvZiBzdXBwb3J0ZWQgZm9ybWF0cyAoJURSTV9GT1JNQVRfKikKPj4+PiArICog QGZvcm1hdF9jb3VudDogbnVtYmVyIG9mIGVsZW1lbnRzIGluIEBmb3JtYXRzCj4+Pj4gKyAqIEBj b25uZWN0b3I6IGNvbm5lY3RvciB0byBhdHRhY2ggYW5kIHJlZ2lzdGVyCj4+Pj4gKyAqCj4+Pj4g KyAqIFNldHMgdXAgYSBkaXNwbGF5IHBpcGVsaW5lIHdoaWNoIGNvbnNpc3Qgb2YgYSByZWFsbHkg c2ltcGxlCj4+Pj4gKyAqIHBsYW5lLWNydGMtZW5jb2RlciBwaXBlIGNvdXBsZWQgd2l0aCB0aGUg cHJvdmlkZWQgY29ubmVjdG9yLgo+Pj4KPj4+IEhvdyBhcmUgZHJpdmVycyBzdXBwb3NlZCB0byBy ZWxlYXNlIHRoaXMgc3R1ZmYgYWdhaW4/IE1heWJlIGFkZDoKPj4+Cj4+PiAiVGVhcmRvd24gb2Yg YSBzaW1wbGUgZGlzcGxheSBwaXBlIGlzIGFsbCBoYW5kbGVkIGF1dG9tYXRpY2FsbHkgYnkgdGhl Cj4+PiBkcm0KPj4+IGNvcmUgdGhyb3VnaCBjYWxsaW5nIGRybV9tb2RlX2NvbmZpZ19jbGVhbnVw KCkuIgo+Pgo+PiBUaG91Z2h0IGEgYml0IG1vcmUgYWJvdXQgdGhpcywgbWF5YmUgd2Ugc2hvdWxk IGFsc28gYWRkICJEcml2ZXJzCj4+IGFmdGVyd2FyZHMgbmVlZCB0byByZWxlYXNlIHRoZSBtZW1v cnkgZm9yIHRoZSBzdHJ1Y3R1cmUgdGhlbXNlbHZlcy4iCj4+Cj4+IEJ0dyBvbmUgb3RoZXIgdGhp bmcgSSByZWFsaXplZCBpcyB0aGF0IHRoZXJlJ3Mgbm8gYXRvbWljX2NvbW1pdCBmb3IgdGhpcy4K Pj4gSG93IGRvIHlvdSBwbGFuZSB0byBpbXBsZW1lbnQgYXN5bmMgY29tbWl0PyBObyBuZWVkIHRv IGFkZHJlc3MgdGhpcyByaWdodAo+PiBhd2F5LCB3ZSBjYW4gZGlzY3VzcyBpdCB3aGVuIHlvdSd2 ZSByZWJhc2VkIHRpbnlkcm0gYW5kIHN1Ym1pdCB0aGF0IGZvcgo+PiByZXZpZXcuCj4+IC1EYW5p ZWwKPgo+Cj4gSSBkb24ndCBmb2xsb3cgeW91IGhlcmUuIElzbid0IHRoaXMgYXRvbWljX2NvbW1p dDoKPgo+IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdCA9PiBkcm1fYXRvbWljX2hlbHBlcl9jb21t aXRfcGxhbmVzID0+Cj4gZHJtX3NpbXBsZV9rbXNfcGxhbmVfYXRvbWljX3VwZGF0ZSA9PiBwaXBl LT5mdW5jcy0+dXBkYXRlCgpkcm1fYXRvbWljX2hlbHBlcl9jb21taXQgZG9lcyBub3QgaW1wbGVt ZW50IG5vbmJsb2NraW5nIGNvbW1pdHMsCmJlY2F1c2UgdGhhdCdzIGEgYml0IHRyaWNreSB3aGVu IHRoZXJlJ3MgbW9yZSB0aGFuIDEgY3J0Yy4gQnV0IGlmIHlvdQpvbmx5IGhhdmUgMSBjcnRjIGl0 J3MgZWFzeS4gQW5kIHdpdGhvdXQgbm9uYmxvY2tpbmcgY29tbWl0IHRoZSBsZWdhY3kKcGFnZWZs aXAgc3R1ZmYgd2lsbCBhbHNvIG5vdCB3b3JrLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNv ZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAt IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=