From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7031C43461 for ; Tue, 15 Sep 2020 11:24:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46B3B20872 for ; Tue, 15 Sep 2020 11:24:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Ab3Cclpc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726265AbgIOLX4 (ORCPT ); Tue, 15 Sep 2020 07:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbgIOLSI (ORCPT ); Tue, 15 Sep 2020 07:18:08 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF1FEC061223 for ; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id 60so2831975otw.3 for ; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wAqBxwSqHBPcdUvSTQKCijq+CRd5S/6aTYUwocFvz7g=; b=Ab3CclpcmjliQcUxf05Du8gVcg1tOOkwjfN7S7+mMKqY+QobElboTlKKG/K3TtoDAg jN9ksqtTvV5K0CkYWOyTD6EOOpJPBKcoEScWZBBaDrPlA0EBfsG9cf/MIcMhL1dmKZ7I /Vtos2xPEWUgcsEiyEAAfW1BnOmbyKfP4VBbE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wAqBxwSqHBPcdUvSTQKCijq+CRd5S/6aTYUwocFvz7g=; b=O4zdutlYckkHHvEDc7+AOMKwhbMvwlIaGCcp+aBFFW4So3u+P8TPdKmoaomsI1KIMJ lrFupFXpuDqRTGKxEXQUTKFv+NHxb0X1138/Lyj46r6+PRwR2FiaYMOeI9Kk5JHto1Cr DrkAk2re1C8UamxmXgbJjvVI6vn3/4Jprh5pKitxP9sarlH8KRY9wuzBLCYhRwq2iw2V v0Q/EYu3oMz9kNG6PpZRPpJXFzUt7GQLej8NO28gimQd5/3JOi9IYh/X3e6cW4HQW8nP TADJPaKjeIyDhKjQSFi7EG5N87VFgiOxe+bN+dzfOKlDAlz+SK0GoO5GFnPpHtuo34kN YisA== X-Gm-Message-State: AOAM531mKNx6N1DoqTvU7yc93fm+ZJ05MmtMSLT3HP39IxsL9UR2nk6E R3V96K6axtKWm+VMB0JMpsldcc1wA+zFvV0fLT1gEQ== X-Google-Smtp-Source: ABdhPJy2dt3RJ1FG4/6bhDA1qzn4xmAgfk+y6FmsSUEi6ZJD7I1IcHsBaS6ztwX2Dy4bot9PsL6PWq1L3saj3QmAlOM= X-Received: by 2002:a05:6830:14d9:: with SMTP id t25mr13128038otq.188.1600168050256; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) MIME-Version: 1.0 References: <20200914132920.59183-1-christian.koenig@amd.com> <20200914132920.59183-2-christian.koenig@amd.com> <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> In-Reply-To: <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> From: Daniel Vetter Date: Tue, 15 Sep 2020 13:07:18 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/shmem-helpers: revert "Redirect mmap for imported dma-buf" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Andrew Morton , Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 1:03 PM Christian K=C3=B6nig wrote: > > Am 15.09.20 um 12:39 schrieb Daniel Vetter: > > On Mon, Sep 14, 2020 at 3:29 PM Christian K=C3=B6nig > > wrote: > >> This reverts commit 26d3ac3cb04d171a861952e89324e347598a347f. > >> > >> We need to figure out if dma_buf_mmap() is valid or not first. > >> > >> Signed-off-by: Christian K=C3=B6nig > > The trouble is that doing dma-buf mmap by looking at the struct pages > > behind the sg list and just inserting those into userspace doesn't > > really work any better. You still won't get the unmap_mapping_range > > and hence pte shoot-down. So maybe dma_buf_mmap forwarding doesn't > > work, but this doesn't make it any better. > > Good point. Question is what should we do? Return -EPERM? IIrc there's userspace which expects this to work, but I think it's also only trying to do this with simpler drivers that don't need unmap_mapping_range to work correctly. Or it's simply that no one ever reported the bugs. It's a bit a mess :-/ -Daniel > > > > > Also commit message should probably explain a bit the context here, > > not a lot of people have been in our private discussion on this. > > Well, that's certain true. > > Christian. > > > -Daniel > > > >> --- > >> drivers/gpu/drm/drm_gem_shmem_helper.c | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/= drm_gem_shmem_helper.c > >> index 0a952f27c184..cd727343f72b 100644 > >> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > >> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > >> @@ -594,9 +594,6 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj,= struct vm_area_struct *vma) > >> /* Remove the fake offset */ > >> vma->vm_pgoff -=3D drm_vma_node_start(&obj->vma_node); > >> > >> - if (obj->import_attach) > >> - return dma_buf_mmap(obj->dma_buf, vma, 0); > >> - > >> shmem =3D to_drm_gem_shmem_obj(obj); > >> > >> ret =3D drm_gem_shmem_get_pages(shmem); > >> -- > >> 2.17.1 > >> > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F192AC2D0E3 for ; Tue, 15 Sep 2020 11:07:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C69AB21D7B for ; Tue, 15 Sep 2020 11:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Ab3Cclpc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C69AB21D7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4CA846B00C5; Tue, 15 Sep 2020 07:07:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 479136B00C6; Tue, 15 Sep 2020 07:07:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38ECE6B00C7; Tue, 15 Sep 2020 07:07:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 184E86B00C5 for ; Tue, 15 Sep 2020 07:07:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D0E8C2C93 for ; Tue, 15 Sep 2020 11:07:31 +0000 (UTC) X-FDA: 77265019902.02.low49_05155d227110 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id B521910097AA8 for ; Tue, 15 Sep 2020 11:07:31 +0000 (UTC) X-HE-Tag: low49_05155d227110 X-Filterd-Recvd-Size: 5425 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 11:07:31 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id g10so2799741otq.9 for ; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wAqBxwSqHBPcdUvSTQKCijq+CRd5S/6aTYUwocFvz7g=; b=Ab3CclpcmjliQcUxf05Du8gVcg1tOOkwjfN7S7+mMKqY+QobElboTlKKG/K3TtoDAg jN9ksqtTvV5K0CkYWOyTD6EOOpJPBKcoEScWZBBaDrPlA0EBfsG9cf/MIcMhL1dmKZ7I /Vtos2xPEWUgcsEiyEAAfW1BnOmbyKfP4VBbE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wAqBxwSqHBPcdUvSTQKCijq+CRd5S/6aTYUwocFvz7g=; b=lEPpG6/BtSZdJ+IbXge62c5QELkL/5ZdRRYIyKnZF2hJuA8gzzIbWveN/mqOt83Rdh C+dTzLLkl2U9AK53nDryQaNSb5LF0fCym/JHrlx3eci4TqOma4L8ZdIusfD3Pycs/fuH qqdlDMryzNTJGRiKlyIuIUZymoygAIAy0/4XCk9OBZedPu+SjsDq3iqac536Q2jaD0nW 8PgrWF0vHiXch2gA4V8R8oR0/gkih3gmX0jIrsIS3ZIU/zEShQ1xgFNPG7HpCPggzmfq FNVlsqejJjiC1kLPyMfvCQNpxYRuvM7H4WiDTt080M6Tq0riZgrfQnT14CcYuHfsiL6F mEQA== X-Gm-Message-State: AOAM530f97T17ONJspUASbPcjGmB7srLzo1QoZupTzFfmwjkfi5LK+Gu 5DZoVVtrrKaMvryuV+6gANTyQxwEGfWPiCHcP+Ul0Q== X-Google-Smtp-Source: ABdhPJy2dt3RJ1FG4/6bhDA1qzn4xmAgfk+y6FmsSUEi6ZJD7I1IcHsBaS6ztwX2Dy4bot9PsL6PWq1L3saj3QmAlOM= X-Received: by 2002:a05:6830:14d9:: with SMTP id t25mr13128038otq.188.1600168050256; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) MIME-Version: 1.0 References: <20200914132920.59183-1-christian.koenig@amd.com> <20200914132920.59183-2-christian.koenig@amd.com> <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> In-Reply-To: <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> From: Daniel Vetter Date: Tue, 15 Sep 2020 13:07:18 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/shmem-helpers: revert "Redirect mmap for imported dma-buf" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Andrew Morton , Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B521910097AA8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 1:03 PM Christian K=C3=B6nig wrote: > > Am 15.09.20 um 12:39 schrieb Daniel Vetter: > > On Mon, Sep 14, 2020 at 3:29 PM Christian K=C3=B6nig > > wrote: > >> This reverts commit 26d3ac3cb04d171a861952e89324e347598a347f. > >> > >> We need to figure out if dma_buf_mmap() is valid or not first. > >> > >> Signed-off-by: Christian K=C3=B6nig > > The trouble is that doing dma-buf mmap by looking at the struct pages > > behind the sg list and just inserting those into userspace doesn't > > really work any better. You still won't get the unmap_mapping_range > > and hence pte shoot-down. So maybe dma_buf_mmap forwarding doesn't > > work, but this doesn't make it any better. > > Good point. Question is what should we do? Return -EPERM? IIrc there's userspace which expects this to work, but I think it's also only trying to do this with simpler drivers that don't need unmap_mapping_range to work correctly. Or it's simply that no one ever reported the bugs. It's a bit a mess :-/ -Daniel > > > > > Also commit message should probably explain a bit the context here, > > not a lot of people have been in our private discussion on this. > > Well, that's certain true. > > Christian. > > > -Daniel > > > >> --- > >> drivers/gpu/drm/drm_gem_shmem_helper.c | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/= drm_gem_shmem_helper.c > >> index 0a952f27c184..cd727343f72b 100644 > >> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > >> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > >> @@ -594,9 +594,6 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj,= struct vm_area_struct *vma) > >> /* Remove the fake offset */ > >> vma->vm_pgoff -=3D drm_vma_node_start(&obj->vma_node); > >> > >> - if (obj->import_attach) > >> - return dma_buf_mmap(obj->dma_buf, vma, 0); > >> - > >> shmem =3D to_drm_gem_shmem_obj(obj); > >> > >> ret =3D drm_gem_shmem_get_pages(shmem); > >> -- > >> 2.17.1 > >> > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFEEC43461 for ; Tue, 15 Sep 2020 11:07:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E370121D1B for ; Tue, 15 Sep 2020 11:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Ab3Cclpc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E370121D1B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23B4989FFD; Tue, 15 Sep 2020 11:07:32 +0000 (UTC) Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 313EB89FFD for ; Tue, 15 Sep 2020 11:07:30 +0000 (UTC) Received: by mail-ot1-x343.google.com with SMTP id a2so2776090otr.11 for ; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wAqBxwSqHBPcdUvSTQKCijq+CRd5S/6aTYUwocFvz7g=; b=Ab3CclpcmjliQcUxf05Du8gVcg1tOOkwjfN7S7+mMKqY+QobElboTlKKG/K3TtoDAg jN9ksqtTvV5K0CkYWOyTD6EOOpJPBKcoEScWZBBaDrPlA0EBfsG9cf/MIcMhL1dmKZ7I /Vtos2xPEWUgcsEiyEAAfW1BnOmbyKfP4VBbE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wAqBxwSqHBPcdUvSTQKCijq+CRd5S/6aTYUwocFvz7g=; b=tmwYYNmTYlSBQk2zfPJLezA9TzKu3THZiWH0UTbmSAF/sSW7pOQ4zw9mvWNwRy8YE4 zcgTmtUPuYQy2GKl8jg2VaM7obiLSIaB+qY74dUwNTZ4689GpKvtiluwblMi4uO+4yEY X4z4oL+kCDsvZC3wfnNFgb+G3M+gD05fGaX0fgs046ks3ll5nmesvn1/1LuWoWDEfzKI u8FPzNBBg0tYig1hLSRhObdCr2he2q++ZaIwh+luoCb92v0CvhHg3HKDwP4osPviiKtx vSgE20cUJvDyA+3q4Q8cLGObsU+/gfVNsukMrmvlmdG+fOU2yXaqSPJOxasAzSn4zWGO Okag== X-Gm-Message-State: AOAM5310BdmmDDcfGho1r+diyYABlouWkafKaXqojl0r09jRjhV2yTqX AX1iUBb/ZlOTwhqkcEPP33xrgEbj2DriFNwa9gvhQsYEgcm4pg== X-Google-Smtp-Source: ABdhPJy2dt3RJ1FG4/6bhDA1qzn4xmAgfk+y6FmsSUEi6ZJD7I1IcHsBaS6ztwX2Dy4bot9PsL6PWq1L3saj3QmAlOM= X-Received: by 2002:a05:6830:14d9:: with SMTP id t25mr13128038otq.188.1600168050256; Tue, 15 Sep 2020 04:07:30 -0700 (PDT) MIME-Version: 1.0 References: <20200914132920.59183-1-christian.koenig@amd.com> <20200914132920.59183-2-christian.koenig@amd.com> <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> In-Reply-To: <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> From: Daniel Vetter Date: Tue, 15 Sep 2020 13:07:18 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/shmem-helpers: revert "Redirect mmap for imported dma-buf" To: =?UTF-8?Q?Christian_K=C3=B6nig?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , Andrew Morton , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBTZXAgMTUsIDIwMjAgYXQgMTowMyBQTSBDaHJpc3RpYW4gS8O2bmlnCjxja29lbmln LmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBBbSAxNS4wOS4yMCB1bSAxMjoz OSBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gPiBPbiBNb24sIFNlcCAxNCwgMjAyMCBhdCAzOjI5 IFBNIENocmlzdGlhbiBLw7ZuaWcKPiA+IDxja29lbmlnLmxlaWNodHp1bWVya2VuQGdtYWlsLmNv bT4gd3JvdGU6Cj4gPj4gVGhpcyByZXZlcnRzIGNvbW1pdCAyNmQzYWMzY2IwNGQxNzFhODYxOTUy ZTg5MzI0ZTM0NzU5OGEzNDdmLgo+ID4+Cj4gPj4gV2UgbmVlZCB0byBmaWd1cmUgb3V0IGlmIGRt YV9idWZfbW1hcCgpIGlzIHZhbGlkIG9yIG5vdCBmaXJzdC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYt Ynk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiA+IFRoZSB0 cm91YmxlIGlzIHRoYXQgZG9pbmcgZG1hLWJ1ZiBtbWFwIGJ5IGxvb2tpbmcgYXQgdGhlIHN0cnVj dCBwYWdlcwo+ID4gYmVoaW5kIHRoZSBzZyBsaXN0IGFuZCBqdXN0IGluc2VydGluZyB0aG9zZSBp bnRvIHVzZXJzcGFjZSBkb2Vzbid0Cj4gPiByZWFsbHkgd29yayBhbnkgYmV0dGVyLiBZb3Ugc3Rp bGwgd29uJ3QgZ2V0IHRoZSB1bm1hcF9tYXBwaW5nX3JhbmdlCj4gPiBhbmQgaGVuY2UgcHRlIHNo b290LWRvd24uIFNvIG1heWJlIGRtYV9idWZfbW1hcCBmb3J3YXJkaW5nIGRvZXNuJ3QKPiA+IHdv cmssIGJ1dCB0aGlzIGRvZXNuJ3QgbWFrZSBpdCBhbnkgYmV0dGVyLgo+Cj4gR29vZCBwb2ludC4g UXVlc3Rpb24gaXMgd2hhdCBzaG91bGQgd2UgZG8/IFJldHVybiAtRVBFUk0/CgpJSXJjIHRoZXJl J3MgdXNlcnNwYWNlIHdoaWNoIGV4cGVjdHMgdGhpcyB0byB3b3JrLCBidXQgSSB0aGluayBpdCdz CmFsc28gb25seSB0cnlpbmcgdG8gZG8gdGhpcyB3aXRoIHNpbXBsZXIgZHJpdmVycyB0aGF0IGRv bid0IG5lZWQKdW5tYXBfbWFwcGluZ19yYW5nZSB0byB3b3JrIGNvcnJlY3RseS4gT3IgaXQncyBz aW1wbHkgdGhhdCBubyBvbmUgZXZlcgpyZXBvcnRlZCB0aGUgYnVncy4gSXQncyBhIGJpdCBhIG1l c3MgOi0vCi1EYW5pZWwKCj4KPiA+Cj4gPiBBbHNvIGNvbW1pdCBtZXNzYWdlIHNob3VsZCBwcm9i YWJseSBleHBsYWluIGEgYml0IHRoZSBjb250ZXh0IGhlcmUsCj4gPiBub3QgYSBsb3Qgb2YgcGVv cGxlIGhhdmUgYmVlbiBpbiBvdXIgcHJpdmF0ZSBkaXNjdXNzaW9uIG9uIHRoaXMuCj4KPiBXZWxs LCB0aGF0J3MgY2VydGFpbiB0cnVlLgo+Cj4gQ2hyaXN0aWFuLgo+Cj4gPiAtRGFuaWVsCj4gPgo+ ID4+IC0tLQo+ID4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVyLmMgfCAz IC0tLQo+ID4+ICAgMSBmaWxlIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVyLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYwo+ID4+IGluZGV4IDBhOTUyZjI3YzE4NC4u Y2Q3MjczNDNmNzJiIDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3No bWVtX2hlbHBlci5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVs cGVyLmMKPiA+PiBAQCAtNTk0LDkgKzU5NCw2IEBAIGludCBkcm1fZ2VtX3NobWVtX21tYXAoc3Ry dWN0IGRybV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqdm1hKQo+ID4+ ICAgICAgICAgIC8qIFJlbW92ZSB0aGUgZmFrZSBvZmZzZXQgKi8KPiA+PiAgICAgICAgICB2bWEt PnZtX3Bnb2ZmIC09IGRybV92bWFfbm9kZV9zdGFydCgmb2JqLT52bWFfbm9kZSk7Cj4gPj4KPiA+ PiAtICAgICAgIGlmIChvYmotPmltcG9ydF9hdHRhY2gpCj4gPj4gLSAgICAgICAgICAgICAgIHJl dHVybiBkbWFfYnVmX21tYXAob2JqLT5kbWFfYnVmLCB2bWEsIDApOwo+ID4+IC0KPiA+PiAgICAg ICAgICBzaG1lbSA9IHRvX2RybV9nZW1fc2htZW1fb2JqKG9iaik7Cj4gPj4KPiA+PiAgICAgICAg ICByZXQgPSBkcm1fZ2VtX3NobWVtX2dldF9wYWdlcyhzaG1lbSk7Cj4gPj4gLS0KPiA+PiAyLjE3 LjEKPiA+Pgo+ID4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiA+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo+ID4KPiA+Cj4KCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==