From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/amd/display: DC I2C review Date: Thu, 28 Sep 2017 08:46:58 +0200 Message-ID: References: <20170927194641.29146-1-harry.wentland@amd.com> <20170927194641.29146-4-harry.wentland@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170927194641.29146-4-harry.wentland-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Harry Wentland Cc: "alexander.deucher-5C7GfCeVMHo@public.gmane.org" , Daniel Vetter , Sean Paul , dri-devel , amd-gfx list List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMjcsIDIwMTcgYXQgOTo0NiBQTSwgSGFycnkgV2VudGxhbmQgPGhhcnJ5Lndl bnRsYW5kQGFtZC5jb20+IHdyb3RlOgo+IFdoaWxlIHJldmlld2luZyBJMkMgaW4gREMgaWRlbnRp ZmllZCBhIGZldyBwbGFjZXMuIEFkZGVkIGEgY291cGxlIHRvIHRoZQo+IFRPRE8gbGlzdC4KPgo+ IDEpIENvbm5lY3RvciBpbmZvIHJlYWQKPgo+IFNlZSBnZXRfZXh0X2Rpc3BsYXlfY29ubmVjdGlv bl9pbmZvCj4KPiBPbiBzb21lIGJvYXJkcyB0aGUgY29ubmVjdG9yIGluZm9ybWF0aW9uIGhhcyB0 byBiZSByZWFkIHRocm91Z2ggYQo+IHNwZWNpYWwgSTJDIGNoYW5uZWwuIFRoaXMgbGluZSBpcyBv bmx5IHVzZWQgZm9yIHRoaXMgcHVycG9zZSBhbmQgb25seSBvbgo+IGRyaXZlciBpbml0Lgo+Cj4g MikgU0NEQyBzdHVmZgo+Cj4gVGhpcyBzaG91bGQgYWxsIGJlIHJld29ya2VkIHRvIGdvIHRocm91 Z2ggRFJNJ3MgU0NEQyBjb2RlLiBXaGVuIHRoaXMgaXMKPiBkb25lIHNvbWUgdW5uZWNlc3Nhcnkg STJDIGNvZGUgY2FuIGJlIHJldGlyZWQgYXMgd2VsbC4KPgo+IDMpIE1heCBUTURTIGNsb2NrIHJl YWQKPgo+IFNlZSBkYWxfZGRjX3NlcnZpY2VfaTJjX3F1ZXJ5X2RwX2R1YWxfbW9kZV9hZGFwdG9y Cj4KPiBUaGlzIHNob3VsZCBoYXBwZW4gaW4gRFJNIGFzIHdlbGwuIEkgaGF2ZW4ndCBjaGVja2Vk IGlmIHRoZXJlJ3MKPiBjdXJyZW50bHkgZnVuY3Rpb25hbGl0eSBpbiBEUk0uIElmIG5vdCB3ZSBj YW4gcHJvcG9zZSBzb21ldGhpbmcuCj4KPiA0KSBIRE1JIHJldGltZXIgcHJvZ3JhbW1pbmcKPgo+ IFNvbWUgYm9hcmRzIGhhdmUgYW4gSERNSSByZXRpbWVyIHRoYXQgd2UgbmVlZCB0byBwcm9ncmFt IHRvIHBhc3MgUEhZCj4gY29tcGxpYW5jZS4KPgo+IDEgJiAzIG1pZ2h0IGJlIGEgZ29vZCBleGVy Y2lzZSBpZiBzb21lb25lIGlzIGxvb2tpbmcgZm9yIHRoaW5ncyB0byBkby4KPgo+IFNpZ25lZC1v ZmYtYnk6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvVE9ETyB8IDI2ICsrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvVE9ETyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9UT0RPCj4gaW5kZXggZWVhNjQ1YjEwMmExLi45ODEz NTJiYzk1ZjAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L1RPRE8K PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvVE9ETwo+IEBAIC02MiwyMCArNjIs MTAgQEAgVE9ET3MKPiAgICAgIH4gRGFuaWVsIFZldHRlcgo+Cj4KPiAtMTEuIFJlbW92ZSBleGlz dGluZyBpMmMgaW1wbGVtZW50YXRpb24gZnJvbSBEQwo+IC0KPiAtICAgICJTaW1pbGFyIHN0b3J5 IGZvciBpMmMsIGl0IHVzZXMgdGhlIGtlcm5lbCdzIGkyYyBjb2RlIG5vdywgYnV0IHRoZXJlJ3MK PiAtICAgIHN0aWxsIGEgZnVsbCBpMmMgaW1wbGVtZW50YXRpb24gaGlkZGVuIGJlbmVhdGggdGhh dCBpbgo+IC0gICAgZGlzcGxheS9kYy9pMmNhdXguIEtpbmRhIG5vdCBjb29sLCBidXQgaW1vIG9r IGlmIHlvdSBmaXggdGhhdAo+IC0gICAgcG9zdC1tZXJnaW5nIChwZXJoYXBzIGJ5IG5vdCBpbmNs dWRpbmcgYW55IG9mIHRoaXMgaW4gdGhlIGxpbnV4IERDCj4gLSAgICBjb2RlIGluIHRoZSB1cHN0 cmVhbSBrZXJuZWwsIGJ1dCBhcyBhbiBhdXggbW9kdWxlIGluIHlvdXIgaW50ZXJuYWwKPiAtICAg IGNvZGViYXNlIHNpbmNlIHRoZXJlIHlvdSBwcm9iYWJseSBuZWVkIHRoYXQsIHNhbWUgYXBwbGll cyB0byB0aGUgZWRpZAo+IC0gICAgcGFyc2luZyBEQyBzdGlsbCBkb2VzLiBGb3IgYm90aCBjYXNl cyBJIGFzc3VtZSB0aGF0IHRoZSBtaW5pbWFsIHNoaW0KPiAtICAgIHlvdSBuZWVkIG9uIGxpbnV4 IChiaXQgYmFuZ2luZyBhbmQgZWRpZCBwYXJzaW5nIGlzbid0IHJvY2tldCBzaW5jZSkgaXMKPiAt ICAgIGEgbG90IGxlc3MgdGhhbiB0aGUgZ2x1ZSBjb2RlIHRvIGludGVyZmFjZSB3aXRoIHRoZSBk Yy1wcm92aWRlZAo+IC0gICAgYWJzdHJhY3Rpb24uIgo+IC0gICAgfiBEYW5pZWwgVmV0dGVyCj4g LQo+ICsxMS4gUmVtb3ZlIGRjL2kyY2F1eC4gVGhpcyBmb2xkZXIgY2FuIGJlIHNvbWV3aGF0IG1p c2xlYWRpbmcuIEl0J3MgYmFzaWNhbGx5IGFuCj4gK292ZXJ5IGNvbXBsaWNhdGVkIEhXIHByb2dy YW1taW5nIGZ1bmN0aW9uIGZvciBzZW5kaW5kIGFuZCByZWNlaXZpbmcgaTJjL2F1eAo+ICtjb21t YW5kcy4gV2UgY2FuIGdyZWF0bHkgc2ltcGxpZnkgdGhhdCBhbmQgbW92ZSBpdCBpbnRvIGRjL2Rj ZVhZWiBsaWtlIG90aGVyCj4gK0hXIGJsb2Nrcy4KCkJlc3QgY2FzZSBJIHRoaW5rIHdvdWxkIGJl IGlmIHlvdSBkaXJlY3RseSBpbXBsZW1lbnQgdGhlIGkyY19hZGFwdGVyCmluIHRoZXJlLiBJdCdz IGEgdGlueSBhYnN0cmFjdGlvbi9hcGksIHNvIHNob3VsZCBiZSB0cml2aWFsIHRvCnJlaW1wbGVt ZW50IGZvciB0aGUgd2luZG93cyBzaWRlLiBPciBhdCBsZWFzdCBhbGlnbiByZWFsbHkgY2xvc2Vs eS4KRXZlbiBtb3JlIHNvIGZvciB0aGUgZ3BpbyBiaXQtYmFuZ2luZyBjYXNlLCB0aGF0IHNob3Vs ZCB1c2UgdGhlIGxpbnV4CmltcGxlbWVudGF0aW9uIEkgdGhpbmsuIE1pZ2h0IGJlIGdvb2QgdG8g Y2xhcmlmeS4KCkFueXdheSwgYWNrIG9uIHRoaXMuCgo+ICAxMi4gZHJtX21vZGVzZXRfbG9jayBp biBNU1Qgc2hvdWxkIG5vIGxvbmdlciBiZSBuZWVkZWQgaW4gcmVjZW50IGtlcm5lbHMKPiAgICAg ICogQWRvcHQgYXBwcm9wcmlhdGUgbG9ja2luZyBzY2hlbWUKPiBAQCAtMTEwLDMgKzEwMCwxMSBA QCBndWlsdHkuCj4gIHN0dWZmIGp1c3QgaXNuJ3QgdXAgdG8gdGhlIGNoYWxsZW5nZXMgZWl0aGVy LiBXZSBuZWVkIHRvIGZpZ3VyZSBvdXQgc29tZXRoaW5nCj4gIHRoYXQgaW50ZWdyYXRlcyBiZXR0 ZXIgd2l0aCBEUk0gYW5kIGxpbnV4IGRlYnVnIHByaW50aW5nLCB3aGlsZSBub3QgYmVpbmcKPiAg dXNlbGVzcyB3aXRoIGZpbHRlcmluZyBvdXRwdXQuIGR5bmFtaWMgZGVidWcgcHJpbnRpbmcgbWln aHQgYmUgYW4gb3B0aW9uLgo+ICsKPiArMjAuIE1vdmUgTWF4IFRNRFMgY2xvY2sgcmVhZCB0byBE Uk0uIFNlZQo+ICtkYWxfZGRjX3NlcnZpY2VfaTJjX3F1ZXJ5X2RwX2R1YWxfbW9kZV9hZGFwdG9y LiBJIGhhdmVuJ3QgY2hlY2tlZCBpZiB0aGVyZSdzCj4gK2N1cnJlbnRseSBmdW5jdGlvbmFsaXR5 IGluIERSTS4gSWYgbm90IHdlIGNhbiBwcm9wb3NlIHNvbWV0aGluZy4KCldlIGFscmVhZHkgaGF2 ZSBkdWFsX21vZGUgaGVscGVycy4gSXQncyBvbmUgb2YgdGhlIHRvZG8ncyBJJ3ZlIGFkZGVkLApt ZXJnZWQgdGhpcyB3aXRoIHBvaW50IDE1PwoKPiArMjEuIFVzZSBrZXJuZWwgaTJjIGRldmljZSB0 byBwcm9ncmFtIEhETUkgcmV0aW1lci4gU29tZSBib2FyZHMgaGF2ZSBhbiBIRE1JCj4gK3JldGlt ZXIgdGhhdCB3ZSBuZWVkIHRvIHByb2dyYW0gdG8gcGFzcyBQSFkgY29tcGxpYW5jZS4gQ3VycmVu dGx5IHRoYXQncwo+ICtieXBhc3NpbmcgdGhlIGkyYyBkZXZpY2UgYW5kIGdvZXMgZGlyZWN0bHkg dG8gSFcuIFRoaXMgc2hvdWxkIGJlIGNoYW5nZWQuCgpJIHRob3VnaHQgaXQgZXZlbnR1YWxseSBn b2VzIHRocm91Z2ggdGhlIGkyYyBzdHVmZiwgYWZ0ZXIgYSBmZXcgbGF5ZXJzCmF0IGxlYXN0LiBN YXliZSBJIGdvdCBkZXJhaWxlZC4gQW55d2F5LCBtYWtlcyBzZW5zZS4KCldpdGggMjAgbWVyZ2Vk IGludG8gMTUsIGFjayBvbiB0aGUgcGF0Y2ggZnJvbSBtZS4KLURhbmllbAotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUg NTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngK