From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF54C433DB for ; Thu, 21 Jan 2021 08:41:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42E702399C for ; Thu, 21 Jan 2021 08:41:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727815AbhAUIlz (ORCPT ); Thu, 21 Jan 2021 03:41:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726793AbhAUIkL (ORCPT ); Thu, 21 Jan 2021 03:40:11 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF7B5C061757 for ; Thu, 21 Jan 2021 00:39:30 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id q205so1317109oig.13 for ; Thu, 21 Jan 2021 00:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kUfE6SE2n4SlWhNh9yX+hYT59DeJtvAevoxz9O0TUik=; b=TMAYX7QpeIeo0SfI4thWj5+xPv0DebVU+jxpSwtXWWoVQE84U3WmqKHg2Qft1tihQW DB2oOS44TFmyBNUiPyczVFFVRDnnzX7CXxrO4CSZqhf86MPvPEoVPiCfYRdJkxCu76vO imVq/j+2Imm/U2YKA+alPP8NkHUHRvLDmkeRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUfE6SE2n4SlWhNh9yX+hYT59DeJtvAevoxz9O0TUik=; b=gfVYeG9HxYyKY7jhAnu6ceBwPiqDPjp/vOQdBeQBz0O/u7R7BOHaMmC5wZBjuOMQ8f 4Yl2+EPoD3HVj4bXDil1cq3ujZ7hi7YfZFWlE4yHy6TJIXLgm+Eg/q55u/6W52r87cI8 qJ/Cl1IT5ha/2qYclqY/LuVhhmya6zJvABEfstAT9nW+PW+1aU86/HSAd/k4down9FX6 pUe1KqlBFF7dFEU/MLDaJrjXwyWSDQdgFFEmrLjb91VCnazHt/eveL3PZGMz05rkCQS7 cqlKFJvaE3zXK522idNZ5D/ISDsKcsMtmn/zHatASEoUIQRW/K7ZDYsEP6TUD8xE4hno eTCA== X-Gm-Message-State: AOAM531J8hLe01ZNjP3e9ZDXSJFzAuhlvcHhMYUYesd1jevCiGvT0zEM s9Sj5qYIbFIlapLq+/UN4H1NuuFZPHN7Py08KvBh/g== X-Google-Smtp-Source: ABdhPJwdBtD3B1cBobpcMyhJG7mZaplWKuBOFYhagzM+X5GOmA44nSE9377UdftyPqlQOfXqfDOSago3v5JpojgiclM= X-Received: by 2002:aca:ad92:: with SMTP id w140mr5422725oie.128.1611218370352; Thu, 21 Jan 2021 00:39:30 -0800 (PST) MIME-Version: 1.0 References: <20210121074959.313333-1-hch@lst.de> <20210121074959.313333-9-hch@lst.de> <20210121082820.GA25719@lst.de> In-Reply-To: <20210121082820.GA25719@lst.de> From: Daniel Vetter Date: Thu, 21 Jan 2021 09:39:19 +0100 Message-ID: Subject: Re: [PATCH 08/13] drm: remove drm_fb_helper_modinit To: Christoph Hellwig Cc: Frederic Barrat , Andrew Donnellan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Jessica Yu , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Masahiro Yamada , Michal Marek , Linux Kernel Mailing List , linuxppc-dev , dri-devel , live-patching@vger.kernel.org, linux-kbuild Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 9:28 AM Christoph Hellwig wrote: > > On Thu, Jan 21, 2021 at 09:25:40AM +0100, Daniel Vetter wrote: > > On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig wrote: > > > > > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > > > simple functionality. Just open code it in the only caller using > > > IS_ENABLED and IS_MODULE. > > > > > > Signed-off-by: Christoph Hellwig > > > > I didn't spot any dependencies with your series, should I just merge > > this through drm trees? Or do you want an ack? > > I'd prefer an ACK - module_loaded() is only introduced earlier in this > series. I was looking for that but didn't find the hunk touching drm somehow ... Acked-by: Daniel Vetter Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E6BC433E6 for ; Thu, 21 Jan 2021 08:41:29 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CECF2399A for ; Thu, 21 Jan 2021 08:41:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CECF2399A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DLwpt3ccgzDqYP for ; Thu, 21 Jan 2021 19:41:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=ffwll.ch (client-ip=2607:f8b0:4864:20::234; helo=mail-oi1-x234.google.com; envelope-from=daniel.vetter@ffwll.ch; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=ffwll.ch header.i=@ffwll.ch header.a=rsa-sha256 header.s=google header.b=TMAYX7Qp; dkim-atps=neutral Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DLwmm61qKzDqdX for ; Thu, 21 Jan 2021 19:39:34 +1100 (AEDT) Received: by mail-oi1-x234.google.com with SMTP id p5so1355537oif.7 for ; Thu, 21 Jan 2021 00:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kUfE6SE2n4SlWhNh9yX+hYT59DeJtvAevoxz9O0TUik=; b=TMAYX7QpeIeo0SfI4thWj5+xPv0DebVU+jxpSwtXWWoVQE84U3WmqKHg2Qft1tihQW DB2oOS44TFmyBNUiPyczVFFVRDnnzX7CXxrO4CSZqhf86MPvPEoVPiCfYRdJkxCu76vO imVq/j+2Imm/U2YKA+alPP8NkHUHRvLDmkeRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUfE6SE2n4SlWhNh9yX+hYT59DeJtvAevoxz9O0TUik=; b=eFtNI57OEWWD49UlMSCXe+jXORwsEhthYAwxiACwADoYsCoL8WQGeKmlXXX8Rv9Fmk QsH5hRw+BNoFPZrVLxvt/M8GST5nMHcOy9Xi1nsvJrPkwVpwZHQlmq0P19cFyxbBPcXs jK8jdhS3kYkqin78p8IaKHS0qojkBohGvdDp+N3OODOwCbFRurWQiXHGhxcmh5Fzwrki bBBXvHigxa53sCrErd2bDhTaZII3KaknwU6aSiS4SvbQ+NEmMQ9TXe1MbJvccp1IwN5P A/TYWqwQwPBXvJ9HoZjoh3vh1gsYUDB3gG/s14jjs0crjLvxWndFJMUwaizwTDqj2ezw 9jlw== X-Gm-Message-State: AOAM5306f+UISqSGLTDAR5OWXkM93uiXi11rb908OkCQOu6x9so1dwe1 39jxoVVS7sQuSGyMXNDz4/4Dyn1LBTa0xps8Etzv3A== X-Google-Smtp-Source: ABdhPJwdBtD3B1cBobpcMyhJG7mZaplWKuBOFYhagzM+X5GOmA44nSE9377UdftyPqlQOfXqfDOSago3v5JpojgiclM= X-Received: by 2002:aca:ad92:: with SMTP id w140mr5422725oie.128.1611218370352; Thu, 21 Jan 2021 00:39:30 -0800 (PST) MIME-Version: 1.0 References: <20210121074959.313333-1-hch@lst.de> <20210121074959.313333-9-hch@lst.de> <20210121082820.GA25719@lst.de> In-Reply-To: <20210121082820.GA25719@lst.de> From: Daniel Vetter Date: Thu, 21 Jan 2021 09:39:19 +0100 Message-ID: Subject: Re: [PATCH 08/13] drm: remove drm_fb_helper_modinit To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Jiri Kosina , Andrew Donnellan , linux-kbuild , David Airlie , Masahiro Yamada , Josh Poimboeuf , Maarten Lankhorst , Linux Kernel Mailing List , Maxime Ripard , Michal Marek , Joe Lawrence , dri-devel , Thomas Zimmermann , Jessica Yu , Frederic Barrat , live-patching@vger.kernel.org, Miroslav Benes , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Jan 21, 2021 at 9:28 AM Christoph Hellwig wrote: > > On Thu, Jan 21, 2021 at 09:25:40AM +0100, Daniel Vetter wrote: > > On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig wrote: > > > > > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > > > simple functionality. Just open code it in the only caller using > > > IS_ENABLED and IS_MODULE. > > > > > > Signed-off-by: Christoph Hellwig > > > > I didn't spot any dependencies with your series, should I just merge > > this through drm trees? Or do you want an ack? > > I'd prefer an ACK - module_loaded() is only introduced earlier in this > series. I was looking for that but didn't find the hunk touching drm somehow ... Acked-by: Daniel Vetter Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C316C433DB for ; Thu, 21 Jan 2021 08:39:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E6632399A for ; Thu, 21 Jan 2021 08:39:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E6632399A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F6A26E4EA; Thu, 21 Jan 2021 08:39:32 +0000 (UTC) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 628016E4EA for ; Thu, 21 Jan 2021 08:39:31 +0000 (UTC) Received: by mail-oi1-x22f.google.com with SMTP id 9so1379033oiq.3 for ; Thu, 21 Jan 2021 00:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kUfE6SE2n4SlWhNh9yX+hYT59DeJtvAevoxz9O0TUik=; b=TMAYX7QpeIeo0SfI4thWj5+xPv0DebVU+jxpSwtXWWoVQE84U3WmqKHg2Qft1tihQW DB2oOS44TFmyBNUiPyczVFFVRDnnzX7CXxrO4CSZqhf86MPvPEoVPiCfYRdJkxCu76vO imVq/j+2Imm/U2YKA+alPP8NkHUHRvLDmkeRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUfE6SE2n4SlWhNh9yX+hYT59DeJtvAevoxz9O0TUik=; b=QFAvFVrMLmZ59xWNLRJrGru9RoCk2Z9IFzBNaJ4HAlzLQmQWWSMrx3OxFlhIso36+P Mm7j1TP10Y6eLsNSxAS4XH+XHMv2AOEt7PVh7SC9iNkZx5W++6+2U8lhGz2rtxnFAt9W vgosBbw67QKyiUSXjUUkhyV2qQqYSCSxYyOM3vHvojiwd5wleGmV1hQrPhrXmko5l5G6 soD+A8e1GWMLCHJZC57y89OA5ksbtJPY5pdylSC+1dKyabc0xa7vihcn0e1Hf8nlU6uY vuKh3vtqBbqGniI7tC5FAeiJ5rVIrZd/R55Ko/Z4w6pD1iH1mrjrtElMsfALq1Mt1Bbc I1Cw== X-Gm-Message-State: AOAM531V+x2EhBbp7kIsHBAKL5USiYgYwx1/ACUHT0ZD64a1a37yRzTw M3neXtJX0BR42ZvJjl4cKJIaz21Kghq6DVuobOU7/w== X-Google-Smtp-Source: ABdhPJwdBtD3B1cBobpcMyhJG7mZaplWKuBOFYhagzM+X5GOmA44nSE9377UdftyPqlQOfXqfDOSago3v5JpojgiclM= X-Received: by 2002:aca:ad92:: with SMTP id w140mr5422725oie.128.1611218370352; Thu, 21 Jan 2021 00:39:30 -0800 (PST) MIME-Version: 1.0 References: <20210121074959.313333-1-hch@lst.de> <20210121074959.313333-9-hch@lst.de> <20210121082820.GA25719@lst.de> In-Reply-To: <20210121082820.GA25719@lst.de> From: Daniel Vetter Date: Thu, 21 Jan 2021 09:39:19 +0100 Message-ID: Subject: Re: [PATCH 08/13] drm: remove drm_fb_helper_modinit To: Christoph Hellwig X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Petr Mladek , Jiri Kosina , Andrew Donnellan , linux-kbuild , David Airlie , Masahiro Yamada , Josh Poimboeuf , Linux Kernel Mailing List , Michal Marek , Joe Lawrence , dri-devel , Thomas Zimmermann , Jessica Yu , Frederic Barrat , live-patching@vger.kernel.org, Miroslav Benes , linuxppc-dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 21, 2021 at 9:28 AM Christoph Hellwig wrote: > > On Thu, Jan 21, 2021 at 09:25:40AM +0100, Daniel Vetter wrote: > > On Thu, Jan 21, 2021 at 8:55 AM Christoph Hellwig wrote: > > > > > > drm_fb_helper_modinit has a lot of boilerplate for what is not very > > > simple functionality. Just open code it in the only caller using > > > IS_ENABLED and IS_MODULE. > > > > > > Signed-off-by: Christoph Hellwig > > > > I didn't spot any dependencies with your series, should I just merge > > this through drm trees? Or do you want an ack? > > I'd prefer an ACK - module_loaded() is only introduced earlier in this > series. I was looking for that but didn't find the hunk touching drm somehow ... Acked-by: Daniel Vetter Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel