From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/6] drm/i915: get mode clock when reading the pipe config v5 Date: Thu, 23 May 2013 20:53:20 +0200 Message-ID: References: <1368576511-10675-1-git-send-email-jbarnes@virtuousgeek.org> <1368576511-10675-3-git-send-email-jbarnes@virtuousgeek.org> <20130523153006.GC15743@phenom.ffwll.local> <20130523091036.27e75ade@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 925FFE64D5 for ; Thu, 23 May 2013 11:53:21 -0700 (PDT) Received: by mail-ie0-f170.google.com with SMTP id aq17so9784546iec.15 for ; Thu, 23 May 2013 11:53:21 -0700 (PDT) In-Reply-To: <20130523091036.27e75ade@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, May 23, 2013 at 6:10 PM, Jesse Barnes wrote: >> - For the clock readout code I think we should be able to have pipe config >> compare support (with adjusted_mode->clock), with a bit of fuzz at >> least. Not on current dinq, but with my cleanup to give >> adjusted_mode->clock saner semantics: >> >> http://permalink.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/21750 > > So far I haven't needed the fuzz, but I'm not opposed to adding it as > needed. I mean for the pipe_config comparison/checking in general, which seems to still be lacking. >> - There's no reason imo for the new ->get_clock vfunc, it splits exactly >> the same as the existing ->get_pipe_config. So could simply be included >> there. > > Except that it depends on the results of the encoder->get_config > callback... that's the only reason I split it. If you have ideas about > how to merge it back that's ok with me. Yeah, I always forget about that. I still think we should shovel everything into the platform get_config (including the encoder loop) like we do for the crtc enable/disable functions. But the current approach still works, so meh ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch