From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave
Date: Wed, 12 Jun 2019 14:31:29 +0200 [thread overview]
Message-ID: <CAKMK7uHQXGZqggkaCK5gNMpzobuNrh3AA-xu-mYepkcxNHgj3Q@mail.gmail.com> (raw)
In-Reply-To: <f9e5925d-37d1-df04-db19-a963beeccde5@ti.com>
On Wed, Jun 12, 2019 at 11:19 AM Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>
> On 12/06/2019 12:12, Daniel Vetter wrote:
> > This is a no-op on atomic drivers because with atomic it's simply too
> > complicated to get all the locking and workers and nonblocking
> > synchronization correct, from essentially an NMI context. Well, too
> > complicated = impossible. Also, omapdrm never implemented the
> > mode_set_base_atomic hook, so I kinda wonder why this was ever added.
> >
> > Drop the hooks.
>
> f9b34a0fa4e25d9c0b72f124680c37c0c38f9934
>
> It was just open coding DRM_FB_HELPER_DEFAULT_OPS, to get rid of
> "Initializer entry defined twice" warning.
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Or I can pick it up to my branch if this is not part of a bigger series.
Not part of a bigger series, there's still a bunch of real users of
this in-tree. Although given how absolutely no one seems to care to
make kgdb work on top of atomic drivers I'm hoping I can sunset all
this code soon.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-06-12 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:12 [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave Daniel Vetter
2019-06-12 9:12 ` [PATCH 2/2] drm/ast: Drop fb_debug_enter/leave Daniel Vetter
2019-06-13 6:45 ` Thomas Zimmermann
2019-06-13 8:19 ` Daniel Vetter
2019-06-12 9:19 ` [PATCH 1/2] drm/omapdrm: drop fb_debug_enter/leave Tomi Valkeinen
2019-06-12 12:31 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uHQXGZqggkaCK5gNMpzobuNrh3AA-xu-mYepkcxNHgj3Q@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.