From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/6] drm/i915: Squash gen lookup through multiple indirections inside GT access Date: Tue, 16 Jul 2013 22:07:46 +0200 Message-ID: References: <1374001336-10339-1-git-send-email-chris@chris-wilson.co.uk> <1374001336-10339-5-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com [209.85.223.181]) by gabe.freedesktop.org (Postfix) with ESMTP id E465BE6D6A for ; Tue, 16 Jul 2013 13:07:46 -0700 (PDT) Received: by mail-ie0-f181.google.com with SMTP id x12so2520082ief.12 for ; Tue, 16 Jul 2013 13:07:46 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Tue, Jul 16, 2013 at 9:30 PM, Paulo Zanoni wrote: > 2013/7/16 Chris Wilson : >> The INTEL_INFO() macro extracts the dev_private pointer from the device, >> so passing in the dev_private->dev is a long winded circumlocution. >> >> v2: rebase onto uncore >> >> Signed-off-by: Chris Wilson > > Reviewed-by: Paulo Zanoni > > I also wouldn't complain if you submitted a patch changing INTEL_INFO > and friends to take dev_priv as argument. Like I've said on irc imo the real fix is to get drm core off the midlayer drugs and allow embedding of struct drm_device into device driver private structures. At that point it'll boil down to cosmetics since gcc should do a fine job at optimizing away the constant offset. And cosmetics tend to just disrupt ongoing work by causing rebase hell. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch