From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247DAC433E0 for ; Fri, 5 Feb 2021 21:50:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEB0764E37 for ; Fri, 5 Feb 2021 21:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232963AbhBEVtr (ORCPT ); Fri, 5 Feb 2021 16:49:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231283AbhBEVtI (ORCPT ); Fri, 5 Feb 2021 16:49:08 -0500 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17409C061756 for ; Fri, 5 Feb 2021 13:48:28 -0800 (PST) Received: by mail-ot1-x32e.google.com with SMTP id k25so6224365otb.4 for ; Fri, 05 Feb 2021 13:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Myi+FPtqdhmCRGtvUQRPlV0jT+RrPtESC3AjeVRvbg=; b=eC9kB4a0zNfmjxF2GTa7/iPip18RksRG3N5wWZ5SO1JQZe9K/wF4qqPray7ex919OI t+tp9kXmieLVbXRxK2+JkQQDfBQ7qrCcDPjv892pP0Pm9Opne2wsFWOgNQ9fiIbaKohg 74D35sOMSr9T35Hijh1VZY9iv0qSmYcBVjy6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Myi+FPtqdhmCRGtvUQRPlV0jT+RrPtESC3AjeVRvbg=; b=JXbWDxG3johkzIVF1tP4Tty2NzzlyInUu8rFiPObT420NybzBKLH3ceuzKuqkCqDU4 G686n5EupR0yAnPxn0yASaua/u/3I/h80Do8ScGAfnmAg4Z6+mJ+mRaSXFUM+FlEZwX1 FZtRWQrlNfKskLmKhRbSlQ0OFhMR35WNE0IAQNK2fnJx0Qj+Y+RSuFhZY5cJYCaHIRk2 X0XTL47oQg2rRzQBofrGQp6Btv9/2TfcADGM4Evr0f8kXYDnfakdxtfGWY9MdE0ErN5Q J+zj15SbtYjntZDS2KaPHbcC2qFGWkwKWedwLcH3E5kJA2BXEjuxyRLJS9jMFynyBeNB LeeQ== X-Gm-Message-State: AOAM533n3AUjVDiFb3vcqSIlM9PlhpKrbZK63P8bDUF6JQ3lo9fEdr2O GJJDTmkW4HAhXLyOH2+EufWOJqYx1IVaujFg00DF5GMNq+Tx+g== X-Google-Smtp-Source: ABdhPJzO4wsgNsPeCXBIM+TjlTPuvZslxQG5o19ZlJ38I+bykaN07telVVm1okiylG5taJfGzcXqFg1phGT31X4akVA= X-Received: by 2002:a9d:b85:: with SMTP id 5mr4982641oth.281.1612561707504; Fri, 05 Feb 2021 13:48:27 -0800 (PST) MIME-Version: 1.0 References: <20210205163752.11932-1-chris@chris-wilson.co.uk> <20210205210610.29837-1-chris@chris-wilson.co.uk> <161255976138.12021.9385501710085642237@build.alporthouse.com> <202102051319.E5D8B4528D@keescook> <161256053234.12021.17815864250035077266@build.alporthouse.com> In-Reply-To: <161256053234.12021.17815864250035077266@build.alporthouse.com> From: Daniel Vetter Date: Fri, 5 Feb 2021 22:48:16 +0100 Message-ID: Subject: Re: [PATCH v2] kernel: Expose SYS_kcmp by default To: Chris Wilson Cc: Kees Cook , Linux Kernel Mailing List , dri-devel , intel-gfx , Andy Lutomirski , Will Drewry , Andrew Morton , Dave Airlie , Lucas Stach Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 10:28 PM Chris Wilson wrote: > > Quoting Kees Cook (2021-02-05 21:20:33) > > On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote: > > > The subject should of course be changed, as it is no longer being > > > enabled by default. > > > > "default n" is redundant. > > I thought being explicit would be preferred. There are a few other > default n, so at least it's not the odd-one-out! > > > I thought Daniel said CONFIG_DRM needed to > > "select" it too, though? > > Yes. We will need to select it for any DRM driver so that the Vulkan/GL > stacks can rely on having SYS_kcmp. That deserves to be handled and > explain within drm/Kconfig, and as they are already shipping with calls > to SYS_kcmp we may have to ask for a stable backport. Oh I dreamed and thought it's part of this patch already. So v3 with matching subject to enabled it for drm? -Daniel > > > Otherwise, yeah, this looks good. Was the > > export due to the 0-day bot failure reports? > > Yes. > -Chris -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E002C433DB for ; Fri, 5 Feb 2021 21:48:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8781464E33 for ; Fri, 5 Feb 2021 21:48:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8781464E33 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 011E56F4F5; Fri, 5 Feb 2021 21:48:29 +0000 (UTC) Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 358376F4F6 for ; Fri, 5 Feb 2021 21:48:28 +0000 (UTC) Received: by mail-ot1-x32a.google.com with SMTP id d1so8290044otl.13 for ; Fri, 05 Feb 2021 13:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Myi+FPtqdhmCRGtvUQRPlV0jT+RrPtESC3AjeVRvbg=; b=eC9kB4a0zNfmjxF2GTa7/iPip18RksRG3N5wWZ5SO1JQZe9K/wF4qqPray7ex919OI t+tp9kXmieLVbXRxK2+JkQQDfBQ7qrCcDPjv892pP0Pm9Opne2wsFWOgNQ9fiIbaKohg 74D35sOMSr9T35Hijh1VZY9iv0qSmYcBVjy6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Myi+FPtqdhmCRGtvUQRPlV0jT+RrPtESC3AjeVRvbg=; b=fIIzHyRpuRDLnYnxOat5doue+K9MmfInFBnwVFrM+/MrGk/2PQ/GtqK0bzRVeRXOR5 n6Z2icq6TC2ePgR61c9AjWJxUNPGhIvhuQVnAPzIW0gY3qCa298CHIxol3ms9zClG5KD /ctsPS7PGsENJSoWW1/cQoOJXr/ehbK24hlavhnlWpVVaip6ZLMH8MImi68d07aAFpF8 rwJLB4A14X+4qzUZLiy4BML/Vw9r8yRwroK+f22Qtov6IRmi9GCKHrVieWAKeKkLkJ8m cNQ8gfcR1mcsO4Q1b98b52FnWhuAqv8+HawXygJMupbTFI1yOZ9DvNnSiOKvEwKvY3vU ZAKw== X-Gm-Message-State: AOAM533WKDlwWfF7HSJJZ5ghRgbIslcPumUnsrSsrfnLi5N/LScbMBoU FjyZJsgYbZGh/HSIMyBviFktBYIMhDgfGuvVfwbAMQ== X-Google-Smtp-Source: ABdhPJzO4wsgNsPeCXBIM+TjlTPuvZslxQG5o19ZlJ38I+bykaN07telVVm1okiylG5taJfGzcXqFg1phGT31X4akVA= X-Received: by 2002:a9d:b85:: with SMTP id 5mr4982641oth.281.1612561707504; Fri, 05 Feb 2021 13:48:27 -0800 (PST) MIME-Version: 1.0 References: <20210205163752.11932-1-chris@chris-wilson.co.uk> <20210205210610.29837-1-chris@chris-wilson.co.uk> <161255976138.12021.9385501710085642237@build.alporthouse.com> <202102051319.E5D8B4528D@keescook> <161256053234.12021.17815864250035077266@build.alporthouse.com> In-Reply-To: <161256053234.12021.17815864250035077266@build.alporthouse.com> From: Daniel Vetter Date: Fri, 5 Feb 2021 22:48:16 +0100 Message-ID: Subject: Re: [PATCH v2] kernel: Expose SYS_kcmp by default To: Chris Wilson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Drewry , Kees Cook , intel-gfx , Linux Kernel Mailing List , dri-devel , Andy Lutomirski , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 5, 2021 at 10:28 PM Chris Wilson wrote: > > Quoting Kees Cook (2021-02-05 21:20:33) > > On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote: > > > The subject should of course be changed, as it is no longer being > > > enabled by default. > > > > "default n" is redundant. > > I thought being explicit would be preferred. There are a few other > default n, so at least it's not the odd-one-out! > > > I thought Daniel said CONFIG_DRM needed to > > "select" it too, though? > > Yes. We will need to select it for any DRM driver so that the Vulkan/GL > stacks can rely on having SYS_kcmp. That deserves to be handled and > explain within drm/Kconfig, and as they are already shipping with calls > to SYS_kcmp we may have to ask for a stable backport. Oh I dreamed and thought it's part of this patch already. So v3 with matching subject to enabled it for drm? -Daniel > > > Otherwise, yeah, this looks good. Was the > > export due to the 0-day bot failure reports? > > Yes. > -Chris -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3F7C433E0 for ; Fri, 5 Feb 2021 21:48:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 535FB64FB2 for ; Fri, 5 Feb 2021 21:48:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 535FB64FB2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7675B6F4F7; Fri, 5 Feb 2021 21:48:29 +0000 (UTC) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 352DB6F4F5 for ; Fri, 5 Feb 2021 21:48:28 +0000 (UTC) Received: by mail-ot1-x329.google.com with SMTP id v1so8300957ott.10 for ; Fri, 05 Feb 2021 13:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Myi+FPtqdhmCRGtvUQRPlV0jT+RrPtESC3AjeVRvbg=; b=eC9kB4a0zNfmjxF2GTa7/iPip18RksRG3N5wWZ5SO1JQZe9K/wF4qqPray7ex919OI t+tp9kXmieLVbXRxK2+JkQQDfBQ7qrCcDPjv892pP0Pm9Opne2wsFWOgNQ9fiIbaKohg 74D35sOMSr9T35Hijh1VZY9iv0qSmYcBVjy6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Myi+FPtqdhmCRGtvUQRPlV0jT+RrPtESC3AjeVRvbg=; b=scFBBHxGs7+9PJxUOXK5eucQrftm6nT4MOkwwhBDVOAP9n7tpObUasxw5OtlY+PWgz jiaD2SQMiEQQ5NnThKoKl/tDZs3zkAJQwwiPUq0LKLoDh08ptjtk6MgGgnx1f6gWvazk 0MNEAK7m/CqbdRAlhji7ysRpgm4oP7eJ4ofhDYHUeHXRBaPF3EyUTxQpseS900qT15M/ cAIXN6daXmdJlYEGF079SB847PWRH+6H2EWgWLFaqRko4aFy5bDiDz+8ifewFF+BJJA1 Yy58uah9Ac3P/ThV6e6fqO1oOpb5kirhnYXzb1dZkYJEfl39l0KaX680dHkMPSN+UNQF G++Q== X-Gm-Message-State: AOAM5321dh0x1fH/0grhEBcRcmIKbxrII8w5cz7RRiPhswoByPCe72hZ fUUNPYK5RCgKmqfwLpxn86LRvIyqcJD5iN10fRfZ+g== X-Google-Smtp-Source: ABdhPJzO4wsgNsPeCXBIM+TjlTPuvZslxQG5o19ZlJ38I+bykaN07telVVm1okiylG5taJfGzcXqFg1phGT31X4akVA= X-Received: by 2002:a9d:b85:: with SMTP id 5mr4982641oth.281.1612561707504; Fri, 05 Feb 2021 13:48:27 -0800 (PST) MIME-Version: 1.0 References: <20210205163752.11932-1-chris@chris-wilson.co.uk> <20210205210610.29837-1-chris@chris-wilson.co.uk> <161255976138.12021.9385501710085642237@build.alporthouse.com> <202102051319.E5D8B4528D@keescook> <161256053234.12021.17815864250035077266@build.alporthouse.com> In-Reply-To: <161256053234.12021.17815864250035077266@build.alporthouse.com> From: Daniel Vetter Date: Fri, 5 Feb 2021 22:48:16 +0100 Message-ID: To: Chris Wilson Subject: Re: [Intel-gfx] [PATCH v2] kernel: Expose SYS_kcmp by default X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Drewry , Kees Cook , intel-gfx , Linux Kernel Mailing List , dri-devel , Andy Lutomirski , Andrew Morton , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Feb 5, 2021 at 10:28 PM Chris Wilson wrote: > > Quoting Kees Cook (2021-02-05 21:20:33) > > On Fri, Feb 05, 2021 at 09:16:01PM +0000, Chris Wilson wrote: > > > The subject should of course be changed, as it is no longer being > > > enabled by default. > > > > "default n" is redundant. > > I thought being explicit would be preferred. There are a few other > default n, so at least it's not the odd-one-out! > > > I thought Daniel said CONFIG_DRM needed to > > "select" it too, though? > > Yes. We will need to select it for any DRM driver so that the Vulkan/GL > stacks can rely on having SYS_kcmp. That deserves to be handled and > explain within drm/Kconfig, and as they are already shipping with calls > to SYS_kcmp we may have to ask for a stable backport. Oh I dreamed and thought it's part of this patch already. So v3 with matching subject to enabled it for drm? -Daniel > > > Otherwise, yeah, this looks good. Was the > > export due to the 0-day bot failure reports? > > Yes. > -Chris -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx