Re: [PATCH] drm/vmwgfx: Fix fbdev emulation using legacy functions

[Daniel Vetter <daniel.vetter@ffwll.ch>]

On Thu, Apr 6, 2017 at 10:02 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Fixing this properly would mean we get to wire the acquire_ctx all the
> way through vmwgfx fbdev code, and doing the same was tricky for the
> shared fbdev layer. Probably much better to look into refactoring the
> entire code to use the helpers, but since that's not a viable
> long-term solution fix the issue by open-coding a vmwgfx version of
> set_config, that does the legacy backoff dance internally.

I'm digging around in the fbev locking again, and stumbled over this.
Any plans for vmwgfx to switch over to the core fbdev emulation
helpers? If not I'll have to put another layer of hacks around this,
and it's kinda getting unsightly :(

My goal is to remove any usage of the implicit
mode_config.acquire_context since that just breaks the wait/wound
mutex locking scheme and doesn't really work together with atomic
drivers. Once fbdev helpers and the property setting are fixed this
here is the last place (minus something in i915 that I'll take care of
of course). I'm getting close to that point.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel