From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC21C433E8 for ; Wed, 15 Jul 2020 13:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98A4020657 for ; Wed, 15 Jul 2020 13:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="IKgfCkko" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731942AbgGONwA (ORCPT ); Wed, 15 Jul 2020 09:52:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729086AbgGONwA (ORCPT ); Wed, 15 Jul 2020 09:52:00 -0400 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2139EC061755 for ; Wed, 15 Jul 2020 06:52:00 -0700 (PDT) Received: by mail-oo1-xc43.google.com with SMTP id p26so472254oos.7 for ; Wed, 15 Jul 2020 06:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MqsOl2rYB/7u7Gut1iGuVJHU6JubtHB+/cs3tCH619k=; b=IKgfCkkoCpyGSci4cTPs6WgN6drUjM+E3fQd+RPREwzfcvyoI/L2/DSylDaZWzbbuB ZgDTW9XW77MQfdfYrmTKY8Ba+zSSqU0LXVTiQfGjJQ1YBrXbynYX7OwZI6lTTmBPBmKW 2LvOJErq6bacSh3G/oxiPt9fWxpefW9zWQzeg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MqsOl2rYB/7u7Gut1iGuVJHU6JubtHB+/cs3tCH619k=; b=lUXlxif07/kQN3HUeIgqj1765uoLALV8ALu6ejPNqLZH8AU9rD9X79XglM645P1omY ffvNkrfWJn8SRfh17tAFJf4ds5Lgg3Jx1fFc3kOGEN7f+0Qau1+i221lc0cPpy0pCpcI ObmIc8Pd+2a4sQLedZEYAJowKa81JNJa5i2W4zdid+JpghHExYO22a5COk16pXUs+diG eU8oq+oxOcrNVRO9cmYAAvVND4JaSAlmW3GiTFcFW4nx8dGpQM3IHf3F+Z/C5AzDstMp 3jyvBQoeitTCC+N/O9CmH76yIi+mYP759veT2wWPX70IBZP4I2OhWCw5jFXJd0pJlj5y MOBQ== X-Gm-Message-State: AOAM530jlQK/JY4vsR2/dIKEPPSqiGzw5XLKeXiJBkckS4KIDPIPsLiZ ufW00ubXi30k192neam5FX3sdPGRoVl1g5FDjsaokg== X-Google-Smtp-Source: ABdhPJwb4NJPJ8t5WoT1YhrXoIhXNQ8S5ZrdL1024UrQe8WZqMBqKIOTr7Bpj9gabyh7CPZGKTyh2I4hoATPLTHtUTk= X-Received: by 2002:a4a:bb8a:: with SMTP id h10mr9338522oop.28.1594821119474; Wed, 15 Jul 2020 06:51:59 -0700 (PDT) MIME-Version: 1.0 References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-9-daniel.vetter@ffwll.ch> <20200715125347.GT159988@e110455-lin.cambridge.arm.com> In-Reply-To: <20200715125347.GT159988@e110455-lin.cambridge.arm.com> From: Daniel Vetter Date: Wed, 15 Jul 2020 15:51:48 +0200 Message-ID: Subject: Re: [PATCH 08/25] drm/malidp: Annotate dma-fence critical section in commit path To: Liviu Dudau Cc: DRI Development , Intel Graphics Development , linux-rdma , Daniel Vetter , "James (Qian) Wang" , Mihail Atanassov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jul 15, 2020 at 2:53 PM Liviu Dudau wrote: > > On Tue, Jul 07, 2020 at 10:12:12PM +0200, Daniel Vetter wrote: > > Again needs to be put right after the call to > > drm_atomic_helper_commit_hw_done(), since that's the last thing which > > can hold up a subsequent atomic commit. > > > > No surprises here. > > I was (still am) hoping to do a testing for this patch but when I dug out= the series > from the ML it looked like it has extra dependencies, so I was waiting fo= r the dust > to settle. > > Otherwise, LGTM. I should all just apply I think, it's based on drm-tip. Branch with bunch of other random stuff is here: https://cgit.freedesktop.org/~danvet/drm/log/ If that doesn't cherry-pick cleanly I'm confused about something. -Daniel > > Best regards, > Liviu > > > > > Signed-off-by: Daniel Vetter > > Cc: "James (Qian) Wang" > > Cc: Liviu Dudau > > Cc: Mihail Atanassov > > --- > > drivers/gpu/drm/arm/malidp_drv.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/mal= idp_drv.c > > index 69fee05c256c..26e60401a8e1 100644 > > --- a/drivers/gpu/drm/arm/malidp_drv.c > > +++ b/drivers/gpu/drm/arm/malidp_drv.c > > @@ -234,6 +234,7 @@ static void malidp_atomic_commit_tail(struct drm_at= omic_state *state) > > struct drm_crtc *crtc; > > struct drm_crtc_state *old_crtc_state; > > int i; > > + bool fence_cookie =3D dma_fence_begin_signalling(); > > > > pm_runtime_get_sync(drm->dev); > > > > @@ -260,6 +261,8 @@ static void malidp_atomic_commit_tail(struct drm_at= omic_state *state) > > > > malidp_atomic_commit_hw_done(state); > > > > + dma_fence_end_signalling(fence_cookie); > > + > > pm_runtime_put(drm->dev); > > > > drm_atomic_helper_cleanup_planes(drm, state); > > -- > > 2.27.0 > > > > -- > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > =C2=AF\_(=E3=83=84)_/=C2=AF --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5100C433EC for ; Wed, 15 Jul 2020 13:52:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95A5C20657 for ; Wed, 15 Jul 2020 13:52:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="IKgfCkko" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95A5C20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BF616EB68; Wed, 15 Jul 2020 13:52:01 +0000 (UTC) Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3573A6EB68 for ; Wed, 15 Jul 2020 13:52:00 +0000 (UTC) Received: by mail-oo1-xc42.google.com with SMTP id y9so470545oot.9 for ; Wed, 15 Jul 2020 06:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MqsOl2rYB/7u7Gut1iGuVJHU6JubtHB+/cs3tCH619k=; b=IKgfCkkoCpyGSci4cTPs6WgN6drUjM+E3fQd+RPREwzfcvyoI/L2/DSylDaZWzbbuB ZgDTW9XW77MQfdfYrmTKY8Ba+zSSqU0LXVTiQfGjJQ1YBrXbynYX7OwZI6lTTmBPBmKW 2LvOJErq6bacSh3G/oxiPt9fWxpefW9zWQzeg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MqsOl2rYB/7u7Gut1iGuVJHU6JubtHB+/cs3tCH619k=; b=QsPsvXAvHdnzXQbgU41EqC7N+P0cRE+sfmiCmLHg4GH8GP/6mVmrDbO4WFFvMEJ64L HQmsQusOvjp/d6apaQjilha/RvGeEIOEQMsL2skKy6vhXd80FZ/WjliauFIDroMPMXcw eO9dOs+P8ZrhYPqaXs5jw2GN9E6Eav6EZyYgFRboo09DHhuBgyk/tuG0q3p6jCrBDGBS VBpIEh0V2Dn5Gm9Cuoa0YMqPjm48NLQkh6dg3i0Q+dD/Y7QCRyVKnF/coAd1Ug5kRMXj YKSI7SRjCeHswbUSKvwXrev1ov4MLpO0uxRwmT2H6qQik0qWuOXCW8JUIe91wdETkLEg Scsg== X-Gm-Message-State: AOAM531/LckxOLx7PGtjCjBdMh8d2SMvGnHwafIQGCkJYcMmJ5EoaMFX ZVFt0qPRZZZUV19WUeFOPtHO0noRbhJOc3S4Gu+eK5FSV2s= X-Google-Smtp-Source: ABdhPJwb4NJPJ8t5WoT1YhrXoIhXNQ8S5ZrdL1024UrQe8WZqMBqKIOTr7Bpj9gabyh7CPZGKTyh2I4hoATPLTHtUTk= X-Received: by 2002:a4a:bb8a:: with SMTP id h10mr9338522oop.28.1594821119474; Wed, 15 Jul 2020 06:51:59 -0700 (PDT) MIME-Version: 1.0 References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-9-daniel.vetter@ffwll.ch> <20200715125347.GT159988@e110455-lin.cambridge.arm.com> In-Reply-To: <20200715125347.GT159988@e110455-lin.cambridge.arm.com> From: Daniel Vetter Date: Wed, 15 Jul 2020 15:51:48 +0200 Message-ID: Subject: Re: [PATCH 08/25] drm/malidp: Annotate dma-fence critical section in commit path To: Liviu Dudau X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rdma , Intel Graphics Development , DRI Development , "James \(Qian\) Wang" , Daniel Vetter , Mihail Atanassov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBKdWwgMTUsIDIwMjAgYXQgMjo1MyBQTSBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVA YXJtLmNvbT4gd3JvdGU6Cj4KPiBPbiBUdWUsIEp1bCAwNywgMjAyMCBhdCAxMDoxMjoxMlBNICsw MjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gQWdhaW4gbmVlZHMgdG8gYmUgcHV0IHJpZ2h0 IGFmdGVyIHRoZSBjYWxsIHRvCj4gPiBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgp LCBzaW5jZSB0aGF0J3MgdGhlIGxhc3QgdGhpbmcgd2hpY2gKPiA+IGNhbiBob2xkIHVwIGEgc3Vi c2VxdWVudCBhdG9taWMgY29tbWl0Lgo+ID4KPiA+IE5vIHN1cnByaXNlcyBoZXJlLgo+Cj4gSSB3 YXMgKHN0aWxsIGFtKSBob3BpbmcgdG8gZG8gYSB0ZXN0aW5nIGZvciB0aGlzIHBhdGNoIGJ1dCB3 aGVuIEkgZHVnIG91dCB0aGUgc2VyaWVzCj4gZnJvbSB0aGUgTUwgaXQgbG9va2VkIGxpa2UgaXQg aGFzIGV4dHJhIGRlcGVuZGVuY2llcywgc28gSSB3YXMgd2FpdGluZyBmb3IgdGhlIGR1c3QKPiB0 byBzZXR0bGUuCj4KPiBPdGhlcndpc2UsIExHVE0uCgpJIHNob3VsZCBhbGwganVzdCBhcHBseSBJ IHRoaW5rLCBpdCdzIGJhc2VkIG9uIGRybS10aXAuIEJyYW5jaCB3aXRoCmJ1bmNoIG9mIG90aGVy IHJhbmRvbSBzdHVmZiBpcyBoZXJlOgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+ZGFu dmV0L2RybS9sb2cvCgpJZiB0aGF0IGRvZXNuJ3QgY2hlcnJ5LXBpY2sgY2xlYW5seSBJJ20gY29u ZnVzZWQgYWJvdXQgc29tZXRoaW5nLgotRGFuaWVsCgo+Cj4gQmVzdCByZWdhcmRzLAo+IExpdml1 Cj4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGlu dGVsLmNvbT4KPiA+IENjOiAiSmFtZXMgKFFpYW4pIFdhbmciIDxqYW1lcy5xaWFuLndhbmdAYXJt LmNvbT4KPiA+IENjOiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJtLmNvbT4KPiA+IENjOiBN aWhhaWwgQXRhbmFzc292IDxtaWhhaWwuYXRhbmFzc292QGFybS5jb20+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYyB8IDMgKysrCj4gPiAgMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YXJtL21hbGlkcF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jCj4gPiBp bmRleCA2OWZlZTA1YzI1NmMuLjI2ZTYwNDAxYThlMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21h bGlkcF9kcnYuYwo+ID4gQEAgLTIzNCw2ICsyMzQsNyBAQCBzdGF0aWMgdm9pZCBtYWxpZHBfYXRv bWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAgICAg IHN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ICAgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq b2xkX2NydGNfc3RhdGU7Cj4gPiAgICAgICBpbnQgaTsKPiA+ICsgICAgIGJvb2wgZmVuY2VfY29v a2llID0gZG1hX2ZlbmNlX2JlZ2luX3NpZ25hbGxpbmcoKTsKPiA+Cj4gPiAgICAgICBwbV9ydW50 aW1lX2dldF9zeW5jKGRybS0+ZGV2KTsKPiA+Cj4gPiBAQCAtMjYwLDYgKzI2MSw4IEBAIHN0YXRp YyB2b2lkIG1hbGlkcF9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ID4KPiA+ICAgICAgIG1hbGlkcF9hdG9taWNfY29tbWl0X2h3X2RvbmUoc3RhdGUp Owo+ID4KPiA+ICsgICAgIGRtYV9mZW5jZV9lbmRfc2lnbmFsbGluZyhmZW5jZV9jb29raWUpOwo+ ID4gKwo+ID4gICAgICAgcG1fcnVudGltZV9wdXQoZHJtLT5kZXYpOwo+ID4KPiA+ICAgICAgIGRy bV9hdG9taWNfaGVscGVyX2NsZWFudXBfcGxhbmVzKGRybSwgc3RhdGUpOwo+ID4gLS0KPiA+IDIu MjcuMAo+ID4KPgo+IC0tCj4gPT09PT09PT09PT09PT09PT09PT0KPiB8IEkgd291bGQgbGlrZSB0 byB8Cj4gfCBmaXggdGhlIHdvcmxkLCAgfAo+IHwgYnV0IHRoZXkncmUgbm90IHwKPiB8IGdpdmlu ZyBtZSB0aGUgICB8Cj4gIFwgc291cmNlIGNvZGUhICAvCj4gICAtLS0tLS0tLS0tLS0tLS0KPiAg ICAgwq9cXyjjg4QpXy/CrwoKCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2010C433EB for ; Wed, 15 Jul 2020 13:52:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1A8E20658 for ; Wed, 15 Jul 2020 13:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="IKgfCkko" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1A8E20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23F116EB62; Wed, 15 Jul 2020 13:52:01 +0000 (UTC) Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 352796EB62 for ; Wed, 15 Jul 2020 13:52:00 +0000 (UTC) Received: by mail-oo1-xc42.google.com with SMTP id c4so473202oou.6 for ; Wed, 15 Jul 2020 06:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MqsOl2rYB/7u7Gut1iGuVJHU6JubtHB+/cs3tCH619k=; b=IKgfCkkoCpyGSci4cTPs6WgN6drUjM+E3fQd+RPREwzfcvyoI/L2/DSylDaZWzbbuB ZgDTW9XW77MQfdfYrmTKY8Ba+zSSqU0LXVTiQfGjJQ1YBrXbynYX7OwZI6lTTmBPBmKW 2LvOJErq6bacSh3G/oxiPt9fWxpefW9zWQzeg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MqsOl2rYB/7u7Gut1iGuVJHU6JubtHB+/cs3tCH619k=; b=boCAXBDwfE28CINauqGwxXYFk+mImA0ghQh8Z9z3lxQAGlyHN3VWeWpRYctGC1/Dcc yCwrpL2ZnamfWinoe10EV2v7jjiSHmjuQGgyPE1kEJH/cX9Pj3DRAVS6rcj/t0mwZcDO I/RdoI9vaXQQjPngXhRQh7PDzIq9iLrF76dHPV7RHYjwjMbCsOCEDfqYgyRAWkz5Bl3+ 7CuFQZ6sw/tNEqVu/E3MroAnLM1XqhZdmXtEOsH0x+Zmdo5hDuRkTyRRgyKg7LIoxCM/ LjOOBO3Hz1k5UEgnstBQtIZZ0elS3yy2mwrhYfhQmuYEPWcENwWMnF+IVhO3CsjnqM9y fd4g== X-Gm-Message-State: AOAM5307o/+DL/cwzhQHzoTb7R14e6blodFah/zBpjJWZWGTaXQLZXfy S/hWv8Mh8+w7tP744FCete+WivpzlhGyu6o6VWZ2EQ== X-Google-Smtp-Source: ABdhPJwb4NJPJ8t5WoT1YhrXoIhXNQ8S5ZrdL1024UrQe8WZqMBqKIOTr7Bpj9gabyh7CPZGKTyh2I4hoATPLTHtUTk= X-Received: by 2002:a4a:bb8a:: with SMTP id h10mr9338522oop.28.1594821119474; Wed, 15 Jul 2020 06:51:59 -0700 (PDT) MIME-Version: 1.0 References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> <20200707201229.472834-9-daniel.vetter@ffwll.ch> <20200715125347.GT159988@e110455-lin.cambridge.arm.com> In-Reply-To: <20200715125347.GT159988@e110455-lin.cambridge.arm.com> From: Daniel Vetter Date: Wed, 15 Jul 2020 15:51:48 +0200 Message-ID: To: Liviu Dudau Subject: Re: [Intel-gfx] [PATCH 08/25] drm/malidp: Annotate dma-fence critical section in commit path X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rdma , Intel Graphics Development , DRI Development , "James \(Qian\) Wang" , Daniel Vetter , Mihail Atanassov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCBKdWwgMTUsIDIwMjAgYXQgMjo1MyBQTSBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVA YXJtLmNvbT4gd3JvdGU6Cj4KPiBPbiBUdWUsIEp1bCAwNywgMjAyMCBhdCAxMDoxMjoxMlBNICsw MjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gQWdhaW4gbmVlZHMgdG8gYmUgcHV0IHJpZ2h0 IGFmdGVyIHRoZSBjYWxsIHRvCj4gPiBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgp LCBzaW5jZSB0aGF0J3MgdGhlIGxhc3QgdGhpbmcgd2hpY2gKPiA+IGNhbiBob2xkIHVwIGEgc3Vi c2VxdWVudCBhdG9taWMgY29tbWl0Lgo+ID4KPiA+IE5vIHN1cnByaXNlcyBoZXJlLgo+Cj4gSSB3 YXMgKHN0aWxsIGFtKSBob3BpbmcgdG8gZG8gYSB0ZXN0aW5nIGZvciB0aGlzIHBhdGNoIGJ1dCB3 aGVuIEkgZHVnIG91dCB0aGUgc2VyaWVzCj4gZnJvbSB0aGUgTUwgaXQgbG9va2VkIGxpa2UgaXQg aGFzIGV4dHJhIGRlcGVuZGVuY2llcywgc28gSSB3YXMgd2FpdGluZyBmb3IgdGhlIGR1c3QKPiB0 byBzZXR0bGUuCj4KPiBPdGhlcndpc2UsIExHVE0uCgpJIHNob3VsZCBhbGwganVzdCBhcHBseSBJ IHRoaW5rLCBpdCdzIGJhc2VkIG9uIGRybS10aXAuIEJyYW5jaCB3aXRoCmJ1bmNoIG9mIG90aGVy IHJhbmRvbSBzdHVmZiBpcyBoZXJlOgoKaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+ZGFu dmV0L2RybS9sb2cvCgpJZiB0aGF0IGRvZXNuJ3QgY2hlcnJ5LXBpY2sgY2xlYW5seSBJJ20gY29u ZnVzZWQgYWJvdXQgc29tZXRoaW5nLgotRGFuaWVsCgo+Cj4gQmVzdCByZWdhcmRzLAo+IExpdml1 Cj4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGlu dGVsLmNvbT4KPiA+IENjOiAiSmFtZXMgKFFpYW4pIFdhbmciIDxqYW1lcy5xaWFuLndhbmdAYXJt LmNvbT4KPiA+IENjOiBMaXZpdSBEdWRhdSA8bGl2aXUuZHVkYXVAYXJtLmNvbT4KPiA+IENjOiBN aWhhaWwgQXRhbmFzc292IDxtaWhhaWwuYXRhbmFzc292QGFybS5jb20+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9kcnYuYyB8IDMgKysrCj4gPiAgMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YXJtL21hbGlkcF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jCj4gPiBp bmRleCA2OWZlZTA1YzI1NmMuLjI2ZTYwNDAxYThlMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9hcm0vbWFsaWRwX2Rydi5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL21h bGlkcF9kcnYuYwo+ID4gQEAgLTIzNCw2ICsyMzQsNyBAQCBzdGF0aWMgdm9pZCBtYWxpZHBfYXRv bWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAgICAg IHN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ICAgICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq b2xkX2NydGNfc3RhdGU7Cj4gPiAgICAgICBpbnQgaTsKPiA+ICsgICAgIGJvb2wgZmVuY2VfY29v a2llID0gZG1hX2ZlbmNlX2JlZ2luX3NpZ25hbGxpbmcoKTsKPiA+Cj4gPiAgICAgICBwbV9ydW50 aW1lX2dldF9zeW5jKGRybS0+ZGV2KTsKPiA+Cj4gPiBAQCAtMjYwLDYgKzI2MSw4IEBAIHN0YXRp YyB2b2lkIG1hbGlkcF9hdG9taWNfY29tbWl0X3RhaWwoc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlKQo+ID4KPiA+ICAgICAgIG1hbGlkcF9hdG9taWNfY29tbWl0X2h3X2RvbmUoc3RhdGUp Owo+ID4KPiA+ICsgICAgIGRtYV9mZW5jZV9lbmRfc2lnbmFsbGluZyhmZW5jZV9jb29raWUpOwo+ ID4gKwo+ID4gICAgICAgcG1fcnVudGltZV9wdXQoZHJtLT5kZXYpOwo+ID4KPiA+ICAgICAgIGRy bV9hdG9taWNfaGVscGVyX2NsZWFudXBfcGxhbmVzKGRybSwgc3RhdGUpOwo+ID4gLS0KPiA+IDIu MjcuMAo+ID4KPgo+IC0tCj4gPT09PT09PT09PT09PT09PT09PT0KPiB8IEkgd291bGQgbGlrZSB0 byB8Cj4gfCBmaXggdGhlIHdvcmxkLCAgfAo+IHwgYnV0IHRoZXkncmUgbm90IHwKPiB8IGdpdmlu ZyBtZSB0aGUgICB8Cj4gIFwgc291cmNlIGNvZGUhICAvCj4gICAtLS0tLS0tLS0tLS0tLS0KPiAg ICAgwq9cXyjjg4QpXy/CrwoKCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==