From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and atomic paths Date: Thu, 29 Jun 2017 13:00:32 +0200 Message-ID: References: <20170627145936.18983-1-daniel.vetter@ffwll.ch> <20170627145936.18983-10-daniel.vetter@ffwll.ch> <28764010-74e0-5049-ee9c-9ddc944efb20@linux.intel.com> <45b24a01-ade9-f8df-d6c9-99ea9cc4309a@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC1726E64C for ; Thu, 29 Jun 2017 11:00:33 +0000 (UTC) Received: by mail-it0-x244.google.com with SMTP id 185so702918itv.3 for ; Thu, 29 Jun 2017 04:00:33 -0700 (PDT) In-Reply-To: <45b24a01-ade9-f8df-d6c9-99ea9cc4309a@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: Daniel Vetter , Intel Graphics Development , Thierry Reding , Peter Rosin , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMTI6NTggUE0sIE1hYXJ0ZW4gTGFua2hvcnN0CjxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IE9wIDI5LTA2LTE3IG9tIDEy OjMxIHNjaHJlZWYgRGFuaWVsIFZldHRlcjoKPj4gT24gVGh1LCBKdW4gMjksIDIwMTcgYXQgMTI6 MjIgUE0sIE1hYXJ0ZW4gTGFua2hvcnN0Cj4+IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+IHdyb3RlOgo+Pj4+ICtzdGF0aWMgdm9pZCBkcG1zX2F0b21pYyhzdHJ1Y3QgZHJtX2Zi X2hlbHBlciAqZmJfaGVscGVyLCBpbnQgZHBtc19tb2RlKQo+Pj4+ICt7Cj4+Pj4gKyAgICAgc3Ry dWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2Owo+Pj4+ICsgICAgIHN0cnVjdCBk cm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPj4+PiArICAgICBpbnQgaSwgcmV0Owo+Pj4+ICsKPj4+ PiArICAgICBzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggY3R4Owo+Pj4+ICsKPj4+PiAr ICAgICBkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4+Pj4gKwo+Pj4+ICsgICAg IHN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+Pj4+ICsgICAgIGlmICghc3Rh dGUpIHsKPj4+PiArICAgICAgICAgICAgIHJldCA9IC1FTk9NRU07Cj4+Pj4gKyAgICAgICAgICAg ICBnb3RvIG91dF9jdHg7Cj4+Pj4gKyAgICAgfQo+Pj4+ICsKPj4+PiArICAgICBzdGF0ZS0+YWNx dWlyZV9jdHggPSAmY3R4Owo+Pj4+ICtyZXRyeToKPj4+PiArICAgICBmb3IgKGkgPSAwOyBpIDwg ZmJfaGVscGVyLT5jcnRjX2NvdW50OyBpKyspIHsKPj4+PiArICAgICAgICAgICAgIHN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPj4+PiArICAgICAgICAgICAgIHN0cnVjdCBkcm1f Y3J0YyAqY3J0YzsKPj4+PiArCj4+Pj4gKyAgICAgICAgICAgICBpZiAoIWZiX2hlbHBlci0+Y3J0 Y19pbmZvW2ldLm1vZGVfc2V0Lm1vZGUpCj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGNvbnRp bnVlOwo+Pj4+ICsKPj4+PiArICAgICAgICAgICAgIGNydGMgPSBmYl9oZWxwZXItPmNydGNfaW5m b1tpXS5tb2RlX3NldC5jcnRjOwo+Pj4+ICsKPj4+PiArICAgICAgICAgICAgIGNydGNfc3RhdGUg PSBkcm1fYXRvbWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPj4+PiArICAgICAgICAg ICAgIGlmIChJU19FUlIoY3J0Y19zdGF0ZSkpIHsKPj4+PiArICAgICAgICAgICAgICAgICAgICAg cmV0ID0gUFRSX0VSUihjcnRjX3N0YXRlKTsKPj4+PiArICAgICAgICAgICAgICAgICAgICAgZ290 byBvdXRfc3RhdGU7Cj4+Pj4gKyAgICAgICAgICAgICB9Cj4+PiBIbSwgbWF5YmUgcmVtb3ZlIHRo ZSBlYXJseSBjb250aW51ZSwgYW5kIGNoYW5nZSB0aGlzIHRvIGlmIChjcnRjX3N0YXRlLT5lbmFi bGUpIGNydGNfc3RhdGUtPmFjdGl2ZSA9IC4uLjsgPwo+Pj4KPj4+IEkgZG9uJ3Qga25vdyBpZiBp dCBtYXR0ZXJzIGluIHByYWN0aWNlLCBidXQgaXQgbWlnaHQgYmUgbW9yZSByZXNpbGllbnQgd2hl biBjcnRjIHN0YXRlIGRvZXMgbm90IG1hdGNoIG91ciBleHBlY3RlZCBzdGF0ZSwKPj4+IHNpbWls YXIgdG8gaG93IERQTVMgb24gaXMgaWdub3JlZCB3aXRob3V0IENSVEMuCj4+IEkganVzdCBibGlu ZGx5IHNtYXNoZWQgdGhlIG9sZCBmYmRldiBjb2RlIGluIHdpdGggdGhlIGhlbHBlciBhbmQgbW92 ZWQKPj4gdGhlIGxvY2tpbmcgb3V0LiBOb3Qgc3VyZSB3aGF0IHdvdWxkIGJlIGJldHRlciBoZXJl LCBzaW5jZSB0aGUKPj4gY29udGludWUgaXMgaW4gYSB3YXkganVzdCBwYXJ0IG9mIGEgbm9uLWV4 aXN0ZW50Cj4+IGRybV9mYl9oZWxwZXJfZm9yX2VhY2hfYWN0aXZlX2NydGMgbG9vcCBpdGVyYXRv ci4gTm90IHN1cmUgaXQncyB3b3J0aAo+PiBpdCB0byBvdmVycG9saXNoIHRoaXMgY29kZSB0byBz dWNoIGFuIGV4dGVudCA6LSkKPj4gLURhbmllbAo+Cj4gV2VsbCBjaGVja2luZyBmb3IgY3J0Y19z dGF0ZS0+ZW5hYmxlIGluc3RlYWQgb2YgbW9kZV9zZXQubW9kZSBwcm9iYWJseSBtZWFucyB3ZSdy ZSBhdCBsZWFzdCBidWcgZm9yIGJ1Zwo+IGNvbXBhdGlibGUgdnMgbGVnYWN5LiBJdCBtaWdodCBi ZSBiZXR0ZXIgdG8gYWRkIGEgYm9vbCBhY3RpdmUgdG8gcmVzdG9yZV9mYmRldl9tb2RlX2F0b21p Yy4KPgo+IFdoYXQgYWJvdXQgc29tZXRoaW5nIGxpa2UgdGhpcz8gVGhlIGxlc3MgYXRvbWljIGNv bW1pdHMgdGhlIGJldHRlci4gOikKCkhtIHllYWgsIHRoYXQgc291bmRzIGxpa2UgYSB1c2VmdWwg c2ltcGxpZmljYXRpb24uIEkgZG9uJ3QgdGhpbmsgd2UKc2hvdWxkIGRvIHRvbyBtdWNoIGludG8g ZXh0cmVtZXMgaW4gZmJkZXYgYW5kIG9ubHkgaGF2ZSAxIGF0b21pYwpjb21taXQsIGJlY2F1c2Ug ZmJkZXYgZnVuZGFtZW50YWxseSBpc24ndCBhdG9taWMuIEJ1dCBtZXJnaW5nIHRoZW0Kd2hlcmUg aXQgbWFrZXMgc2Vuc2UgaXMgcmVhc29uYWJsZS4KLURhbmllbAoKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9o ZWxwZXIuYwo+IGluZGV4IGU0OWJhZTEwZjBlZS4uMmM0MDFmZTg1MzFjIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2ZiX2hlbHBlci5jCj4gQEAgLTM3OCw3ICszNzgsNyBAQCBpbnQgZHJtX2ZiX2hlbHBlcl9k ZWJ1Z19sZWF2ZShzdHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRy bV9mYl9oZWxwZXJfZGVidWdfbGVhdmUpOwo+Cj4gLXN0YXRpYyBpbnQgcmVzdG9yZV9mYmRldl9t b2RlX2F0b21pYyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ICtzdGF0aWMgaW50 IHJlc3RvcmVfZmJkZXZfbW9kZV9hdG9taWMoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBl ciwgYm9vbCBhY3RpdmUpCj4gIHsKPiAgICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBm Yl9oZWxwZXItPmRldjsKPiAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+IEBAIC00 MjcsNiArNDI3LDE3IEBAIHN0YXRpYyBpbnQgcmVzdG9yZV9mYmRldl9tb2RlX2F0b21pYyhzdHJ1 Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyKQo+ICAgICAgICAgICAgICAgICByZXQgPSBfX2Ry bV9hdG9taWNfaGVscGVyX3NldF9jb25maWcobW9kZV9zZXQsIHN0YXRlKTsKPiAgICAgICAgICAg ICAgICAgaWYgKHJldCAhPSAwKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gb3V0X3N0 YXRlOwo+ICsKPiArICAgICAgICAgICAgICAgLyoKPiArICAgICAgICAgICAgICAgICogX19kcm1f YXRvbWljX2hlbHBlcl9zZXRfY29uZmlnKCkgc2V0cyBhY3RpdmUgd2hlbiBhCj4gKyAgICAgICAg ICAgICAgICAqIG1vZGUgaXMgc2V0LCB1bmNvbmRpdGlvbmFsbHkgY2xlYXIgaXQgaWYgd2UgZm9y Y2UgRFBNUyBvZmYKPiArICAgICAgICAgICAgICAgICovCj4gKyAgICAgICAgICAgICAgIGlmICgh YWN0aXZlKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRj ID0gbW9kZV9zZXQtPmNydGM7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9j cnRjX3N0YXRlICpjcnRjX3N0YXRlID0gZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3Rh dGUsIGNydGMpOwo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICBjcnRjX3N0YXRlLT5hY3Rp dmUgPSBmYWxzZTsKPiArICAgICAgICAgICAgICAgfQo+ICAgICAgICAgfQo+Cj4gICAgICAgICBy ZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gQEAgLTQ5Nyw3ICs1MDgsNyBAQCBzdGF0 aWMgaW50IHJlc3RvcmVfZmJkZXZfbW9kZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVy KQo+ICAgICAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2Owo+Cj4g ICAgICAgICBpZiAoZHJtX2Rydl91c2VzX2F0b21pY19tb2Rlc2V0KGRldikpCj4gLSAgICAgICAg ICAgICAgIHJldHVybiByZXN0b3JlX2ZiZGV2X21vZGVfYXRvbWljKGZiX2hlbHBlcik7Cj4gKyAg ICAgICAgICAgICAgIHJldHVybiByZXN0b3JlX2ZiZGV2X21vZGVfYXRvbWljKGZiX2hlbHBlciwg dHJ1ZSk7Cj4gICAgICAgICBlbHNlCj4gICAgICAgICAgICAgICAgIHJldHVybiByZXN0b3JlX2Zi ZGV2X21vZGVfbGVnYWN5KGZiX2hlbHBlcik7Cj4gIH0KPiBAQCAtNzE0LDcgKzY2OSw3IEBAIHN0 YXRpYyB2b2lkIGRybV9mYl9oZWxwZXJfZHBtcyhzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgaW50IGRw bXNfbW9kZSkKPiAgICAgICAgIH0KPgo+ICAgICAgICAgaWYgKGRybV9kcnZfdXNlc19hdG9taWNf bW9kZXNldChmYl9oZWxwZXItPmRldikpCj4gLSAgICAgICAgICAgICAgIGRwbXNfYXRvbWljKGZi X2hlbHBlciwgZHBtc19tb2RlKTsKPiArICAgICAgICAgICAgICAgcmVzdG9yZV9mYmRldl9tb2Rl X2F0b21pYyhmYl9oZWxwZXIsIGRwbXNfbW9kZSA9PSBEUk1fTU9ERV9EUE1TX09OKTsKPiAgICAg ICAgIGVsc2UKPiAgICAgICAgICAgICAgICAgZHBtc19sZWdhY3koZmJfaGVscGVyLCBkcG1zX21v ZGUpOwo+ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZmYl9oZWxwZXItPmxvY2spOwo+CgoKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDAp IDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=