From: Daniel Vetter <daniel@ffwll.ch>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Jose Abreu <joabreu@synopsys.com>,
Carlos Palminha <palminha@synopsys.com>
Subject: Re: [PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks
Date: Mon, 15 May 2017 10:14:22 +0200 [thread overview]
Message-ID: <CAKMK7uHvU7OcmY5J3_gJzWeo7DyE_vzdO0DdRQ2_DBCUUsr5BQ@mail.gmail.com> (raw)
In-Reply-To: <7b5b274e-ad07-7b8d-3fa1-fe363f953ef4@samsung.com>
On Mon, May 15, 2017 at 10:10 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> Sorry for confusing shortcut, I have just inspected call sites of both
> callbacks - drm_helper_probe_single_connector_modes, both callbacks are
> called from this function, so my idea was to move loop
> 'list_for_each_entry(mode, &connector->modes, head){ ....,
> ...->mode_valid(...); ....}' from
> drm_helper_probe_single_connector_modes to .get_modes callback. After
> looking bit more at this function I have realized that such change is
> not so obvious, and it is not really clear if the final result will be
> better :).
This would defeat the purpose of ->get_modes, which is to just grab
the modes from the sink, without filtering for source constraints,
which is done by ->mode_valid. That framework is why we have the probe
helpers, if you want to do something else you can always implement
->fill_modes (which is the uapi entry point) yourself.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-05-15 8:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 9:05 [PATCH v3 0/6] Introduce new mode validation callbacks Jose Abreu
2017-05-11 9:05 ` [PATCH v3 1/6] drm: Add crtc/encoder/bridge->mode_valid() callbacks Jose Abreu
2017-05-12 7:00 ` Daniel Vetter
2017-05-12 7:00 ` Daniel Vetter
2017-05-12 7:31 ` [PATCH] " Daniel Vetter
2017-05-12 11:29 ` Laurent Pinchart
2017-05-15 6:50 ` Daniel Vetter
2017-05-12 12:37 ` Andrzej Hajda
2017-05-15 6:56 ` Daniel Vetter
2017-05-15 8:10 ` Andrzej Hajda
2017-05-15 8:14 ` Daniel Vetter [this message]
2017-05-12 15:59 ` Jose Abreu
2017-05-15 9:11 ` [PATCH 1/2] drm/doc: Document adjusted/request modes a bit better Daniel Vetter
2017-05-15 9:11 ` [PATCH 2/2] drm/doc: Clarify mode_fixup vs. atomic_check a bit more Daniel Vetter
2017-05-16 2:41 ` Jose Abreu
2017-05-16 13:14 ` Andrzej Hajda
2017-05-16 2:38 ` [PATCH 1/2] drm/doc: Document adjusted/request modes a bit better Jose Abreu
2017-05-16 13:17 ` Andrzej Hajda
2017-05-15 9:33 ` [PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks Daniel Vetter
2017-05-16 13:15 ` Andrzej Hajda
2017-05-11 9:05 ` [PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu
2017-05-15 8:27 ` Andrzej Hajda
2017-05-15 8:27 ` Andrzej Hajda
2017-05-11 9:05 ` [PATCH v3 3/6] drm: Introduce drm_bridge_mode_valid() Jose Abreu
2017-05-11 9:06 ` [PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu
2017-05-15 8:39 ` Andrzej Hajda
2017-05-15 8:39 ` Andrzej Hajda
2017-05-15 9:30 ` Daniel Vetter
2017-05-15 9:30 ` Daniel Vetter
2017-05-15 9:51 ` Andrzej Hajda
2017-05-15 9:51 ` Andrzej Hajda
2017-05-11 9:06 ` [PATCH v3 5/6] drm: Use mode_valid() in atomic modeset Jose Abreu
2017-05-15 8:45 ` Andrzej Hajda
2017-05-11 9:06 ` [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback Jose Abreu
2017-05-15 8:53 ` Daniel Vetter
2017-05-15 8:53 ` Daniel Vetter
2017-05-15 15:52 ` Daniel Vetter
2017-05-15 15:52 ` Daniel Vetter
2017-05-15 23:55 ` Jose Abreu
2017-05-15 23:55 ` Jose Abreu
2017-05-15 8:54 ` Andrzej Hajda
2017-05-15 8:54 ` Andrzej Hajda
2017-05-12 7:32 ` [PATCH v3 0/6] Introduce new mode validation callbacks Daniel Vetter
2017-05-12 7:32 ` Daniel Vetter
2017-05-12 13:37 ` Andrzej Hajda
2017-05-12 13:37 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uHvU7OcmY5J3_gJzWeo7DyE_vzdO0DdRQ2_DBCUUsr5BQ@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=Jose.Abreu@synopsys.com \
--cc=a.hajda@samsung.com \
--cc=abrodkin@synopsys.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joabreu@synopsys.com \
--cc=palminha@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.