All of lore.kernel.org
 help / color / mirror / Atom feed
From: 林自均 <johnlinp@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git <git@vger.kernel.org>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v2] status: add an empty line when there is no hint
Date: Tue, 14 May 2019 08:30:44 +0800	[thread overview]
Message-ID: <CAKO26MvkD6-ZuGLbc7EBrh8umiyg2KAhj1eTDPtMNu5Tg5wE+w@mail.gmail.com> (raw)
In-Reply-To: <xmqqh89ydhqu.fsf@gitster-ct.c.googlers.com>

Hi Junio,

Junio C Hamano <gitster@pobox.com> 於 2019年5月13日 週一 下午1:51寫道：
>
> 林自均 <johnlinp@gmail.com> writes:
>
> > Hi Junio,
> >> ...
> > Could you please give me some advice on my patch? Thank you.
>
> I tend to agree with what Phillip said in
> <ae1332b8-a227-e83a-8862-8811b6a81251@gmail.com>.
>
> If the difference between "status" and "commit" bothers you so much,
> i.e.
>
>     When typing "git status", there is an empty line between the
>     "Changes not staged for commit:" block and the list of changed
>     files. However, when typing "git commit" with no files added,
>     there are no empty lines between them.
>
> it may not be a bad idea to try making them consistent by removing
> the blank line that is given after the advice messages, perhaps?

Thank you for the review. I guess removing the blank line also work
for me. I'll submit another patch.

Best,
John Lin

  reply	other threads:[~2019-05-14  0:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30  6:02 [PATCH v2] status: add an empty line when there is no hint John Lin
2019-04-30 11:15 ` Phillip Wood
2019-04-30 22:23   ` 林自均
2019-05-01 23:45   ` brian m. carlson
2019-05-02  0:35     ` 林自均
2019-05-02 23:15       ` brian m. carlson
2019-05-03  4:15         ` 林自均
2019-05-10  0:56           ` 林自均
2019-05-13  5:51             ` Junio C Hamano
2019-05-14  0:30               ` 林自均 [this message]
2019-05-14  2:04               ` brian m. carlson
2019-05-14  7:33                 ` Junio C Hamano
2019-05-14  9:43                   ` 林自均
2019-05-15  0:48                     ` Junio C Hamano
2019-05-15  3:02                       ` 林自均
2019-05-22 23:01                         ` 林自均

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKO26MvkD6-ZuGLbc7EBrh8umiyg2KAhj1eTDPtMNu5Tg5wE+w@mail.gmail.com \
    --to=johnlinp@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.