From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com. [2607:f8b0:4001:c06::22f]) by gmr-mx.google.com with ESMTPS id h1si168056ith.1.2016.11.23.00.39.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 00:39:13 -0800 (PST) Received: by mail-io0-x22f.google.com with SMTP id x94so11709736ioi.3 for ; Wed, 23 Nov 2016 00:39:13 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20161122223103.qd44b3z5aj4ahroi@piout.net> References: <1478945246-32056-1-git-send-email-Nicolae_Rosia@mentor.com> <1478945246-32056-2-git-send-email-Nicolae_Rosia@mentor.com> <20161122223103.qd44b3z5aj4ahroi@piout.net> From: Nicolae Rosia Date: Wed, 23 Nov 2016 10:39:12 +0200 Message-ID: Subject: [rtc-linux] Re: [PATCH 1/3] rtc: rtc-twl: kill static variables To: Alexandre Belloni Cc: Nicolae Rosia , Alessandro Zummo , rtc-linux@googlegroups.com, linux-omap@vger.kernel.org, Tony Lindgren Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, Thanks for the review. On Wed, Nov 23, 2016 at 12:31 AM, Alexandre Belloni wrote: > Hi, > > A few alignments are off but I can fix that provided you answer the > question below: > Ok, could you please indicate which lines so I can fix them instead of wasting your time? > On 12/11/2016 at 12:07:24 +0200, Nicolae Rosia wrote : >> /* for twl6030/32 make sure BIT_RTC_CTRL_REG_GET_TIME_M is clear */ >> - if (twl_class_is_6030()) { >> + if (!twl_rtc->is_4030) { > > This changes the meaning of it. What if at some point there is a new > part that is neither a 4030 nor an 6030? > That will probably mean going over ths part of code again but maybe the > odds are low and nobody cares. Since there are only two classes, 4030 and 6030, it will work. But you're right, it's better to retain the old logic so the changes are minimal. Will send V2 in a bit. Thanks, Nicolae -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolae Rosia Subject: Re: [PATCH 1/3] rtc: rtc-twl: kill static variables Date: Wed, 23 Nov 2016 10:39:12 +0200 Message-ID: References: <1478945246-32056-1-git-send-email-Nicolae_Rosia@mentor.com> <1478945246-32056-2-git-send-email-Nicolae_Rosia@mentor.com> <20161122223103.qd44b3z5aj4ahroi@piout.net> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20161122223103.qd44b3z5aj4ahroi-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Alexandre Belloni Cc: Nicolae Rosia , Alessandro Zummo , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tony Lindgren List-Id: linux-omap@vger.kernel.org Hi, Thanks for the review. On Wed, Nov 23, 2016 at 12:31 AM, Alexandre Belloni wrote: > Hi, > > A few alignments are off but I can fix that provided you answer the > question below: > Ok, could you please indicate which lines so I can fix them instead of wasting your time? > On 12/11/2016 at 12:07:24 +0200, Nicolae Rosia wrote : >> /* for twl6030/32 make sure BIT_RTC_CTRL_REG_GET_TIME_M is clear */ >> - if (twl_class_is_6030()) { >> + if (!twl_rtc->is_4030) { > > This changes the meaning of it. What if at some point there is a new > part that is neither a 4030 nor an 6030? > That will probably mean going over ths part of code again but maybe the > odds are low and nobody cares. Since there are only two classes, 4030 and 6030, it will work. But you're right, it's better to retain the old logic so the changes are minimal. Will send V2 in a bit. Thanks, Nicolae -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.