All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: clearly specify what refs are honored by core.logAllRefUpdates
Date: Mon, 11 Jul 2011 20:23:17 +0200	[thread overview]
Message-ID: <CAKPyHN3aef5MQh+rv4O07vrVbzziTj+==2H-hKM1XwUwCOqq6Q@mail.gmail.com> (raw)
In-Reply-To: <7v7h7og1zo.fsf@alter.siamese.dyndns.org>

On Mon, Jul 11, 2011 at 19:29, Junio C Hamano <gitster@pobox.com> wrote:
> Bert Wesarg <bert.wesarg@googlemail.com> writes:
>
>> The documentation for logging updates in git-update-ref, doesn't make it
>> clear that only a specific subset of refs are honored by this variable.
>
> Thanks.
>
>> The initial justification in 4057deb (Junio C Hamano, 2006-10-08), leaves
>> the impression, that a blacklist would have made more sense,...
>
> I didn't mean it that way, and I still don't think blacklisting is
> feasible nor necessarily desirable. Different porcelains can use
> namespaces under refs/ for their own purposes, and it would be more
> prudent not to create reflog files that can grow long and not useful
> given that we cannot predict/guess what they are used for and how, so
> I would prefer white-listing the ones that are known to be useful.
>
> It might make sense to allow customizing the white-list via the
> configuration mechanism, though. When your favorite third-party git
> "frotz" add-on uses refs/frotz/ hierarchy for its own purpose, and if
> viewing "git log -g frotz/master@{now}" is useful, you may want to be able
> to say "In addition to the standard ones, please log refs/frotz/*
> automatically". Of the top of my head, something like:

This sounds like a good idea, and with the -c option you could use it like this:

    git -c core.autoLogRef=frotz update-ref -m foo refs/frotz/master <sha1>

without having the trouble to set this config inside git-frotz

Actually, I tried also to add something like --force or --always-log
as an option to update-ref, so that the log file is created
automatically. But that doesn't looked that trivial.

>
>        [core]
>                autoRefLog = refs/heads/*
>                autoRefLog = refs/remotes/*
>                autoRefLog = refs/notes/*
>
> or less expressive but even simpler and probably sufficient:
>
>        [core]
>                autoRefLog = heads remotes notes
>
> can be the spelled-out form of traditional "core.logAllRefUpdates", and
> you may be able to tweak it like:
>
>
>        [core]
>                autoRefLog = heads remotes notes frotz
>

The question is: should the user be able to disable logging of the
hard-coded values. With your examples that would be possible. But I
think we should not allow that. Thus, this config should only adds to
the list, but never resets.

Bert

  reply	other threads:[~2011-07-11 18:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  9:14 [PATCH] Documentation: clearly specify what refs are honored by core.logAllRefUpdates Bert Wesarg
2011-07-11 17:29 ` Junio C Hamano
2011-07-11 18:23   ` Bert Wesarg [this message]
2011-07-11 21:24     ` Junio C Hamano
2011-07-12  4:39 ` Michael Haggerty
2011-07-12 17:03   ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKPyHN3aef5MQh+rv4O07vrVbzziTj+==2H-hKM1XwUwCOqq6Q@mail.gmail.com' \
    --to=bert.wesarg@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.