From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3CBC43461 for ; Wed, 16 Sep 2020 02:37:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BE6321655 for ; Wed, 16 Sep 2020 02:37:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="LsoMQ9jg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbgIPChC (ORCPT ); Tue, 15 Sep 2020 22:37:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbgIPChB (ORCPT ); Tue, 15 Sep 2020 22:37:01 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5D3AC06174A for ; Tue, 15 Sep 2020 19:37:00 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id a15so4604819ljk.2 for ; Tue, 15 Sep 2020 19:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fv8yt3Mc4zl4f94N5JDsxGnqubAPR0A1k38BepP4lq8=; b=LsoMQ9jgoUVYemW5jeO9ZrjqVwiOIoBF/niIFvkCZZCE3WW2cGKEwmoLP2gUobuZUG iie+zJIMmfknwsDyXecyN0xYhoF45QgIeLyg2ZKVkQJKJz1AoKnT1CJS/VcSlmM27vPC FYfZvV4k6MVQMIpapJXFEF3vZ39QvJvF0ZW4LPqdr06CEHbaczP8kGyPLIXAn0w+ZrAa gjnfeNeID89L1DSP3hHtBC2NtCmfksQdpxbuHlLMZgFq9QGm5Q/GapYBtCqED2L+8I0N zp50Jv6CteM0WB12JdYId4TQ0AOf7dLULYFDZGJ6WkeLwCuwbOcBkZWxNJbA8epw0j6r cyWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fv8yt3Mc4zl4f94N5JDsxGnqubAPR0A1k38BepP4lq8=; b=psp/hyAMJdt0ig5vHlZgFFqRqVE2WcuzqX/+TKOjsJRk86VXnah+TrFsnRL5ZxjW4E EJ4/N6hTeRtxF8O9PM/Q9AsP6RmUKvyz2xt4cOUc0E1SybfOuE/jKojcFMFIBnab6lLd Ltexm7U+VRFSJcYYswXeqYMuCVegfet1pttlvrzPkaJapvJaiGOBIMtx0Hr2wwyd+mM2 06YVyvevEWaAGW5jG0aGT8Si26l6rUkZNTV6jJqOKGMX/QzG+BaJAxcSp7FoohZHk2s0 CKrL66VwuL0hjqRrpESBn4wqzkFFj3r7nkL+DaRQzGFoSPgGET29dznMtKtsgI6Je9lk PkiQ== X-Gm-Message-State: AOAM533H5CZ7NIKQZ/sVGFYoo9mF8V+or1IR9TbsLPhYDASSLS8JmHAO x0NVm19Yorat2PMN7GnwMFeFW/Yg1vX0J/Ol5XAUPA== X-Google-Smtp-Source: ABdhPJx1JVUXcV+qAuIt1Ulq1cCdBPwGFDNwYw6hlbe2tZaHW1zQ0sz2/FL9dKBsZ62IDLjqiTT3waizNWoS86lRtaA= X-Received: by 2002:a2e:9089:: with SMTP id l9mr8683636ljg.408.1600223819202; Tue, 15 Sep 2020 19:36:59 -0700 (PDT) MIME-Version: 1.0 References: <20200915132741.84869-1-zangchunxin@bytedance.com> <20200915144737.GA2581123@chrisdown.name> <20200915145533.GG3736@dhcp22.suse.cz> <20200915162604.GB2581123@chrisdown.name> In-Reply-To: <20200915162604.GB2581123@chrisdown.name> From: Chunxin Zang Date: Wed, 16 Sep 2020 10:36:48 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node To: Chris Down Cc: Michal Hocko , Andrew Morton , Linux Memory Management List , LKML , Muchun Song Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 12:26 AM Chris Down wrote: > > Michal Hocko writes: > >On Tue 15-09-20 15:47:37, Chris Down wrote: > >> zangchunxin@bytedance.com writes: > >> > + if (signal_pending(current)) > >> > + return; > >> > >> This doesn't match your patch title, please update it. :-) > > > >I have to admit I have completely missed this and I think that this > >should better be fatal_signal_pending because that would make sure that > >the userspace will not see an incomplete operation. This is a general > >practice for other bail outs as well. > > Oh sorry, to be clear, I meant the patch should match the title, not the other > way around. My apologies about that. In my first version of patch, it's 'fatal_signal_pending'. But in this version, I used the wrong branch. I will update it now. Best wishes Chunxin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E775C433E2 for ; Wed, 16 Sep 2020 02:37:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D59B020BED for ; Wed, 16 Sep 2020 02:37:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="LsoMQ9jg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D59B020BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 444616B0055; Tue, 15 Sep 2020 22:37:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41A956B005A; Tue, 15 Sep 2020 22:37:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332286B005C; Tue, 15 Sep 2020 22:37:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 1D2086B0055 for ; Tue, 15 Sep 2020 22:37:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C7F7B180AD80F for ; Wed, 16 Sep 2020 02:37:01 +0000 (UTC) X-FDA: 77267362242.23.dad44_1213ad527116 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 970D737604 for ; Wed, 16 Sep 2020 02:37:01 +0000 (UTC) X-HE-Tag: dad44_1213ad527116 X-Filterd-Recvd-Size: 3781 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 02:37:00 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id y4so4563690ljk.8 for ; Tue, 15 Sep 2020 19:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fv8yt3Mc4zl4f94N5JDsxGnqubAPR0A1k38BepP4lq8=; b=LsoMQ9jgoUVYemW5jeO9ZrjqVwiOIoBF/niIFvkCZZCE3WW2cGKEwmoLP2gUobuZUG iie+zJIMmfknwsDyXecyN0xYhoF45QgIeLyg2ZKVkQJKJz1AoKnT1CJS/VcSlmM27vPC FYfZvV4k6MVQMIpapJXFEF3vZ39QvJvF0ZW4LPqdr06CEHbaczP8kGyPLIXAn0w+ZrAa gjnfeNeID89L1DSP3hHtBC2NtCmfksQdpxbuHlLMZgFq9QGm5Q/GapYBtCqED2L+8I0N zp50Jv6CteM0WB12JdYId4TQ0AOf7dLULYFDZGJ6WkeLwCuwbOcBkZWxNJbA8epw0j6r cyWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fv8yt3Mc4zl4f94N5JDsxGnqubAPR0A1k38BepP4lq8=; b=DHdFrSrEfmK7XmAHdvQr3A6lq5MlxqLXmx2uRDnfHQ/Inj4JrN/6rawPcAtN4vaSFM n4Fk0qlDQqhDSDYq26HOoCNRxfv6/icgFuVfNaaYEO8/RsLw5QBEq2Eomws3oAy1UOWA ohA0Gu8MTgnimDDhRfOAapj1/GswM7/T7T8xwKWUn2ATT6O9G+IpGkmTtgqhpybDyQp5 zWl2oWsmV1055cLag0yQo6Tm26x38PE0/tTfnCqQl9VsR5RyFmVogQF8K/0JussMSexp HnTPptQMM2D5sdYXdhnvYlIWFREq59m0zrgQbbNaRBH+mzsOhNMiU+Kg9dSH27kN3CYE PbNg== X-Gm-Message-State: AOAM533bTK40nRXx17DhpJkB3VdOTJTpJWxSHXrSFikpuRVUcto+tmE9 aEyuE58nytGhPi746XmhFRnoRrozEUktTcpdCsOwLQ== X-Google-Smtp-Source: ABdhPJx1JVUXcV+qAuIt1Ulq1cCdBPwGFDNwYw6hlbe2tZaHW1zQ0sz2/FL9dKBsZ62IDLjqiTT3waizNWoS86lRtaA= X-Received: by 2002:a2e:9089:: with SMTP id l9mr8683636ljg.408.1600223819202; Tue, 15 Sep 2020 19:36:59 -0700 (PDT) MIME-Version: 1.0 References: <20200915132741.84869-1-zangchunxin@bytedance.com> <20200915144737.GA2581123@chrisdown.name> <20200915145533.GG3736@dhcp22.suse.cz> <20200915162604.GB2581123@chrisdown.name> In-Reply-To: <20200915162604.GB2581123@chrisdown.name> From: Chunxin Zang Date: Wed, 16 Sep 2020 10:36:48 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node To: Chris Down Cc: Michal Hocko , Andrew Morton , Linux Memory Management List , LKML , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 970D737604 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000379, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 16, 2020 at 12:26 AM Chris Down wrote: > > Michal Hocko writes: > >On Tue 15-09-20 15:47:37, Chris Down wrote: > >> zangchunxin@bytedance.com writes: > >> > + if (signal_pending(current)) > >> > + return; > >> > >> This doesn't match your patch title, please update it. :-) > > > >I have to admit I have completely missed this and I think that this > >should better be fatal_signal_pending because that would make sure that > >the userspace will not see an incomplete operation. This is a general > >practice for other bail outs as well. > > Oh sorry, to be clear, I meant the patch should match the title, not the other > way around. My apologies about that. In my first version of patch, it's 'fatal_signal_pending'. But in this version, I used the wrong branch. I will update it now. Best wishes Chunxin