From: Tom Psyborg <pozega.tomislav@gmail.com>
To: Tim Schumacher <timschumi@gmx.de>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k: Check for errors when reading SREV register
Date: Wed, 20 Mar 2019 00:38:46 +0100 [thread overview]
Message-ID: <CAKR_QVKWbrx2EmcaCBhyuaYRd+T3pFW0i2jVcDZG6=wee=DaMA@mail.gmail.com> (raw)
In-Reply-To: <57195909-b18b-8490-e1b8-043ff9727e5a@gmx.de>
On 19/03/2019, Tim Schumacher <timschumi@gmx.de> wrote:
>
> The case in where the revision succeeded to read, but it simply
> isn't supported by the driver, is untouched and it still prints
> the original message.
>
In that case this change is fine.
> I don't know why it fails to read the SREV register in my specific
> case (I tracked it down to a WMI command timeout, which seems to
> only happen on a Raspberry Pi 3), but having the SREV error message
> (which points to the actual issue) instead of the false-positive
> "Rev not supported" message would have saved me quite some time that
> I spent with debugging the issue, searching for the source of the
> wrong value.
>
Did you try some other device than RPI3 ? I've noticed that on router
and laptop while doing some htc fw builds.
next prev parent reply other threads:[~2019-03-19 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 19:05 [PATCH] ath9k: Check for errors when reading SREV register Tim Schumacher
2019-03-18 22:35 ` Tom Psyborg
2019-03-19 6:41 ` Tim Schumacher
2019-03-19 23:38 ` Tom Psyborg [this message]
2019-03-20 5:35 ` Tim Schumacher
2019-03-21 10:02 ` Kalle Valo
2019-03-22 1:47 ` Tim Schumacher
2019-03-22 8:37 ` Kalle Valo
2019-04-29 14:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKR_QVKWbrx2EmcaCBhyuaYRd+T3pFW0i2jVcDZG6=wee=DaMA@mail.gmail.com' \
--to=pozega.tomislav@gmail.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=timschumi@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.