From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============8184159453605103189=="
MIME-Version: 1.0
From: Giacinto Cifelli <gciofono@gmail.com>
Subject: Re: [PATCH 3/5] src/gprs: support for NONE auth
Date: Tue, 09 Oct 2018 20:49:51 +0200
Message-ID: <CAKSBH7GOjFLrLMUbT=BHTbidS7XgadK93FZppKjjvpbmkDCOeA@mail.gmail.com>
In-Reply-To: <b4b5e9b2-9109-6ee0-8902-4470b9f31f87@gmail.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============8184159453605103189==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Denis,

On Tue, Oct 9, 2018 at 7:37 PM Denis Kenzior <denkenz@gmail.com> wrote:
>
> Hi Giacinto,
>
> On 10/06/2018 12:45 AM, Giacinto Cifelli wrote:
> > ---
> >   src/gprs.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
>
> Applied, see below:
>
> >
> > diff --git a/src/gprs.c b/src/gprs.c
> > index 79fafdbc..235c8884 100644
> > --- a/src/gprs.c
> > +++ b/src/gprs.c
> > @@ -261,6 +261,10 @@ static const char *gprs_auth_method_to_string(enum=
 ofono_gprs_auth_method auth)
> >               return "chap";
> >       case OFONO_GPRS_AUTH_METHOD_PAP:
> >               return "pap";
> > +     case OFONO_GPRS_AUTH_METHOD_NONE:
> > +             return "none";
> > +     default:
> > +             return NULL;
>
> I dropped this default statement for reasons outlined in our earlier
> discussions.

oh yes, thanks. I forgot to change this too.

>
> >       };
> >
> >       return NULL;
> > @@ -275,6 +279,9 @@ static gboolean gprs_auth_method_from_string(const =
char *str,
> >       } else if (g_str_equal(str, "pap")) {
> >               *auth =3D OFONO_GPRS_AUTH_METHOD_PAP;
> >               return TRUE;
> > +     } else if (g_str_equal(str, "none")) {
> > +             *auth =3D OFONO_GPRS_AUTH_METHOD_NONE;
> > +             return TRUE;
> >       }
> >
> >       return FALSE;
> >
>
> Regards,
> -Denis

Regards,
Giacinto

--===============8184159453605103189==--