From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============0905000372266242743=="
MIME-Version: 1.0
From: Giacinto Cifelli <gciofono@gmail.com>
Subject: Re: [PATCH] src/modem.c/call_watches null pointer check
Date: Tue, 23 Oct 2018 19:30:56 +0200
Message-ID: <CAKSBH7HMe=OGbwTE8QphcpOOsUCQj8226TTG60WeRSKN73FH4g@mail.gmail.com>
In-Reply-To: <cc405107-2207-928a-2e48-1e472b7be45b@gmail.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============0905000372266242743==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Denis,

I didn't know this was a surprise interrogation!

On Tue, Oct 23, 2018 at 6:50 PM Denis Kenzior <denkenz@gmail.com> wrote:
>
> Hi Giacinto,
> >     0  0x0000563b1842b735 in call_watches
> > (atom=3Datom(a)entry=3D0x563b1a3f07d0,
> > cond=3Dcond(a)entry=3DOFONO_ATOM_WATCH_CONDITION_UNREGISTERED) at
> > src/modem.c:265
> >     1  0x0000563b1842c32e in __ofono_atom_unregister
> > (atom=3Datom(a)entry=3D0x563b1a3f07d0) at src/modem.c:299
> >     2  0x0000563b1842c3ff in __ofono_atom_unregister
> > (atom=3D0x563b1a3f07d0) at src/modem.c:296
> >     3  flush_atoms (modem=3D0x563b1a3f1f50,
> > new_state=3DMODEM_STATE_POWER_OFF) at src/modem.c:448
> >     4  modem_change_state (modem=3D0x563b1a3f1f50,
> > new_state=3DMODEM_STATE_POWER_OFF) at src/modem.c:529
> >     5  0x0000563b1842c577 in set_powered
> > (modem=3Dmodem(a)entry=3D0x563b1a3f1f50, powered=3Dpowered(a)entry=3D0)=
 at
> > src/modem.c:915
> >     6  0x0000563b1842c863 in modem_unregister
> > (modem=3Dmodem(a)entry=3D0x563b1a3f1f50) at src/modem.c:2111
> >     7  0x0000563b1842e6a4 in ofono_modem_remove (modem=3D0x563b1a3f1f50)
> > at src/modem.c:2177
> >     8  0x0000563b183b05d3 in destroy_modem (data=3D0x563b1a3e50a0) at
> > plugins/udevng.c:1408
> >     9  0x00007f42b4bdd091 in ?? () from
> > /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
> >     10 0x0000563b183b561a in remove_device (device=3D0x563b1a401630) at
> > plugins/udevng.c:1468
> >     11 udev_event (channel=3D<optimized out>, cond=3D<optimized out>,
> > user_data=3D<optimized out>) at plugins/udevng.c:1991
> >     12 0x00007f42b4bef0f5 in g_main_context_dispatch () from
> > /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
> >     13 0x00007f42b4bef4c0 in ?? () from
> > /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
> >     14 0x00007f42b4bef7d2 in g_main_loop_run () from
> > /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
> >     15 0x0000563b183b0397 in main (argc=3D<optimized out>,
> > argv=3D<optimized out>) at src/main.c:294
> >
> > ?
>
> Yes, much better.  So now you can explain to me how you're triggering thi=
s.
>
> The only way modem->atom_watches is NULL is if ofono_modem_register
> failed.  So are you trying to use a modem object without registering it
> properly?

the problem is that I have moved location_information_create, along
with devinfo_create at the gemalto_enable() phase, because these two
are available also offline, and it is a normal use case to monitor the
GNSS signal while offline.
But when the modem is removed (unplugged or switched off), the
location_reporting atom is not removed, and the modem does not
disappear. devinfo goes away without any issue.

So in the gemalto_remove I have added:
   lratom =3D __ofono_modem_find_atom(modem,OFONO_ATOM_TYPE_LOCATION_REPORT=
ING);
   if (lratom)
       __ofono_atom_free(lratom);

this works fine, but maybe the watch is already destroyed?

And the whole point is, I wouldn't have to do it manually. What is
missing in this atom?

>
> Regards,
> -Denis
>

Regards,
Giacinto

--===============0905000372266242743==--