All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giacinto Cifelli <gciofono@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type
Date: Tue, 23 Oct 2018 05:01:14 +0200	[thread overview]
Message-ID: <CAKSBH7HSp4WM_m5qYcyyNsa0uVE7SkES2yk1mLQHRg2KdbeOdw@mail.gmail.com> (raw)
In-Reply-To: <3bc03dbb-985d-1250-86ee-2bdd9478489d@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Hi Denis,

On Mon, Oct 22, 2018 at 10:04 PM Denis Kenzior <denkenz@gmail.com> wrote:
>
> Hi Giacinto,
>
> On 10/22/2018 01:56 PM, Giacinto Cifelli wrote:
> > This function converts the ofono enum ofono_gprs_auth_method
> > into the value of the 3GPP 27.007 to pass to the AT command
> > ---
> >   drivers/atmodem/atutil.c | 16 ++++++++++++++++
> >   drivers/atmodem/atutil.h |  3 +++
> >   2 files changed, 19 insertions(+)
> >
>
> Your commit header does not match the patch contents or description.
> You might want to slow down a bit.

yes, I noticed that too late. Thank you for taking it anyway.

>
> Anyway, I renamed this to at_util_gprs_auth_method_to_auth_proto to
> match 3GPP naming & the naming of the pdp_type conversion function in
> the next patch.  And fixed up the commit description / header.
>
> Applied, thanks.
>
> Regards,
> -Denis

Regards,
Giacinto

      reply	other threads:[~2018-10-23  3:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22 18:56 [PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type Giacinto Cifelli
2018-10-22 18:56 ` [PATCH 2/2] atmodem/atutil: at_util_get_cgdcont_command Giacinto Cifelli
2018-10-22 20:06   ` Denis Kenzior
2018-10-22 20:04 ` [PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type Denis Kenzior
2018-10-23  3:01   ` Giacinto Cifelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKSBH7HSp4WM_m5qYcyyNsa0uVE7SkES2yk1mLQHRg2KdbeOdw@mail.gmail.com \
    --to=gciofono@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.