From: Yiwei Zhang <zzyiwei@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Prahlad Kilambi <prahladk@google.com>,
Joel Fernandes <joelaf@google.com>,
android-kernel <android-kernel@google.com>
Subject: Re: [PATCH] Add gpu memory tracepoints
Date: Wed, 12 Feb 2020 11:26:08 -0800 [thread overview]
Message-ID: <CAKT=dDk+CiMQ_-f6Daa_ea2FOW=De6PKmcyiGrm4KEkVbH2fDQ@mail.gmail.com> (raw)
In-Reply-To: <20200210221521.59928416@rorschach.local.home>
Hi Steven,
I can move the stuff out from the kernel/trace. Then can we still
leave include/trace/events/gpu_mem.h where it is right now? Or do we
have to move that out as well? Because we would need a non-drm common
header place for the tracepoint so that downstream drivers can find
the tracepoint definition.
Best,
Yiwei
On Mon, Feb 10, 2020 at 7:15 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 10 Feb 2020 19:05:35 -0800
> Yiwei Zhang <zzyiwei@google.com> wrote:
>
> > Thanks for the prompt reply!
> >
> > The tracepoint proposed here is for tracking global gpu memory usage
> > total counter and per-process gpu memory usage total counter. The
> > tracepoint is for gfx drivers who have implemented gpu memory tracking
> > system. The tracepoint expects the de-duplication of the shared memory
> > is done inside the tracking system.
> >
> > On Android, the graphics driver has implemented gpu memory tracking.
> > First, we'd like to profiler GPU memory with this tracepoint. Second,
> > we implement eBPF programs and attach to this tracepoint for tracking
> > GPU memory at runtime on production devices. However, the tracepoint +
> > eBPF approach requires the tracepoint to be upstreamed so that it's
> > considered a stable interface which Android common kernel can carry it
> > forever.
>
>
> Then it needs to live in the drivers/gpu directory. kernel/trace is for
> tracing infrastructure and not for adding trace points.
>
> -- Steve
next prev parent reply other threads:[~2020-02-12 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 1:16 [PATCH] Add gpu memory tracepoints zzyiwei
2020-02-11 1:17 ` Yiwei Zhang
2020-02-11 1:22 ` Yiwei Zhang
2020-02-11 2:19 ` Steven Rostedt
2020-02-11 3:05 ` Yiwei Zhang
2020-02-11 3:15 ` Steven Rostedt
2020-02-12 19:26 ` Yiwei Zhang [this message]
2020-02-12 19:37 ` Steven Rostedt
2020-02-12 19:40 ` Yiwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKT=dDk+CiMQ_-f6Daa_ea2FOW=De6PKmcyiGrm4KEkVbH2fDQ@mail.gmail.com' \
--to=zzyiwei@google.com \
--cc=android-kernel@google.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=prahladk@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.