From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058Ab1IWFwM (ORCPT ); Fri, 23 Sep 2011 01:52:12 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:48420 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882Ab1IWFwJ convert rfc822-to-8bit (ORCPT ); Fri, 23 Sep 2011 01:52:09 -0400 MIME-Version: 1.0 In-Reply-To: <201109221815.08891.hartleys@visionengravers.com> References: <201109221815.08891.hartleys@visionengravers.com> Date: Fri, 23 Sep 2011 11:22:08 +0530 Message-ID: Subject: Re: [PATCH] mm/page_cgroup.c: quiet sparse noise From: Balbir Singh To: H Hartley Sweeten Cc: Linux Kernel , linux-mm@kvack.org, containers@lists.linux-foundation.org, paul@paulmenage.org, lizf@cn.fujitsu.com, nishimura@mxp.nes.nec.co.jp, kamezawa.hiroyu@jp.fujitsu.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2011 at 6:45 AM, H Hartley Sweeten wrote: > Quite the sparse noise: > > warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten > Cc: Paul Menage > Cc: Li Zefan > Cc: Balbir Singh > Cc: Daisuke Nishimura > Cc: KAMEZAWA Hiroyuki > > --- > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 6bdc67d..eead840 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -357,7 +357,7 @@ struct swap_cgroup_ctrl { >        spinlock_t      lock; >  }; > > -struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; > +static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; Seems reasonable Acked-by: Balbir Singh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id DC1CE9000BD for ; Fri, 23 Sep 2011 01:52:12 -0400 (EDT) Received: by fxh17 with SMTP id 17so4545959fxh.14 for ; Thu, 22 Sep 2011 22:52:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <201109221815.08891.hartleys@visionengravers.com> References: <201109221815.08891.hartleys@visionengravers.com> Date: Fri, 23 Sep 2011 11:22:08 +0530 Message-ID: Subject: Re: [PATCH] mm/page_cgroup.c: quiet sparse noise From: Balbir Singh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: H Hartley Sweeten Cc: Linux Kernel , linux-mm@kvack.org, containers@lists.linux-foundation.org, paul@paulmenage.org, lizf@cn.fujitsu.com, nishimura@mxp.nes.nec.co.jp, kamezawa.hiroyu@jp.fujitsu.com On Fri, Sep 23, 2011 at 6:45 AM, H Hartley Sweeten wrote: > Quite the sparse noise: > > warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static? > > Signed-off-by: H Hartley Sweeten > Cc: Paul Menage > Cc: Li Zefan > Cc: Balbir Singh > Cc: Daisuke Nishimura > Cc: KAMEZAWA Hiroyuki > > --- > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c > index 6bdc67d..eead840 100644 > --- a/mm/page_cgroup.c > +++ b/mm/page_cgroup.c > @@ -357,7 +357,7 @@ struct swap_cgroup_ctrl { > =A0 =A0 =A0 =A0spinlock_t =A0 =A0 =A0lock; > =A0}; > > -struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; > +static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES]; Seems reasonable Acked-by: Balbir Singh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org