From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v11 2/2] librte_pmd_null: Support port hotplug function Date: Thu, 26 Feb 2015 18:06:12 +0900 Message-ID: References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp> <1665241.NKrJfZ0zyg@xps13> <20150225164902.70f8abd6@urahara> <3153139.jQ5sXg5pox@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <3153139.jQ5sXg5pox@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-26 16:03 GMT+09:00 Thomas Monjalon : > 2015-02-25 16:49, Stephen Hemminger: >> Build fails if HOTPLUG is disabled Hi Stephen, I appreciate for you reporting. > > OK thanks for reporting. > Actually there is no good reason to disable hotplug on Linux. > Though it means that it's impossible to build on FreeBSD. > > Tetsuya, the right fix is to remove this option. Hi Thomas, Yes, I agree with it. I will add some codes to remove the option. Please let me have a few days, I need to prepare BSD machine for compile test. > You should manage to graceful degrades hotplug in not supported > cases supported: devices cannot be detachable in case of VFIO or nic_uio. > What about uio_pci_generic? We cannot detach a vfio device so far. But we can detach a igb_uio and uio_pci_generic device. About a vfio ddevice, I haven't checked related code yet, but I guess I will submit code to detach a vfio device in post-rc1. Thanks, Tetsuya