From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v13 1/2] ethdev: Add a new event type to
 notify a queue state changed event
Date: Mon, 21 Mar 2016 18:24:36 +0900
Message-ID: <CAKU8wkeFnPzFQSi8aAGzdHJHx6M0X8B7HJPx4+Hn7bbUitfu8w@mail.gmail.com>
References: <1458539108-15686-1-git-send-email-mukawa@igel.co.jp>
 <1458539108-15686-2-git-send-email-mukawa@igel.co.jp>
 <1523315.o3rXJh0SOG@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "dev@dpdk.org" <dev@dpdk.org>, Zhuangyanying <ann.zhuangyanying@huawei.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-io0-f170.google.com (mail-io0-f170.google.com
 [209.85.223.170]) by dpdk.org (Postfix) with ESMTP id ED4072BF5
 for <dev@dpdk.org>; Mon, 21 Mar 2016 10:24:36 +0100 (CET)
Received: by mail-io0-f170.google.com with SMTP id 124so50785546iov.3
 for <dev@dpdk.org>; Mon, 21 Mar 2016 02:24:36 -0700 (PDT)
In-Reply-To: <1523315.o3rXJh0SOG@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-21 17:37 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> 2016-03-21 14:45, Tetsuya Mukawa:
>> This event will be occured when some queues are enabled or disabled.
>> So far, only vhost PMD supports the event, and it indicates some queues
>> are enabled or disabled by virtio-net device. Such an event is needed
>> because virtio-net device may not enable all queues vhost PMD prepare.
>>
>> Because only vhost PMD uses the event so far, it isn't an actual hardware
>> interrupt but a simple software event.
> [...]
>>
>> +     RTE_ETH_EVENT_QUEUE_STATE_CHANGE,
>> +                             /**< queue state changed interrupt */
>
> Is the shorter RTE_ETH_EVENT_QUEUE_STATE descriptive enough?
>
> What about this comment?
> /**< queue state event (enabled/disabled) */

Hi Thomas,

Yes, it's enough, and above comment is nice.
Thanks for suggestion.


Hi Bruce,

If today is the deadline, could you kindly please replace above
changes while merging?
I need half a day to re-submit the patch. Sorry for asking it.
I will ask my company to let me have vpn access. ;)

Regards,
Tetsuya