From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v12 2/2] vhost: Add VHOST PMD
Date: Fri, 18 Mar 2016 22:41:35 +0900
Message-ID: <CAKU8wkfGvO2VObx70-S0nz38jqCkzCDHt2jkuinFbF=CgYhtzA@mail.gmail.com>
References: <1457316434-19128-3-git-send-email-mukawa@igel.co.jp>
 <1458030701-11487-3-git-send-email-mukawa@igel.co.jp>
 <20160318122702.GA12932@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Zhuangyanying <ann.zhuangyanying@huawei.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ig0-f182.google.com (mail-ig0-f182.google.com
 [209.85.213.182]) by dpdk.org (Postfix) with ESMTP id 9514A590B
 for <dev@dpdk.org>; Fri, 18 Mar 2016 14:41:36 +0100 (CET)
Received: by mail-ig0-f182.google.com with SMTP id av4so39023669igc.1
 for <dev@dpdk.org>; Fri, 18 Mar 2016 06:41:36 -0700 (PDT)
In-Reply-To: <20160318122702.GA12932@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016/03/18 =E5=8D=88=E5=BE=8C9:27 "Bruce Richardson" <bruce.richardson@inte=
l.com>:
>
> On Tue, Mar 15, 2016 at 05:31:41PM +0900, Tetsuya Mukawa wrote:
> > The patch introduces a new PMD. This PMD is implemented as thin wrapper
> > of librte_vhost. It means librte_vhost is also needed to compile the
PMD.
> > The vhost messages will be handled only when a port is started. So star=
t
> > a port first, then invoke QEMU.
> >
> > The PMD has 2 parameters.
> >  - iface:  The parameter is used to specify a path to connect to a
> >            virtio-net device.
> >  - queues: The parameter is used to specify the number of the queues
> >            virtio-net device has.
> >            (Default: 1)
> >
> > Here is an example.
> > $ ./testpmd -c f -n 4 --vdev 'eth_vhost0,iface=3D/tmp/sock0,queues=3D1'=
 --
-i
> >
> > To connect above testpmd, here is qemu command example.
> >
> > $ qemu-system-x86_64 \
> >         <snip>
> >         -chardev socket,id=3Dchr0,path=3D/tmp/sock0 \
> >         -netdev vhost-user,id=3Dnet0,chardev=3Dchr0,vhostforce,queues=
=3D1 \
> >         -device virtio-net-pci,netdev=3Dnet0,mq=3Don
> >
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Acked-by: Rich Lane <rich.lane@bigswitch.com>
> > Tested-by: Rich Lane <rich.lane@bigswitch.com>
>
> Hi Tetsuya,
>
> I hope to get this set merged for RC2 very soon. Can you provide an
update for
> the nic overview.rst doc listing out the features of this new PMD. If you
want,
> you can provide it as a separate patch, that I will merge into this one
for you
> on apply to next-net.
>
> If you do decide to respin this patchset with the extra doc, please take
into
> account the following patchwork issues also - otherwise I'll also fix
them on
> apply:
>
> WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should
probably be static const char * const
> #364: FILE: drivers/net/vhost/rte_eth_vhost.c:56:
> +static const char *valid_arguments[] =3D {
>
> WARNING:LINE_SPACING: Missing a blank line after declarations
> #399: FILE: drivers/net/vhost/rte_eth_vhost.c:91:
> +       char *iface_name;
> +       volatile uint16_t once;
>
> WARNING:TYPO_SPELLING: 'Unknow' may be misspelled - perhaps 'Unknown'?
> #684: FILE: drivers/net/vhost/rte_eth_vhost.c:376:
> +               RTE_LOG(ERR, PMD, "Unknow numa node\n");
>
> Regards,
> /Bruce
>

Hi Bruce,

I've sent the v12 patch with vhost.rst.
Could you please check below?

http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=3D64

Is this the documentation I need to add?

Anyway, it contains above nits. So could you please fix it before merging,
if it's the documentation?

Regards,
Tetsuya