From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49844)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christopher.covington@linaro.org>)
	id 1YgGAy-0002Fu-6k
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 13:23:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christopher.covington@linaro.org>)
	id 1YgGAv-0000bJ-2U
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 13:23:36 -0400
Received: from mail-la0-f49.google.com ([209.85.215.49]:34733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christopher.covington@linaro.org>)
	id 1YgGAu-0000ae-Pt
	for qemu-devel@nongnu.org; Thu, 09 Apr 2015 13:23:33 -0400
Received: by laat2 with SMTP id t2so87642843laa.1
	for <qemu-devel@nongnu.org>; Thu, 09 Apr 2015 10:23:30 -0700 (PDT)
MIME-Version: 1.0
Date: Thu, 9 Apr 2015 13:23:30 -0400
Message-ID: <CAKU=YwX94CozCUsADgYPB6Jy=NAeiC23w=vDB-64kPPxdiJ2Ug@mail.gmail.com>
From: Christopher Covington <christopher.covington@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 3/3] arm: semihosting: Wire up A64 HLT
	0xf000
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Liviu Ionescu <ilg@livius.net>, QEMU Developers <qemu-devel@nongnu.org>

Hi Peter,

On Fri, Mar 27, 2015 at 12:40 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:

>> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
>> index 0b192a1..3b5b875 100644
>> --- a/target-arm/translate-a64.c
>> +++ b/target-arm/translate-a64.c
>> @@ -1544,7 +1544,11 @@ static void disas_exc(DisasContext *s, uint32_t insn)
>>              break;
>>          }
>>          /* HLT */
>> -        unsupported_encoding(s, insn);
>> +        if (imm16 == 0xf000) {
>
> You need to have the semihosting_enabled check here rather
> than in the do_interrupt code, because otherwise we won't
> behave correctly in the disabled case.

Do you have suggestions for getting semihosting_enabled defined in
translate-a64.c? I'm likely doing something dumb, but while #include
"sysemu/sysemu.h" at first seemed like the obvious approach, and
appears to work for -softmmu, I'm getting errors with that when
building -linux-user.

Thanks,
Chris