All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramji Jiyani <ramjiyani@google.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	kernel-team@android.com, linux-aio@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org
Subject: Re: [RESEND PATCH] aio: Add support for the POLLFREE
Date: Tue, 5 Oct 2021 12:46:36 -0700	[thread overview]
Message-ID: <CAKUd0B_vh5gxsjHVAoC4YTpwUA8vj6qKovza8OM391koM2t+hQ@mail.gmail.com> (raw)
In-Reply-To: <x49ilybjmdt.fsf@segfault.boston.devel.redhat.com>

Hi Jeff:

On Tue, Oct 5, 2021 at 12:33 PM Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Hi, Ramji,
>
> Thanks for the explanation of the use after free.  I went ahead and
> ran the patch through the libaio test suite and it passed.
>

Thanks for taking time to test and providing feedback.

> > -#define POLLFREE     (__force __poll_t)0x4000        /* currently only for epoll */
> > +#define POLLFREE     ((__force __poll_t)0x4000)
>
> You added parenthesis, here, and I'm not sure if that's a necessary part
> of this patch.

I added parenthesis to silence the checkpatch script. Should I just ignore it?
I'll send v2 with the change, if it is required.

>
> Other than that:
>
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>
Thanks,
Ramji

  reply	other threads:[~2021-10-05 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 19:45 [RESEND PATCH] aio: Add support for the POLLFREE Ramji Jiyani
2021-10-05 19:35 ` Jeff Moyer
2021-10-05 19:46   ` Ramji Jiyani [this message]
2021-10-05 19:56     ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKUd0B_vh5gxsjHVAoC4YTpwUA8vj6qKovza8OM391koM2t+hQ@mail.gmail.com \
    --to=ramjiyani@google.com \
    --cc=arnd@arndb.de \
    --cc=bcrl@kvack.org \
    --cc=jmoyer@redhat.com \
    --cc=kernel-team@android.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.