From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06AECC4338F for ; Wed, 11 Aug 2021 09:46:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 124E960F21 for ; Wed, 11 Aug 2021 09:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 124E960F21 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F8BE82C55; Wed, 11 Aug 2021 11:46:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B0BA182C55; Wed, 11 Aug 2021 11:46:14 +0200 (CEST) Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B28680C68 for ; Wed, 11 Aug 2021 11:46:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@gmail.com Received: by mail-il1-f177.google.com with SMTP id y3so2169298ilm.6 for ; Wed, 11 Aug 2021 02:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VqW/iPpyG0jN3u1/12HMKn8tYMqWK/l84Zfuo169DTM=; b=AlrEc8/mhO2jOOypFuotQztGpcUY1guDTu3Yjl4QS5O1SKHLgkIGpcg4Aja6ypQDPI 1QDR+1U8HTItQttcEGXyAakWumWq1Ae6evPJfKjV8D8TtZAjKNmGaZs+vSNJFb+EZ+Tz p4RKlzB/srYacKxl83j60JPvqddzhskd15tVAxFJs1ejb7haq+4ls7NKXdp5u2CCfWv7 z8nJ2nzxwTr82TEhA58OdFGUyPrTchml7Iiu8n2KVJulG7JLrKYQ9bpBrGKA8yg79uEt MJ+8/B8sdIfzHOg+Wa3dSImZ2IGANiotNN4g4nbOQR7k4Vjo+Ma3ZcIk84b60mp+ei79 3FJg== X-Gm-Message-State: AOAM530haHqH+21iH256r2LNibAkmxT8BEEOyoa6iWEbHnI8oSXtYVDu MKxke7lfSrct0eXKGmcB0jB1L0Hpamg5FGE5hcU= X-Google-Smtp-Source: ABdhPJx2LjGxmt0TtdS1lPWMCtXl9hOJ1STcoG7KOPRbiOyGCPlMfoaqzNcUN9i2riKUx456UUoEIuTcjIsxLkkp54A= X-Received: by 2002:a05:6e02:611:: with SMTP id t17mr49711ils.216.1628675160577; Wed, 11 Aug 2021 02:46:00 -0700 (PDT) MIME-Version: 1.0 References: <20210526093227.273974-1-art@khadas.com> In-Reply-To: <20210526093227.273974-1-art@khadas.com> From: Kever Yang Date: Wed, 11 Aug 2021 17:45:49 +0800 Message-ID: Subject: Re: [PATCH] rk3399: boot_devices fix spinor node name To: Artem Lapkin Cc: Kever Yang , Simon Glass , Philipp Tomsich , Jagan Teki , sunil@amarulasolutions.com, U-Boot-Denx , art@khadas.com, Nick Xie , gouwa@khadas.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Artem Lapkin =E4=BA=8E2021=E5=B9=B45=E6=9C=8826=E6= =97=A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=885:33=E5=86=99=E9=81=93=EF=BC=9A > > Problem: board_spl_was_booted_from return wrong boot_devices[3] value > /spi@ff1d0000 and same-as-spl dont work properly for SPINOR flash > because arch/arm/mach-rockchip/spl-boot-order.c spl_node_to_boot_device > need parse SPINOR flash node as UCLASS_SPI_FLASH > > spl-boot-order: same-as-spl > *** BOOT_SOURCE_ID 3 (2:emmc 3:spi 5:sd ... > /spi@ff1d0000 > board_boot_order: could not map node @618 to a boot-devic= e > /sdhci@fe330000 > /mmc@fe320000 > > Solution: just change it to /spi@ff1d0000/flash@0 > > spl-boot-order: same-as-spl > *** BOOT_SOURCE_ID 3 (2:emmc 3:spi 5:sd ... > /spi@ff1d0000/flash@0 > /sdhci@fe330000 > /mmc@fe320000 > > Signed-off-by: Artem Lapkin Reviewed-by: Kever Yang Thanks, - Kever > --- > arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockc= hip/rk3399/rk3399.c > index 869d2159..69e0c8c2 100644 > --- a/arch/arm/mach-rockchip/rk3399/rk3399.c > +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c > @@ -28,7 +28,7 @@ DECLARE_GLOBAL_DATA_PTR; > > const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] =3D { > [BROM_BOOTSOURCE_EMMC] =3D "/sdhci@fe330000", > - [BROM_BOOTSOURCE_SPINOR] =3D "/spi@ff1d0000", > + [BROM_BOOTSOURCE_SPINOR] =3D "/spi@ff1d0000/flash@0", > [BROM_BOOTSOURCE_SD] =3D "/mmc@fe320000", > }; > > -- > 2.25.1 >