From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kever Yang <kever.yang@rock-chips.com>
Date: Thu, 21 Jan 2021 21:06:26 +0800
Subject: [patch v3 4/9] ockchip: video: vop: Reserve efi fb memory
In-Reply-To: <20201120132823.799855386@rtp-net.org>
References: <20201120132421.500365403@rtp-net.org>
 <20201120132823.799855386@rtp-net.org>
Message-ID: <CAKUh=RziGF1paPFuZUmpZetKSY6qkSjsU_WtgywqeKzHahm27Q@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Arnaud,

First, please correct the typo in the subject line.

Arnaud Patard <arnaud.patard@rtp-net.org> ?2020?11?20??? ??9:31???

> When booting with EFI and graphics, the memory used for framebuffer
> has to be reserved, otherwise it may leads to kernel memory
> overwrite.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> Index: u-boot/drivers/video/rockchip/rk_vop.c
> ===================================================================
> --- u-boot.orig/drivers/video/rockchip/rk_vop.c
> +++ u-boot/drivers/video/rockchip/rk_vop.c
> @@ -20,6 +20,8 @@
>  #include <asm/arch-rockchip/vop_rk3288.h>
>  #include <dm/device-internal.h>
>  #include <dm/uclass-internal.h>
> +#include <efi.h>
> +#include <efi_loader.h>
>  #include <linux/bitops.h>
>  #include <linux/err.h>
>  #include <power/regulator.h>
> @@ -394,6 +396,13 @@ int rk_vop_probe(struct udevice *dev)
>         if (!(gd->flags & GD_FLG_RELOC))
>                 return 0;
>
> +       plat->base = gd->bd->bi_dram[0].start + gd->bd->bi_dram[0].size -
> plat->size;
>
This is a change to plat->base value, do we have to do this?
If we have to use this address for EFI, I would like this code not to
change for board
without EFI_LOADER support.

Thanks,
- Kever

> +
> +#if defined(CONFIG_EFI_LOADER)
> +       debug("Adding to EFI map %d @ %lx\n", plat->size, plat->base);
> +       efi_add_memory_map(plat->base, plat->size,
> EFI_RESERVED_MEMORY_TYPE);
> +#endif
> +
>         priv->regs = (struct rk3288_vop *)dev_read_addr(dev);
>
>         /*
>
>
>