From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 60703E009D9; Mon, 16 Nov 2015 10:40:57 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (avery.brian[at]gmail.com) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.213.179 listed in list.dnswl.org] Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 297B9E0071C for ; Mon, 16 Nov 2015 10:40:52 -0800 (PST) Received: by igbxm8 with SMTP id xm8so63756939igb.1 for ; Mon, 16 Nov 2015 10:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=30oy8pwq8Z1nETEIFLqA5fBu+OPzDq/c7r94EROI6H8=; b=YAdpdvJnEd89YQw2GKFxZJM14EPPYEFX7UrtmtKQMV9Duhfu3aDGXclN2Z3LlHlujs KyBPubO+Vbksks9sJpbXTOQkasL9yTBUfKcToTLWO0tpHY2XRk426l53dBZvzq/TMDiU xYo6Xf0MQ5tdgJpnhZ2d5oFK30SJnDOsNAFEFzHrztEFz5frvEnq/Fg9jcUlFISwLT2P dIT1wWdW1sg247aQGVHtSQumTv+erB0htU0jpfzyLGaQkcPWlX0EvSxAjgMNi8aTJqZV qscyfcBWtd089zcmdEdkmicKUnz6jmzX9bmXY/3wam74Z7g1LjVeOtAEPT4wvh0x3TMB pcVQ== MIME-Version: 1.0 X-Received: by 10.50.119.74 with SMTP id ks10mr1687925igb.41.1447699252296; Mon, 16 Nov 2015 10:40:52 -0800 (PST) Received: by 10.64.221.74 with HTTP; Mon, 16 Nov 2015 10:40:52 -0800 (PST) In-Reply-To: References: Date: Mon, 16 Nov 2015 10:40:52 -0800 Message-ID: From: Brian Avery To: Ed Bartosh Cc: toaster@yoctoproject.org Subject: Re: [PATCH v4 00/26] toaster: 8279: Provide a single way of starting Toaster X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2015 18:40:57 -0000 Content-Type: text/plain; charset=UTF-8 Hi, I *finally* had a chance to play with your branch and had a couple of comments. sorry for the delay :(. I had 2 biggish issues, and a couple of middling issues. I'll put them in the bugzilla comments for 8279 (https://bugzilla.yoctoproject.org/show_bug.cgi?id=8279) so we don't lose track. Ty for all the hard work!!! -b On Thu, Nov 12, 2015 at 4:04 AM, Ed Bartosh wrote: > Hi, > > This patchset merges two Toaster modes in one: > > To run toaster you should source it in already prepared build environment: > cd poky > . oe-init-build-env > . ../bitbake/bin/toaster > > After that you should be able to trigger builds both ways: > from command line and from toaster UI. > > Please review and test. > > Changes in v4: Removed buildinfohelper code which was trying to guess layer > version of the recipe. As a result of this bug Toaster > UI was not showing any information about recipes. > > The following changes since commit aa7690e182c9c307785e6e9679f3490583176421: > > toaster: builds pages Fix the download cooker log link (2015-11-10 17:04:19 +0000) > > are available in the git repository at: > > git://git.yoctoproject.org/poky-contrib ed/toaster/8279-v4 > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/8279-v4 > > Ed Bartosh (25): > toaster: don't allow to run toaster as a script > toaster: implement get-dburl command > toaster: set DATABASE_URL in toaster script > toaster: run bitbake the same way > toaster: remove unused variable > toaster: check for toaster configuration later > toaster: use parent of the build dir > toaster: make runbuilds to loop > toaster: start 'manage.py runbuilds' in the script > toaster: update brbe and project attributes > toaster: implement stop_bitbake function > toaster: implement start_bitbake function > toaster: implement 'toaster restart-bitbake' > toaster: remove _setupBE function > toaster: reimplemented startBBServer method > toaster: remove stopBBServer API > toaster: do not terminate bb server > toaster: remove usage of BUILD_MODE variable > toaster: do not create duplicate HelpText objects > toaster: implement BitbakeController.getVariable > toaster: set varibales on bitbake server > toaster: remove writeConfFile API > toaster: stop using toaster-pre.conf > toaster: remove SDKMACHINE from project variables > toaster: get rid of complicated heuristics > > Michael Wood (1): > toaster: buildinfohelper Broaden the toaster created recipe data case > > bitbake/bin/toaster | 186 +++++++-------------- > bitbake/lib/bb/ui/buildinfohelper.py | 68 +++----- > bitbake/lib/bb/ui/toasterui.py | 14 +- > bitbake/lib/toaster/bldcontrol/bbcontroller.py | 15 +- > .../toaster/bldcontrol/localhostbecontroller.py | 132 ++++----------- > .../bldcontrol/management/commands/runbuilds.py | 13 +- > bitbake/lib/toaster/bldcontrol/sshbecontroller.py | 10 -- > bitbake/lib/toaster/bldcontrol/tests.py | 4 - > bitbake/lib/toaster/toastergui/templates/base.html | 13 +- > .../lib/toaster/toastergui/templates/landing.html | 10 -- > .../toaster/toastergui/templates/projectconf.html | 70 +------- > bitbake/lib/toaster/toastergui/tests.py | 4 - > bitbake/lib/toaster/toastergui/views.py | 29 ---- > .../toastermain/management/commands/get-dburl.py | 9 + > bitbake/lib/toaster/toastermain/settings.py | 3 - > bitbake/lib/toaster/toastermain/urls.py | 9 +- > 16 files changed, 150 insertions(+), 439 deletions(-) > create mode 100644 bitbake/lib/toaster/toastermain/management/commands/get-dburl.py > > -- > Regards, > Ed > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster