From: Brian Avery <avery.brian@gmail.com>
To: sujith h <sujith.h@gmail.com>
Cc: toaster@yoctoproject.org
Subject: Re: [review-request][PATCH 0/3] remove ssh build controller
Date: Wed, 3 Feb 2016 08:13:29 -0800 [thread overview]
Message-ID: <CAKV_0ejKAw5+vwbDQ6kLNUx+4CnAEH8ccHApZbuTBJrAFyotsg@mail.gmail.com> (raw)
In-Reply-To: <CADyYWLkz0x=4u_7sRmp0LH2PUmgO9pcGxwPmimzWoQvxPEdb4Q@mail.gmail.com>
Hi,
I looked at this while I was in Atlanta. I had no problems with it but
I tend to agree with elliot that I'd prefer to not let it get in
michael's way for ic, so we should probably pend it til ic get's in.
-b
On Wed, Feb 3, 2016 at 6:25 AM, sujith h <sujith.h@gmail.com> wrote:
>
>
> On Wed, Jan 20, 2016 at 5:20 PM, Ed Bartosh <ed.bartosh@linux.intel.com>
> wrote:
>>
>> Hi,
>>
>> sshbecontroller code and tests are broken for months. Its
>> functionality(running
>> builds on remote machine) can be achieved by simply running manage.py
>> runbuilds
>> on remote machine. There is not need to keep it in the codebase and
>> confuse
>> users from my point of view.
>
>
> It did confuse me :)
>
>>
>>
>> This change would also make refactoring of buildcontroller code
>> [YOCTO #8806] easier.
>>
>> The following changes since commit
>> c113ef1e40b9a5007c6b6af53226389fea706094:
>>
>> toaster: tests Remove symlinks from toasteruitest folder (2016-01-20
>> 12:07:44 +0200)
>>
>> are available in the git repository at:
>>
>> git://git.yoctoproject.org/poky-contrib ed/toaster/remove-ssh-controller
>>
>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove-ssh-controller
>>
>> Ed Bartosh (3):
>> toaster: raise NotImplementedError
>> toaster: don't use sshbecontroller
>> toaster: remove sshbecontroller module
>>
>> bitbake/lib/toaster/bldcontrol/bbcontroller.py | 16 +-
>> .../migrations/0002_auto_20160120_1250.py | 19 +++
>> bitbake/lib/toaster/bldcontrol/models.py | 10 +-
>> bitbake/lib/toaster/bldcontrol/sshbecontroller.py | 169
>> ---------------------
>> bitbake/lib/toaster/bldcontrol/tests.py | 30 +---
>> 5 files changed, 32 insertions(+), 212 deletions(-)
>> create mode 100644
>> bitbake/lib/toaster/bldcontrol/migrations/0002_auto_20160120_1250.py
>> delete mode 100644 bitbake/lib/toaster/bldcontrol/sshbecontroller.py
>>
>> --
>> Regards,
>> Ed
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
>
>
>
>
> --
> സുജിത് ഹരിദാസന്
> Bangalore
> <Project>Contributor to KDE project
> http://fci.wikia.com/wiki/Anti-DRM-Campaign
> <Blog> http://sujithh.info
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
prev parent reply other threads:[~2016-02-03 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 11:50 [review-request][PATCH 0/3] remove ssh build controller Ed Bartosh
2016-01-20 11:50 ` [review-request][PATCH 1/3] toaster: raise NotImplementedError Ed Bartosh
2016-01-20 11:50 ` [review-request][PATCH 2/3] toaster: don't use sshbecontroller Ed Bartosh
2016-01-20 11:50 ` [review-request][PATCH 3/3] toaster: remove sshbecontroller module Ed Bartosh
2016-02-03 14:10 ` [review-request][PATCH 0/3] remove ssh build controller Smith, Elliot
2016-02-03 14:25 ` sujith h
2016-02-03 16:13 ` Brian Avery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKV_0ejKAw5+vwbDQ6kLNUx+4CnAEH8ccHApZbuTBJrAFyotsg@mail.gmail.com \
--to=avery.brian@gmail.com \
--cc=sujith.h@gmail.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.