All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinayak holikatti <vinholikatti@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: James.Bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@linaro.org, linux-samsung-soc@vger.kernel.org,
	santoshsy@gmail.com, arnd@linaro.org,
	girish.shivananjappa@linaro.org, saugata.das@linaro.org,
	vishak.g@samsung.com, venkat@linaro.org, k.rajesh@samsung.com,
	yejin.moon@samsung.com, dsaxena@linaro.org,
	ilho215.lee@samsung.com, nala.la@samsung.com,
	stephen.doel@linaro.org, sreekumar.c@samsung.com
Subject: Re: [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd
Date: Wed, 11 Jul 2012 09:41:15 +0530	[thread overview]
Message-ID: <CAKVbJB8KTj85_bus9NF8OMtHKDZAaDpGv1GV1FP30=H42DWwbg@mail.gmail.com> (raw)
In-Reply-To: <201207021517.31537.arnd@arndb.de>

On Mon, Jul 2, 2012 at 8:47 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Monday 02 July 2012, Vinayak Holikatti wrote:
>>
>> This patch separates PCI and core UFS host controller driver.
>> In the current implementation PCI specific code is with ufshcd.c.
>> To provide way for adding multiple bus glue driver, this patch
>> separates PCI layer from ufshcd core. Now ufshcd compiles as separate
>> module and ufshcd-pci as separate module.
>>
>> Signed-off-by: Vinayak Holikatti <vinholikatti@gmail.com>
>> Signed-off-by: Santosh Yaraganavi <santoshsy@gmail.com>
>
> Hi Vinayak,
>
> This patch looks good at first sight, but it's a little hard to
> review in the form that you are posting.
>
> I would recommend that you split this patch into two separate
> changesets, where you do all the changes to existing code in the
> first patch, and only move but don't change code in the second one
> that creates the new file.
 Ok, will spilt accordinglly to make it two changesets.
>
>         Arnd

  reply	other threads:[~2012-07-11  4:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02 14:32 [PATCH 0/4] ufshcd: Adds glue drivers to ufshcd Vinayak Holikatti
2012-07-02 14:32 ` [PATCH 1/4] [SCSI] ufs: Separate PCI glue driver for ufshcd Vinayak Holikatti
2012-07-02 15:17   ` Arnd Bergmann
2012-07-11  4:11     ` vinayak holikatti [this message]
2012-07-02 14:32 ` [PATCH 2/4] [SCSI] ufs: Add Platform " Vinayak Holikatti
2012-07-02 15:27   ` Arnd Bergmann
2012-07-11  4:14     ` vinayak holikatti
2012-07-02 14:32 ` [PATCH 3/4] [SCSI] ufs: Add AMBA glue driver to ufshcd Vinayak Holikatti
2012-07-02 15:20   ` Arnd Bergmann
2012-07-11  4:20     ` vinayak holikatti
2012-07-02 14:32 ` [PATCH 4/4] [SCSI] ufs: Correct the expected data transfer size in UPIU Vinayak Holikatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKVbJB8KTj85_bus9NF8OMtHKDZAaDpGv1GV1FP30=H42DWwbg@mail.gmail.com' \
    --to=vinholikatti@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=arnd@arndb.de \
    --cc=arnd@linaro.org \
    --cc=dsaxena@linaro.org \
    --cc=girish.shivananjappa@linaro.org \
    --cc=ilho215.lee@samsung.com \
    --cc=k.rajesh@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nala.la@samsung.com \
    --cc=patches@linaro.org \
    --cc=santoshsy@gmail.com \
    --cc=saugata.das@linaro.org \
    --cc=sreekumar.c@samsung.com \
    --cc=stephen.doel@linaro.org \
    --cc=venkat@linaro.org \
    --cc=vishak.g@samsung.com \
    --cc=yejin.moon@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.