From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757687AbbA2WEw (ORCPT ); Thu, 29 Jan 2015 17:04:52 -0500 Received: from mail-ie0-f176.google.com ([209.85.223.176]:56789 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751864AbbA2WEv (ORCPT ); Thu, 29 Jan 2015 17:04:51 -0500 MIME-Version: 1.0 In-Reply-To: <54CA4309.4050807@mev.co.uk> References: <1422484546-9045-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <54CA4309.4050807@mev.co.uk> Date: Thu, 29 Jan 2015 23:04:49 +0100 Message-ID: Subject: Re: [PATCH] staging: comedi: drivers: jr3_pci: Removed variables that is never used From: Rickard Strandqvist To: Ian Abbott Cc: H Hartley Sweeten , Greg Kroah-Hartman , "Vladimir A. Nazarenko" , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-01-29 15:26 GMT+01:00 Ian Abbott : > On 28/01/15 22:35, Rickard Strandqvist wrote: >> >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> >> --- >> drivers/staging/comedi/drivers/jr3_pci.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/jr3_pci.c >> b/drivers/staging/comedi/drivers/jr3_pci.c >> index 81fab2d..5d4cca7 100644 >> --- a/drivers/staging/comedi/drivers/jr3_pci.c >> +++ b/drivers/staging/comedi/drivers/jr3_pci.c >> @@ -520,10 +520,9 @@ static struct jr3_pci_poll_delay >> jr3_pci_poll_subdevice(struct comedi_subdevice >> result = poll_delay_min_max(20, 100); >> } else { >> /* Set full scale */ >> - struct six_axis_t min_full_scale; >> struct six_axis_t max_full_scale; >> >> - min_full_scale = get_min_full_scales(channel); >> + get_min_full_scales(channel); >> max_full_scale = get_max_full_scales(channel); >> set_full_scales(channel, max_full_scale); >> >> > > Yes, it doesn't appear to be needed. The driver used to have some kernel > logs that output the min and max full scale information, but it didn't do > anything else with min_full_scale. > > The call to get_min_full_scales() and the function itself can also be > removed. > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: )=- > -=( Web: http://www.mev.co.uk/ )=- Hi Ok good, new patch on the way! Kind regards Rickard Strandqvist