From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967022AbbBDRqh (ORCPT ); Wed, 4 Feb 2015 12:46:37 -0500 Received: from mail-ie0-f182.google.com ([209.85.223.182]:35177 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966663AbbBDRqg (ORCPT ); Wed, 4 Feb 2015 12:46:36 -0500 MIME-Version: 1.0 In-Reply-To: <20150202163633.GA30631@sudip-PC> References: <1422557170-3357-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150202163633.GA30631@sudip-PC> Date: Wed, 4 Feb 2015 18:46:34 +0100 Message-ID: Subject: Re: [PATCH] staging: gdm724x: gdm_tty: Fix for possible null pointer dereference From: Rickard Strandqvist To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Kiran Padwal , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-02-02 17:36 GMT+01:00 Sudip Mukherjee : > On Thu, Jan 29, 2015 at 07:46:10PM +0100, Rickard Strandqvist wrote: >> Fix a possible null pointer dereference, there is >> otherwise a risk of a possible null pointer dereference. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> --- >> drivers/staging/gdm724x/gdm_tty.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c >> index 001348c..66b356e 100644 >> --- a/drivers/staging/gdm724x/gdm_tty.c >> +++ b/drivers/staging/gdm724x/gdm_tty.c >> @@ -145,7 +145,7 @@ static int gdm_tty_recv_complete(void *data, >> struct gdm *gdm = tty_dev->gdm[index]; >> >> if (!GDM_TTY_READY(gdm)) { >> - if (complete == RECV_PACKET_PROCESS_COMPLETE) >> + if (gdm && complete == RECV_PACKET_PROCESS_COMPLETE) > GDM_TTY_READY() is already checking for gdm, there is no chance that gdm can be null at this point. so this additional check is not required. > > regards > sudip >> gdm_tty_recv(gdm, gdm_tty_recv_complete); >> return TO_HOST_PORT_CLOSE; >> } >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ Hi Sudip Yes, GDM_TTY_READY checks gdm, but this is a if(! ) Kind regards Rickard Strandqvist