From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1B9C2D0E4 for ; Fri, 20 Nov 2020 20:23:45 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FFFB206FB for ; Fri, 20 Nov 2020 20:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ebm12I60" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FFFB206FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id BC67886D90; Fri, 20 Nov 2020 20:23:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mMk76KeFlxCk; Fri, 20 Nov 2020 20:23:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id CBD5E86E08; Fri, 20 Nov 2020 20:23:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A461FC163C; Fri, 20 Nov 2020 20:23:42 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B4B5EC0891 for ; Fri, 20 Nov 2020 20:23:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9A99486FE2 for ; Fri, 20 Nov 2020 20:23:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H_xhNykG2hbe for ; Fri, 20 Nov 2020 20:23:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 6E0A086F60 for ; Fri, 20 Nov 2020 20:23:39 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id a19so3891769ilm.3 for ; Fri, 20 Nov 2020 12:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sfZER4e5robAXE2gIOgmf6q0oty8pze3I0iBSLjZIy4=; b=Ebm12I60nrcJKFEy4le+9tQkv9Xd8tidnfRS7TuWFMpj+CzmyECFo3/zdClwbhvvwE 8PiQC7Lk7nNPWBipDdDMp9YcoY79gX57Z3nWceGQTrtQ4prNkSRVsFlaBydwKWuJMAmY KtK9Mn4xM/gXiNn8N2d9uNAGIkDYNjEJsur4I8SspHYVc8opXqj7jjcZmoPotBAD4mho 9Uzk0ITTFDKxI9lombBkswrLqPxnSGPM5rn01K1D3bdG/Q6/RD+JRQzg+ahr7ja5uCmO nzZ5o03jW0N5m9AgizSz+ZFJWDI3SJV2HWAd1gvG5J6uvSOlSQmKl1C2vtsOPryht6Qf 9gMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sfZER4e5robAXE2gIOgmf6q0oty8pze3I0iBSLjZIy4=; b=dyclNzFJrHQf2cjj4ZK+y/11IvGQz/ZKSAHqHDdN1rAmaX0kqC2UtK1SMDcgiYaDkM PO93zaTkgIlCYHUdUzH41l8HroQlU6v+mkZCbujwQTEYSEG90YE3BtcUMOBMqg4O9fu0 89e7mkxMiukvRNY71KMQfExWCkqRPu7wpnpWo0Quwm+r8HPcEmrOtkqSF9xnwM07b0+b /yB1+PxuRrEKlVUZbk9zfMhk96e0KTiKvGmadsnKkqhuUdP+6pefChzOGeQmATR00tcd PObtp+YJE2iMYyezXdb7IO6y3FTMyiFvbmLqEcqiVuYCRb/2gYdOpiDDqeO531jIa4Sb NOZw== X-Gm-Message-State: AOAM533j0xdPO/jFK1s9t74pjKrFnrh+2sKNWwZqEiwy4eaOq4ecgt4j DyqBtJJOSWWcPGD1c1RfKgmT/4UF2FGvxZst5iM= X-Google-Smtp-Source: ABdhPJw0+jWFEnad+IltPWbPAgsc4Z1FNN8BYI2+X2DqeH8k5zHniQO0LM2atLOOs5cIXZozO+Y1Zu3TrYp3LGaVQoc= X-Received: by 2002:a92:aacc:: with SMTP id p73mr10764494ill.64.1605903818647; Fri, 20 Nov 2020 12:23:38 -0800 (PST) MIME-Version: 1.0 References: <20201120195851.23679-1-yashsri421@gmail.com> <3fbf54ea-20f4-8e80-2bfd-363e9cec6619@gmail.com> In-Reply-To: <3fbf54ea-20f4-8e80-2bfd-363e9cec6619@gmail.com> From: Lukas Bulwahn Date: Fri, 20 Nov 2020 21:23:25 +0100 Message-ID: To: Aditya Cc: linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: add fix and improve warning msg for Non-standard signature X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7952846940217841658==" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" --===============7952846940217841658== Content-Type: multipart/alternative; boundary="000000000000a76c2705b48f9ef5" --000000000000a76c2705b48f9ef5 Content-Type: text/plain; charset="UTF-8" On Fr., 20. Nov. 2020 at 21:03, Aditya wrote: > On 21/11/20 1:28 am, Aditya Srivastava wrote: > > Checkpatch.pl warns on non-standard signature styles. > > > > E.g., running checkpatch on commit 513f7f747e1c ("parisc: Fix vmap > > memory leak in ioremap()/iounmap()") reports this warning: > > > > WARNING: Non-standard signature: Noticed-by: > > Noticed-by: Sven Schnelle > > This example really does not tell anyone much. Replace it with a summary from your evaluation. > > Provide a fix by: > > 1) replacing the non-standard signature with its standard equivalent > > 2) removing the signature if it is not required > > > > Also, improve warning messages correspondingly, providing users > > suggestions to either replace or remove the signature > > Looks good. > > Signed-off-by: Aditya Srivastava > > --- > > scripts/checkpatch.pl | 45 +++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 43 insertions(+), 2 deletions(-) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index fdfd5ec09be6..23a21dc2c29a 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -506,6 +506,27 @@ our $signature_tags = qr{(?xi: > > Cc: > > )}; > > > > +our %standard_signature_fix = ( > > + "Requested-by:" => "Suggested-by:", > > + "Co-authored-by:" => "Co-developed-by:", > > + "Analyzed-by:" => "Co-developed-by:", > > + "Analysed-by:" => "Co-developed-by:", > > + "Improvements-by:" => "Co-developed-by:", > > + "Noticed-by:" => "Reported-by:", > > + "Inspired-by:" => "Suggested-by:", > > + "Verified-by:" => "Tested-by:", > > + "Okay-ished-by:" => "Acked-by:", > > + "Acked-for-MFD-by:" => "Acked-by:", > > + "Reviewed-off-by:" => "Reviewed-by:", > > + "Proposed-by:" => "Suggested-by:", > > + "Fixed-by:" => "Co-developed-by:", > > + "Pointed-out-by:" => "Suggested-by:", > > + "Pointed-at-by:" => "Suggested-by:", > > + "Suggestions-by:" => "Suggested-by:", > > + "Generated-by:" => "remove", > > + "Celebrated-by:" => "remove", > > +); > > + How did create this list? I thought we looked at 30 cases... > > our @typeListMisordered = ( > > qr{char\s+(?:un)?signed}, > > qr{int\s+(?:(?:un)?signed\s+)?short\s}, > > @@ -2773,8 +2794,28 @@ sub process { > > my $ucfirst_sign_off = ucfirst(lc($sign_off)); > > > > if ($sign_off !~ /$signature_tags/) { > > - WARN("BAD_SIGN_OFF", > > - "Non-standard signature: $sign_off\n" > . $herecurr); > > + my $suggested_signature = ""; > > + if > (exists($standard_signature_fix{$sign_off})) { > > + $suggested_signature = > $standard_signature_fix{$sign_off}; > > + } > > + if ($suggested_signature eq "") { > > + WARN("BAD_SIGN_OFF", > > + "Non-standard signature: > $sign_off\n" . $herecurr); > > + } > > + elsif ($suggested_signature eq "remove") { > > + if (WARN("BAD_SIGN_OFF", > > + "Non-standard signature: > $sign_off. Please consider removing this signature tag.\n" . $herecurr) && > > + $fix) { > > + > fix_delete_line($fixlinenr, $rawline); > > + } > > + } > > + else { > > + if (WARN("BAD_SIGN_OFF", > > + "Non-standard signature: > $sign_off. Please use '$suggested_signature' instead.\n" . $herecurr) && > > + $fix) { > > + $fixed[$fixlinenr] =~ > s/$sign_off/$suggested_signature/; > > + } > > + } > > } > > if (defined $space_before && $space_before ne "") { > > if (WARN("BAD_SIGN_OFF", > > > > Initial tests performed on patches found this fix to be working as > expected. > > Thanks > Aditya > --000000000000a76c2705b48f9ef5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fr.= , 20. Nov. 2020 at 21:03, Aditya <yashsri421@gmail.com> wrote:
On 21/11/20 1:28 am, Aditya Srivastava wrote:
> Checkpatch.pl warns on non-standard signature styles.
>
> E.g., running checkpatch on commit 513f7f747e1c ("parisc: Fix vma= p
> memory leak in ioremap()/iounmap()") reports this warning:
>
> WARNING: Non-standard signature: Noticed-by:
> Noticed-by: Sven Schnelle <svens@stackframe.org>
>

This example= really does not tell anyone much.

Replace it with a summary from your evaluation.


> Provide a fix by:
> 1) replacing the non-standard signature with its standard equivalent > 2) removing the signature if it is not required
>
> Also, improve warning messages correspondingly, providing users
> suggestions to either replace or remove the signature
>

Looks good.=



> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
> ---
>=C2=A0 scripts/checkpatch.pl | 45 ++++++++++++++++++++++++++++++++++++++= +++--
>=C2=A0 1 file changed, 43 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index fdfd5ec09be6..23a21dc2c29a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -506,6 +506,27 @@ our $signature_tags =3D qr{(?xi:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Cc:
>=C2=A0 )};
>=C2=A0
> +our %standard_signature_fix =3D (
> +=C2=A0 =C2=A0 =C2=A0"Requested-by:" =3D> "Suggested= -by:",
> +=C2=A0 =C2=A0 =C2=A0"Co-authored-by:" =3D> "Co-deve= loped-by:",
> +=C2=A0 =C2=A0 =C2=A0"Analyzed-by:" =3D> "Co-develop= ed-by:",
> +=C2=A0 =C2=A0 =C2=A0"Analysed-by:" =3D> "Co-develop= ed-by:",
> +=C2=A0 =C2=A0 =C2=A0"Improvements-by:" =3D> "Co-dev= eloped-by:",
> +=C2=A0 =C2=A0 =C2=A0"Noticed-by:" =3D> "Reported-by= :",
> +=C2=A0 =C2=A0 =C2=A0"Inspired-by:" =3D> "Suggested-= by:",
> +=C2=A0 =C2=A0 =C2=A0"Verified-by:" =3D> "Tested-by:= ",
> +=C2=A0 =C2=A0 =C2=A0"Okay-ished-by:" =3D> "Acked-by= :",
> +=C2=A0 =C2=A0 =C2=A0"Acked-for-MFD-by:" =3D> "Acked= -by:",
> +=C2=A0 =C2=A0 =C2=A0"Reviewed-off-by:" =3D> "Review= ed-by:",
> +=C2=A0 =C2=A0 =C2=A0"Proposed-by:" =3D> "Suggested-= by:",
> +=C2=A0 =C2=A0 =C2=A0"Fixed-by:" =3D> "Co-developed-= by:",
> +=C2=A0 =C2=A0 =C2=A0"Pointed-out-by:" =3D> "Suggest= ed-by:",
> +=C2=A0 =C2=A0 =C2=A0"Pointed-at-by:" =3D> "Suggeste= d-by:",
> +=C2=A0 =C2=A0 =C2=A0"Suggestions-by:" =3D> "Suggest= ed-by:",
> +=C2=A0 =C2=A0 =C2=A0"Generated-by:" =3D> "remove&qu= ot;,
> +=C2=A0 =C2=A0 =C2=A0"Celebrated-by:" =3D> "remove&q= uot;,
> +);
> +

How did cr= eate this list? I thought we looked at 30 cases...
<= br>

>=C2=A0 our @typeListMisordered =3D (
>=C2=A0 =C2=A0 =C2=A0 =C2=A0qr{char\s+(?:un)?signed},
>=C2=A0 =C2=A0 =C2=A0 =C2=A0qr{int\s+(?:(?:un)?signed\s+)?short\s},
> @@ -2773,8 +2794,28 @@ sub process {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0my $ucfirst_sign_off =3D ucfirst(lc($sign_off));
>=C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0if ($sign_off !~ /$signature_tags/) {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN("BAD_SIGN_OFF",
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "Non-standard signat= ure: $sign_off\n" . $herecurr);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0my $suggested_signature =3D ""= ;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (exists($standard_signature_fix{$sign= _off})) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$suggested_s= ignature =3D $standard_signature_fix{$sign_off};
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if ($suggested_signature eq ""= ) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0WARN("B= AD_SIGN_OFF",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 "Non-standard signature: $sign_off\n" . $herecurr);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0elsif ($suggested_signature eq "rem= ove") {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (WARN(&qu= ot;BAD_SIGN_OFF",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0"Non-standard signature: $sign_off. Please consider r= emoving this signature tag.\n" . $herecurr) &&
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$fix) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0fix_delete_line($fixlinenr, $rawline);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0else {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (WARN(&qu= ot;BAD_SIGN_OFF",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0"Non-standard signature: $sign_off. Please use '$= suggested_signature' instead.\n" . $herecurr) &&
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$fix) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0$fixed[$fixlinenr] =3D~ s/$sign_off/$suggested_signature/;=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0}
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0if (defined $space_before && $space_before ne "&q= uot;) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (WARN("BAD_SIGN_OFF",=
>

Initial tests performed on patches found this fix to be working as
expected.

Thanks
Aditya
--000000000000a76c2705b48f9ef5-- --===============7952846940217841658== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees --===============7952846940217841658==--