From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDB7C433E7 for ; Wed, 14 Oct 2020 11:17:15 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAF4F207C3 for ; Wed, 14 Oct 2020 11:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/8sbNUe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAF4F207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 36A49876FA; Wed, 14 Oct 2020 11:17:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ikv13j0R0zYt; Wed, 14 Oct 2020 11:17:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 92CD2876FD; Wed, 14 Oct 2020 11:17:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7B9DBC07FF; Wed, 14 Oct 2020 11:17:11 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 72C19C0895 for ; Wed, 14 Oct 2020 11:17:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5D22A879F7 for ; Wed, 14 Oct 2020 11:17:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4tSdno61Sjq4 for ; Wed, 14 Oct 2020 11:17:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 7323C87686 for ; Wed, 14 Oct 2020 11:17:07 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id m17so4569962ioo.1 for ; Wed, 14 Oct 2020 04:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F/JoGqZ/gVsbDWWdEfriH4rRpGgiN0P8ztK3T+/oyCQ=; b=M/8sbNUe2XeERw9eyGZ/ztFD1yunFHCmn8Nyduqf3lFy1h/pxyvkWkWWbddMbyWK+P ygjXGunv7TqsxAysPVIxyOamjEj7ANQYpwnLCd9sIj4mAKOs/ZzD85SZi5nVtDAaXCBn Y2uw2Oh+XTumHjG3PI4sWw3jK8E2jByopSt5RygImzjlFEl+6sUpbd3YQVoVleUveRXE YmzKm0Dc2sfKDcX/IxS51k0g8rwN3cy7rn5hygiPz9l+rAaOuOhzbeVmXCc7wOzME594 rhNwB9R2W4K55powfBvE6aDRJU6I9eNAYcv+5sC7H2Wk1qY0AKkCGIR84kaeztv/T2Op smdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F/JoGqZ/gVsbDWWdEfriH4rRpGgiN0P8ztK3T+/oyCQ=; b=VLO0ZGiwCrMcTDAN1BbjNa5AsN4X6Dcqp+pNKxCVqnsUyGM/NHuKtGYskOFPwOd/xu TuzysO8FWOQe8vnv2PqmM1e0gxcsH34MNEG+8/+JBKoOqvxYQUH+Ug4gomdYEuz6t/re daWTxgzLkD3kZR3BsMNrINj1ng7rmelj2dni9lpmzg5wOUX4oPwo7ZOiTJbeF+yzsFPs B8qmmOCkJ+T2uEJ+zFwoH9eKygznmbjjDfm2KzS4huYy27xRYs/noJ57eNW2iYtJQOyO zACFbIuaxC9RITPXgWANLIzLSVVzg+Y9VW30mWZZLgj+X6zTwZAV85heiavkhTc2JFjX Cl8Q== X-Gm-Message-State: AOAM533TR8fUyo2243ovK6fKsPYi+u01gc2Eg2T505vxS1amAAurgiXR kj98jzlK2VZ8u5tbjWTpGokTLRJIV6wpi2D9D50= X-Google-Smtp-Source: ABdhPJxWN9tVgkal3O7ABaXJ7WJLmivtQsjmFkl+T0o8N+RpQrMYosSWdBHxA1lMGBU9q3agNlA4HDUCqeoHiDsKIKU= X-Received: by 2002:a05:6638:2b3:: with SMTP id d19mr2640181jaq.141.1602674226415; Wed, 14 Oct 2020 04:17:06 -0700 (PDT) MIME-Version: 1.0 References: <20201013063009.38445-1-dwaipayanray1@gmail.com> In-Reply-To: From: Lukas Bulwahn Date: Wed, 14 Oct 2020 13:16:51 +0200 Message-ID: To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: add new exception to repeated word check X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Wed, Oct 14, 2020 at 12:34 PM Dwaipayan Ray wrote: > > On Tue, Oct 13, 2020 at 12:00 PM Dwaipayan Ray wrote: > > > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test") > > moved the repeated word test to check for more file types. But after > > this, if checkpatch.pl is run on MAINTAINERS, it generates several > > new warnings of the type: > > > > WARNING: Possible repeated word: 'git' > > > > For example: > > WARNING: Possible repeated word: 'git' > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git > > > > So, the pattern "git git://..." is a false positive in this case. > > > > Add 'git' to the exception list for repeated word check. This effectively > > fixes all the newly generated false positives. > > > > Fixes: 4f6ad8aa1eac ("checkpatch: move repeated word test") > > Link: https://lore.kernel.org/linux-kernel-mentees/b6cd81b936671a8868fe98536d7c80771bdfd61c.camel@perches.com/ > > > > Suggested-by: Joe Perches > > Suggested-by: Lukas Bulwahn > > Signed-off-by: Dwaipayan Ray > > --- > > scripts/checkpatch.pl | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index f1a4e61917eb..b55d83360366 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -3063,7 +3063,7 @@ sub process { > > } > > > > next if ($first ne $second); > > - next if ($first eq 'long'); > > + next if ($first =~ /(?:long|git)$/); > > > > if (WARN("REPEATED_WORD", > > "Possible repeated word: '$first'\n" . $herecurr) && > > -- > > 2.27.0 > > > > Hi, > Should I send this out or has this reached a dead end here? > All good; I must have overlooked that mail. It looks good to me. Send it to the larger group. Joe will probably just quickly ack that. Lukas _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees