Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED

From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Conor Dooley <Conor.Dooley@microchip.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm-generic: correct reference to GENERIC_LIB_DEVMEM_IS_ALLOWED
Date: Thu, 21 Jul 2022 08:52:17 +0200	[thread overview]
Message-ID: <CAKXUXMyEG1Sc18NuhONWHuQWvTfFHNPrn4wJf=v9jMSpLGfP+Q@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3K8PnPF7KEEVb=hquZsjXiatCkyXe9B_RLBcse2jU5LQ@mail.gmail.com>

On Wed, Jul 20, 2022 at 12:50 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Jul 7, 2022 at 4:41 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > On Thu, Jul 7, 2022 at 3:07 PM Arnd Bergmann <arnd@arndb.de> wrote:
> > > On Thu, Jul 7, 2022 at 2:20 PM <Conor.Dooley@microchip.com> wrote:
>
> > > lkft just found a build failure:
> > >
> > > https://gitlab.com/Linaro/lkft/users/arnd.bergmann/asm-generic/-/jobs/2691154818
> > >
> > > I have not investigated what went wrong, but it does look like an actual
> > > regression, so I'll wait for Lukas to follow up with a new version of the patch.
> >
> > Thanks for your testing. I will look into it. Probably it is due to
> > some more rigor during builds (-Werror and new warning types in the
> > default build) since I proposed the patch in October 2021. That should
> > be easy to fix, but let us see. I will send a PATCH v2 soon.
>
> Any update on this? I have another bugfix for asm-generic now and was planning
> to send a pull request with both. If you don't have the updated patch
> ready yet, this
> will have to go into 5.21 instead.
>

It is still on my TODO list for revisiting, but I had other work on
patches taking me longer than originally expected. I now moved this
patch revisiting to the top of my TODO list; so, I will certainly look
into this today. So far, I have not set up an arm64 build on my local
machine and have not used tuxbuild (which should simplify all this
setup)---the typical challenges for a "part-time kernel
contributor/janitor"...

Arnd, I will certainly let you know by this evening (European time
zone) how far I got. If that is already too late, it is also perfectly
fine if this goes in 5.21 instead, but I will try my best to make it
5.20 material.

Thanks for the patience so far.

Best regards,

Lukas

>       Arnd