From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0A0C433F5 for ; Tue, 11 Jan 2022 09:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349263AbiAKJYc (ORCPT ); Tue, 11 Jan 2022 04:24:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236844AbiAKJY1 (ORCPT ); Tue, 11 Jan 2022 04:24:27 -0500 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7486EC06173F; Tue, 11 Jan 2022 01:24:27 -0800 (PST) Received: by mail-yb1-xb2c.google.com with SMTP id c6so43392402ybk.3; Tue, 11 Jan 2022 01:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cv3VWXBT1vzgw9fDSWsZVII7SUUK8DtKIhodYFlsIgk=; b=DVGodsGp+VSGl7PLbXH13orlTCsJpSeMcZG5duC7hgmBKdGMjygDHD2lgi2pgB0CEf C7fJUfCweIb1aY/Mb7vLCY9wjKClUB0MJ0Ijjfz4TPnUDX2eDCt4aeFTCTJGFYGKi8q/ ISIDry3hXhQfA/SZnnW719Jloste+ehWznIrd5TISbbtj9uVVFwy2RJHNZgbOUbVX2hH y8vOMmbHaggPUUBcU+k7XULIxA5JuP7MzCUSJ3F3kvj549pNh0PAbkEwgjlisdYr/UTT +/2eybRR0P5mF1mA4pzNvBA3gj4gmmpUxdM7+BXG6FyF2nC9MiWyc+dbsSXZypM6PCxS 6jQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cv3VWXBT1vzgw9fDSWsZVII7SUUK8DtKIhodYFlsIgk=; b=SEMdA8Q9iV5gT4SS6gOr4I/TMvkoaO0AK1dIgQAtJgmrbr2bUQj8sJ/Hc0Qpb1AhSQ NSCCEpfkat8YnaAuVrfyV+6OS9Ed4wvC4rEreFGEHJzY7DlNKgjeAo0leU46GYJrCmy1 AoPVWtAolbkhD3UNeDnACaWBWMkT5a8AEUwPkh3gCA1aFhcXouPOQe0apvXY4IABdnDa 9IWJlOHjj9n6vu8GBYWFPweFbaIFAUClUBtVBJ9xZu8WuRenQGZ9/hzsG/vVFf8TPL/5 LIoeff9pdEXeTbhJ+CTPrJ1JzFkwbDbz2C10Y6+i8E9ypbIeHIsWENSl/EYcnXX+T9dW pOKA== X-Gm-Message-State: AOAM533tw/G85y/eq2pojHbpxl4yIrOBsA7YrcQImRvnDWmtsjz7ZvgE Yh46Mya2Yey9hANfcDjy2+LVhWK8i/dReNz9ew8= X-Google-Smtp-Source: ABdhPJyJDd8TkgoLs5BNf/NvRNq5BIDjYbteoC9S6P4Tzqyj4XtaIIoEpJ8yq8xa7iX3muDvh7OWB7MhJjZG8rvt+h0= X-Received: by 2002:a25:2cd0:: with SMTP id s199mr4858451ybs.234.1641893066617; Tue, 11 Jan 2022 01:24:26 -0800 (PST) MIME-Version: 1.0 References: <20211224141213.27612-1-kevin3.tang@gmail.com> <20211224141213.27612-2-kevin3.tang@gmail.com> In-Reply-To: <20211224141213.27612-2-kevin3.tang@gmail.com> From: Lukas Bulwahn Date: Tue, 11 Jan 2022 10:24:21 +0100 Message-ID: Subject: Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig To: Kevin Tang Cc: Maarten Lankhorst , Maxime Ripard , sean@poorly.run, David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , pony1.wu@gmail.com, Orson Zhai , Dan Carpenter , zou_wei@huawei.com, Chunyan Zhang , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 24, 2021 at 3:12 PM Kevin Tang wrote: > > On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD, > which selects DRM_KMS_CMA_HELPER. > That this commit is _currently_ on linux-next is just a matter of the current state. The commit message that goes into the project's history should probably not state "on linux-next"; this information is probably outdated or of no interest to any further future reader at the time of reading. So, just drop "On linux-next". The commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") will exist until the end of time. > However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the > DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol. > I would be happy about acknowledging my work of reporting with a Reported-by tag, although I accidently send the report only to you without cc-ing the mailing lists. Please add: Reported-by: Lukas Bulwahn That said you may also add a Reviewed-by tag now: Reviewed-by: Lukas Bulwahn Lukas > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > drivers/gpu/drm/sprd/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig > index 3edeaeca0..9a9c7ebfc 100644 > --- a/drivers/gpu/drm/sprd/Kconfig > +++ b/drivers/gpu/drm/sprd/Kconfig > @@ -3,7 +3,6 @@ config DRM_SPRD > depends on ARCH_SPRD || COMPILE_TEST > depends on DRM && OF > select DRM_GEM_CMA_HELPER > - select DRM_KMS_CMA_HELPER > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select VIDEOMODE_HELPERS > -- > 2.29.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF718C433F5 for ; Tue, 11 Jan 2022 09:24:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0FD014A0D2; Tue, 11 Jan 2022 09:24:28 +0000 (UTC) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A33814A0D3 for ; Tue, 11 Jan 2022 09:24:27 +0000 (UTC) Received: by mail-yb1-xb2a.google.com with SMTP id g17so1851082ybq.6 for ; Tue, 11 Jan 2022 01:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cv3VWXBT1vzgw9fDSWsZVII7SUUK8DtKIhodYFlsIgk=; b=DVGodsGp+VSGl7PLbXH13orlTCsJpSeMcZG5duC7hgmBKdGMjygDHD2lgi2pgB0CEf C7fJUfCweIb1aY/Mb7vLCY9wjKClUB0MJ0Ijjfz4TPnUDX2eDCt4aeFTCTJGFYGKi8q/ ISIDry3hXhQfA/SZnnW719Jloste+ehWznIrd5TISbbtj9uVVFwy2RJHNZgbOUbVX2hH y8vOMmbHaggPUUBcU+k7XULIxA5JuP7MzCUSJ3F3kvj549pNh0PAbkEwgjlisdYr/UTT +/2eybRR0P5mF1mA4pzNvBA3gj4gmmpUxdM7+BXG6FyF2nC9MiWyc+dbsSXZypM6PCxS 6jQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cv3VWXBT1vzgw9fDSWsZVII7SUUK8DtKIhodYFlsIgk=; b=bzikGLpsYLsEaORHUgg7s4eArpfpG2lmDNLlMJvuH/3k9cjqTMAf9gI0MmqKJYcHJG itQ1hfvLMkH9wXWbNmRjESdSEx/HTAPGAgyfgEw4fjgjCGjoUQGlOp4xk2HZfaXHsaBK Ryj1tVCB8RKdDk1m0zOuJ2RZ2fNXHSNSXAt4tCFGc6Ci0Y/U+C2cJ8m2deq0sQrCiVgA +vHkxUre268LFe3Yz72Gpow15z49CyJ9AkXWcosZJZ0mXCRGj+QOb6nUaEs56T+xYaww sS9s6Gimu8iKBDC8YHsxCWPxcoZ/pRGgqK8dN0aR1NgZvVK9PCSG9/p/vK2kdF3Y8IJV K5nw== X-Gm-Message-State: AOAM530NSe/BTsBoToR0hAEemiJRV2WIF0VeOfP0iHilmavaO9Pk+uia d9sIaMCs2LOBp7LRz+ZSdsKT2bu6BxU6VHt36OA= X-Google-Smtp-Source: ABdhPJyJDd8TkgoLs5BNf/NvRNq5BIDjYbteoC9S6P4Tzqyj4XtaIIoEpJ8yq8xa7iX3muDvh7OWB7MhJjZG8rvt+h0= X-Received: by 2002:a25:2cd0:: with SMTP id s199mr4858451ybs.234.1641893066617; Tue, 11 Jan 2022 01:24:26 -0800 (PST) MIME-Version: 1.0 References: <20211224141213.27612-1-kevin3.tang@gmail.com> <20211224141213.27612-2-kevin3.tang@gmail.com> In-Reply-To: <20211224141213.27612-2-kevin3.tang@gmail.com> From: Lukas Bulwahn Date: Tue, 11 Jan 2022 10:24:21 +0100 Message-ID: Subject: Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig To: Kevin Tang Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , pony1.wu@gmail.com, Linux Kernel Mailing List , Rob Herring , dri-devel@lists.freedesktop.org, Chunyan Zhang , Orson Zhai , zou_wei@huawei.com, sean@poorly.run, Dan Carpenter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 24, 2021 at 3:12 PM Kevin Tang wrote: > > On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD, > which selects DRM_KMS_CMA_HELPER. > That this commit is _currently_ on linux-next is just a matter of the current state. The commit message that goes into the project's history should probably not state "on linux-next"; this information is probably outdated or of no interest to any further future reader at the time of reading. So, just drop "On linux-next". The commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") will exist until the end of time. > However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the > DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol. > I would be happy about acknowledging my work of reporting with a Reported-by tag, although I accidently send the report only to you without cc-ing the mailing lists. Please add: Reported-by: Lukas Bulwahn That said you may also add a Reviewed-by tag now: Reviewed-by: Lukas Bulwahn Lukas > Cc: Orson Zhai > Cc: Chunyan Zhang > Signed-off-by: Kevin Tang > --- > drivers/gpu/drm/sprd/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig > index 3edeaeca0..9a9c7ebfc 100644 > --- a/drivers/gpu/drm/sprd/Kconfig > +++ b/drivers/gpu/drm/sprd/Kconfig > @@ -3,7 +3,6 @@ config DRM_SPRD > depends on ARCH_SPRD || COMPILE_TEST > depends on DRM && OF > select DRM_GEM_CMA_HELPER > - select DRM_KMS_CMA_HELPER > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select VIDEOMODE_HELPERS > -- > 2.29.0 >