From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B272C433EF for ; Wed, 8 Sep 2021 16:20:46 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E489A61154 for ; Wed, 8 Sep 2021 16:20:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E489A61154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mO0J4-0001Cv-Gt; Wed, 08 Sep 2021 12:20:14 -0400 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mO0J2-0001CS-He for kernelnewbies@kernelnewbies.org; Wed, 08 Sep 2021 12:20:12 -0400 Received: by mail-yb1-xb34.google.com with SMTP id c206so5338834ybb.12 for ; Wed, 08 Sep 2021 09:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ig4bCjHTCgbbWJxun/SrDaLt0x/8jUl2ZW8tLBb/RPc=; b=nag8psg1Fz6cLkYNRHibE0DTCdbzq+/6mG1ybogO+Wm89rTMN+MTdLz3yZGu+nKGCH sm5aHRo13VDh7MMWqwasBLJWc6PstGtjAfxhc3iRQlr64rtK+VM55ABI0HJx2kEhqvJv DXaMZU7J2eBoVqy2LuVplXOBoQnswhRfJHJnYP8qgBMgyUfbjM2V4ylTrXrHwhBXvPfw vfjLGTmDGK+EvgVvqj9gNtmJiSlGq0RxGN6/CATVlGWnOmCv9+r27DtVU+xBxKgrD62u XqhTaUhNXBc60SbO8GcvgYH7TW1Ga3yovkwbRVEzFPMvFxRK6elVAzVRBPibTVv2AUnY LcBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ig4bCjHTCgbbWJxun/SrDaLt0x/8jUl2ZW8tLBb/RPc=; b=wiD74gpmkVtvnokPbHnhOQUEZT5AYqURBxZ6J5deHpmX77nWYfVIv0sT8x7hM4/0NG kVfCsYvmvgtHkJRqaTRYk3DSt1pcx+ktfpJXfnKYTbJx6TIbpH5GoOOy3yiRjQLcvm9B R0YC1LzzgglU8wxFEakOTkyqv+kP05yQqvFGk8HL6HszULhuVYfMzES7hXGCts+L+VRO KpH/DXaWJ/s9M4nipn+irKiVXec2jw5eUV8hdWPRD/N7V5LCGkVq8unoG1+MC+tM9YoC spkjQGtpMH/Cmm9sb0lvZdRJOCIFpIcqKx4NlyJJ6kpECHzYAlD/DvS2xo4Xgx89zBFm 6NuA== X-Gm-Message-State: AOAM532Rg9iH3HkDqdyAnTkwL9Mii81XRWi7CKGWclJ5Uj6YWa36wCfn vchgBqWEkdDLiM6k1j1YPLWW2gW4ag9yaCozkLI= X-Google-Smtp-Source: ABdhPJzuqpc8TlOVXFSFR8a2Dv8tJ06apL1sV22YIrQmQ0183cj1Gly/Fs14EWwn2L9lL+zc9rYubpccl/a9e1oCFgA= X-Received: by 2002:a25:4090:: with SMTP id n138mr5935267yba.339.1631118009958; Wed, 08 Sep 2021 09:20:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Lukas Bulwahn Date: Wed, 8 Sep 2021 18:19:58 +0200 Message-ID: Subject: Re: Kernel upstream compile error at drivers/staging/media To: Lafan Mining Cc: Greg KH , "kernelnewbies@kernelnewbies.org" X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Wed, Sep 8, 2021 at 6:00 PM Lafan Mining wrote: > > On Wednesday, September 8th, 2021 at 12:50, Greg KH wrote: > > > Please update your kernel version, this should already be fixed. > > It's not. There have been sent several patches already to fix this issue. Here are 2 of them: > > 1. https://lkml.org/lkml/2021/9/5/146 > 2. https://lore.kernel.org/lkml/20210802143820.1150099-1-arnd@kernel.org/ > > And no one of them has been applied yet. Here is the log of the file input_system.c: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c > Good own investigation so far. The patch you point out is already applied to a maintainer's (Mauro's) integration tree, and hence in linux-next: commit 05344a1d2ea7bad3492c34299c37407bfcfed355 Author: Arnd Bergmann Date: Mon Aug 2 16:38:14 2021 +0200 media: atomisp: restore missing 'return' statement The input_system_configure_channel_sensor() function lost its final return code in a previous patch: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function 'input_system_configure_channel_sensor': drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type] Restore what was there originally. Link: https://lore.kernel.org/linux-media/20210802143820.1150099-1-arnd@kernel.org Fixes: 728a5c64ae5f ("media: atomisp: remove dublicate code") Signed-off-by: Arnd Bergmann Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab So, it is just a matter of hours until Linus takes the pull request from Mauro, v5.15-rc1 is out and the issue is resolved. If you ping Greg with this patch being good for stable, he will pick it and probably apply that for the v5.14 stable tree as well. So be a bit patient, or change your config... Do you really need this driver? Is it really important to you and your business? Then, consider that it is currently under drivers/staging/ and might just disappear from one day to another because nobody is aware of critical users (that is why it is in staging in the first place). I hope this helps, Lukas _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies