From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209B7C433F5 for ; Fri, 29 Oct 2021 05:53:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0959361040 for ; Fri, 29 Oct 2021 05:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbhJ2Fz7 (ORCPT ); Fri, 29 Oct 2021 01:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231774AbhJ2Fz6 (ORCPT ); Fri, 29 Oct 2021 01:55:58 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3894C061570; Thu, 28 Oct 2021 22:53:29 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id a6so21469257ybq.9; Thu, 28 Oct 2021 22:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/vSuXsboymS/IgpBF9knJfz3TVx/mAj7z1ArPgdizjI=; b=YOSdiYDPna3naFx1R6UjtVwYbyaJDrQD0isSgwS7yDBmHs8l0633OLtBLdGZdil/TM 6dWhEg7S0NjtqvwZYX7tJ6kmufifUyEsCBZ3T5NR6r+lTFF+4YliqgbNqpSYGLFCPnIc 63kQo9ZVCpGhOJjvhO4+XCfmV8oIjS0MhJ7SHonzwa5B91APGzuLAsLw+N10yC/YeEnv JMyp971+Be/WEYtK8PtAvDll0XWvtwa4gwXp0UNxF8c+NEPJIOFSKqKgAOtNeodTVA0U MaGNfijGHoFgsMdltgUJvbJD8HBBdw6PQk5VbLk1vRdZj7p6+jciFWsA8ca+MsMwbuqX ojrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/vSuXsboymS/IgpBF9knJfz3TVx/mAj7z1ArPgdizjI=; b=souWHQGv+yvpNPJCJcNj64xQxBSJZVbN+Hr7P+TLPrrzDh3st8FXQOwP+uUeWuY7fY GFhf7CL36JKGPj0AGfrcs19Hfa75CT62csPnL34j/w8q410lDM0NpMNoWNVDH5v/G2/0 VPaPWjYLpHDXPQDOKesJC6xrSDPlOR7E+1aaemK2PDfloxoX0dNr/cbjaYL3/rUpuiV6 cssCWyux9ZcbkmSWbh7Ps411eftIymTr4gKRMgHofo4JFDPeS3G5+RXx9aD9vIpxmnnx 5O+VewyKSGXmv0IJFGwbJVWRK3gCktsIBL/MOCrD0EjrWnIVIxNXOvVrhrLjZTTyzLmo tZxA== X-Gm-Message-State: AOAM532LVJC42x11KzgbHK42B9OPIfZesOtkd1NSwGfwxkCJ/AjEb1Gv Glm0CUQJ8JYZM47STLKfX9YgDuGxa5e+FugrtuLljPZU X-Google-Smtp-Source: ABdhPJyaDlFoQq08g4YGXVSCxLxGN/EmlAplDZR3KAUzA0+ijsxzW6j44WCrZVqFPjLqsiVYlKPnbzBLVnyA+o64mDI= X-Received: by 2002:a25:3787:: with SMTP id e129mr9141363yba.91.1635486809154; Thu, 28 Oct 2021 22:53:29 -0700 (PDT) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> In-Reply-To: From: Lukas Bulwahn Date: Fri, 29 Oct 2021 07:53:17 +0200 Message-ID: Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 To: "Russell King (Oracle)" Cc: Arnd Bergmann , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Linux ARM , OpenBMC Maillist , kernel-janitors , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 5:35 PM Russell King (Oracle) wrote: > > On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > > in ./arch/arm/kernel/bios32.c. > > > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > > > PCI_HOST_ITE8152 > > > Referencing files: arch/arm/kernel/bios32.c > > > > > > Remove this obsolete ifndef. > > > > > > Signed-off-by: Lukas Bulwahn > > > > Reviewed-by: Arnd Bergmann > > > > I wonder if we should just remove this function and use the > > (non-empty) default version instead. > > > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > > introduced that generic version, and I suspect the arm version > > was left out by mistake, but it's not clear from that patch. > > That was because PCI_HOST_ITE8152 needed something different from the > "do nothing" default (setting the PCI latency timer to default to 64 > as the new generic code did.) > So, can we just drop the empty pcibios_set_master() function in bios32.c and the pci handling will now (after the removal of PCI_HOST_ITE8152) just do The Right Thing(TM)? If you can confirm that, I will send an updated patch here. Thanks, Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26164C433F5 for ; Fri, 29 Oct 2021 05:54:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F88860FC0 for ; Fri, 29 Oct 2021 05:54:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9F88860FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HgWpG1wv6z2ym7 for ; Fri, 29 Oct 2021 16:54:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=YOSdiYDP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::b2b; helo=mail-yb1-xb2b.google.com; envelope-from=lukas.bulwahn@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=YOSdiYDP; dkim-atps=neutral Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HgWnT2tDxz2xZL for ; Fri, 29 Oct 2021 16:53:32 +1100 (AEDT) Received: by mail-yb1-xb2b.google.com with SMTP id o12so21585940ybk.1 for ; Thu, 28 Oct 2021 22:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/vSuXsboymS/IgpBF9knJfz3TVx/mAj7z1ArPgdizjI=; b=YOSdiYDPna3naFx1R6UjtVwYbyaJDrQD0isSgwS7yDBmHs8l0633OLtBLdGZdil/TM 6dWhEg7S0NjtqvwZYX7tJ6kmufifUyEsCBZ3T5NR6r+lTFF+4YliqgbNqpSYGLFCPnIc 63kQo9ZVCpGhOJjvhO4+XCfmV8oIjS0MhJ7SHonzwa5B91APGzuLAsLw+N10yC/YeEnv JMyp971+Be/WEYtK8PtAvDll0XWvtwa4gwXp0UNxF8c+NEPJIOFSKqKgAOtNeodTVA0U MaGNfijGHoFgsMdltgUJvbJD8HBBdw6PQk5VbLk1vRdZj7p6+jciFWsA8ca+MsMwbuqX ojrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/vSuXsboymS/IgpBF9knJfz3TVx/mAj7z1ArPgdizjI=; b=hMK1M8cmQroICYESEdMmRGlWNjDm3V82qTwy3uzHtVIgpT1AhlkhSjHw3K/dqHfSVc yXp0ycMuRP9w5bM49y6SKobzl02r5P0+6Ho7fscygb7DZznXzXiMDJrTPNYPeHSbYDvi od7S54zTWB6Z9GZGxeU0U04oef0/6R9iAJZq9JiVJiznvjbM4zN+0AraboeF8bGvMPO/ kG+nJ0jYcOhrm72jDo+eIH1YV/LEjD3HHmLy7H+/D29nuF/MWUKLUGJp1BtlSmaeVpX7 EKdMsgMf1TYQ4mYbpSKk8W5LsttiL335bJdctsnkyiF9Z4eZOO7Frt0hWi63m75kCHW/ mfaA== X-Gm-Message-State: AOAM530lE1ifn0DEg4ddl3Ts3n24BdFGHa5oY0TJ2KlK/VBNmTacw6Lb RWzkA8tBX+dp9MzZHmZahEVUFN8io9AxtaXob/Q= X-Google-Smtp-Source: ABdhPJyaDlFoQq08g4YGXVSCxLxGN/EmlAplDZR3KAUzA0+ijsxzW6j44WCrZVqFPjLqsiVYlKPnbzBLVnyA+o64mDI= X-Received: by 2002:a25:3787:: with SMTP id e129mr9141363yba.91.1635486809154; Thu, 28 Oct 2021 22:53:29 -0700 (PDT) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> In-Reply-To: From: Lukas Bulwahn Date: Fri, 29 Oct 2021 07:53:17 +0200 Message-ID: Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 To: "Russell King (Oracle)" Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , kernel-janitors , Tomer Maimon , Arnd Bergmann , Dinh Nguyen , Avi Fishman , Shawn Guo , Sascha Hauer , OpenBMC Maillist , Sekhar Nori , Linux Kernel Mailing List , Tali Perry , Krzysztof Halasa , Pengutronix Kernel Team , Patrick Venture , Imre Kaloz , Fabio Estevam , Bartosz Golaszewski , Linux ARM , Benjamin Fair Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Oct 28, 2021 at 5:35 PM Russell King (Oracle) wrote: > > On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > > in ./arch/arm/kernel/bios32.c. > > > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > > > PCI_HOST_ITE8152 > > > Referencing files: arch/arm/kernel/bios32.c > > > > > > Remove this obsolete ifndef. > > > > > > Signed-off-by: Lukas Bulwahn > > > > Reviewed-by: Arnd Bergmann > > > > I wonder if we should just remove this function and use the > > (non-empty) default version instead. > > > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > > introduced that generic version, and I suspect the arm version > > was left out by mistake, but it's not clear from that patch. > > That was because PCI_HOST_ITE8152 needed something different from the > "do nothing" default (setting the PCI latency timer to default to 64 > as the new generic code did.) > So, can we just drop the empty pcibios_set_master() function in bios32.c and the pci handling will now (after the removal of PCI_HOST_ITE8152) just do The Right Thing(TM)? If you can confirm that, I will send an updated patch here. Thanks, Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D180C433F5 for ; Fri, 29 Oct 2021 05:54:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4594A61040 for ; Fri, 29 Oct 2021 05:54:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4594A61040 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6parnmyS3Mk/6WBQKYZ4QRUQFGh0ODhJKZux8B+SCzc=; b=QdDs+VcmjsfpYs r6nCbFp+OS8EmI2lwUMS70LaoQvLDhE2Xy4voMwbvmrn0/TvTHyOuimfWARb6XBYnAuAr1vHN294F VtwZ5JUcF8F4HaVjEBNSX3HAbQpvJ9T73BX5LTj5b+ZMGnWbpSqE/8vaH+VFmGa9J8VyfKow7O0V5 1yLsMA0v9Zpv51fzVjTB3Byk9ryYhYLy4y4DQzN5k/V6g+D683xl9juUSm0si5gKSNvdovqgSUhcN B0E4yFN90FxvRMGaRvfEEnVZDL5SrC0UbVwZT+Vt4viHNnUyWJXOOqFGCpqjVV+ecU10XHAdx1hna H1hMYqzSzpkdA1Nbsgng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgKpa-009tAF-5l; Fri, 29 Oct 2021 05:53:34 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgKpW-009t9j-HQ for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 05:53:31 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id y3so10436248ybf.2 for ; Thu, 28 Oct 2021 22:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/vSuXsboymS/IgpBF9knJfz3TVx/mAj7z1ArPgdizjI=; b=YOSdiYDPna3naFx1R6UjtVwYbyaJDrQD0isSgwS7yDBmHs8l0633OLtBLdGZdil/TM 6dWhEg7S0NjtqvwZYX7tJ6kmufifUyEsCBZ3T5NR6r+lTFF+4YliqgbNqpSYGLFCPnIc 63kQo9ZVCpGhOJjvhO4+XCfmV8oIjS0MhJ7SHonzwa5B91APGzuLAsLw+N10yC/YeEnv JMyp971+Be/WEYtK8PtAvDll0XWvtwa4gwXp0UNxF8c+NEPJIOFSKqKgAOtNeodTVA0U MaGNfijGHoFgsMdltgUJvbJD8HBBdw6PQk5VbLk1vRdZj7p6+jciFWsA8ca+MsMwbuqX ojrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/vSuXsboymS/IgpBF9knJfz3TVx/mAj7z1ArPgdizjI=; b=IBk5QqTdI7ivGCaxA0DzLukimg/dPmnnp67CrTLl9vIeOr12S50Mk8+yJLGV3Qfrog JqVwuCl8+x4LiQ9RLuHtdJQa7ZBhe02IOIixWmjVfCeu4V2MLevb7HjaO7zUeyhV7C+X hbpQbRU6pvhmv9lu7fHWCABTdOfg0W8Ba6cR/mKHhvhhqmI1qBWdn9ItOQLH6Z7i7ObF ZHlGftCukAQTp2oskGt+RhVe20oJHiTIQn705Lf1UULJVyuQTM1J7Pxa/UVz8BY2MrNr C5l+/hmz7o9fJe+rcn3osT/OhxnHJKN8104PoDZkOM1WUs+11V++QNOjLvFN8ue6p/zK fFFg== X-Gm-Message-State: AOAM533oTwGT82UenOr6EP6lQZ9Mr85N60DkfrEY1iicZ2zSeTtcyMYC VlsAHiN5inklsbLH70m7gCfcDk5omb/7PpAtloY= X-Google-Smtp-Source: ABdhPJyaDlFoQq08g4YGXVSCxLxGN/EmlAplDZR3KAUzA0+ijsxzW6j44WCrZVqFPjLqsiVYlKPnbzBLVnyA+o64mDI= X-Received: by 2002:a25:3787:: with SMTP id e129mr9141363yba.91.1635486809154; Thu, 28 Oct 2021 22:53:29 -0700 (PDT) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> In-Reply-To: From: Lukas Bulwahn Date: Fri, 29 Oct 2021 07:53:17 +0200 Message-ID: Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 To: "Russell King (Oracle)" Cc: Arnd Bergmann , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Linux ARM , OpenBMC Maillist , kernel-janitors , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_225330_617294_B4420A12 X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 5:35 PM Russell King (Oracle) wrote: > > On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > > in ./arch/arm/kernel/bios32.c. > > > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > > > PCI_HOST_ITE8152 > > > Referencing files: arch/arm/kernel/bios32.c > > > > > > Remove this obsolete ifndef. > > > > > > Signed-off-by: Lukas Bulwahn > > > > Reviewed-by: Arnd Bergmann > > > > I wonder if we should just remove this function and use the > > (non-empty) default version instead. > > > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > > introduced that generic version, and I suspect the arm version > > was left out by mistake, but it's not clear from that patch. > > That was because PCI_HOST_ITE8152 needed something different from the > "do nothing" default (setting the PCI latency timer to default to 64 > as the new generic code did.) > So, can we just drop the empty pcibios_set_master() function in bios32.c and the pci handling will now (after the removal of PCI_HOST_ITE8152) just do The Right Thing(TM)? If you can confirm that, I will send an updated patch here. Thanks, Lukas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel