From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F694C433DF for ; Wed, 26 Aug 2020 11:03:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CC6F2087C for ; Wed, 26 Aug 2020 11:03:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s7IhKc7Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CC6F2087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAtDS-0000Yj-8J for qemu-devel@archiver.kernel.org; Wed, 26 Aug 2020 07:03:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAt5X-0002Xu-GF for qemu-devel@nongnu.org; Wed, 26 Aug 2020 06:55:31 -0400 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:33589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAt5V-0001pi-Ng for qemu-devel@nongnu.org; Wed, 26 Aug 2020 06:55:31 -0400 Received: by mail-ot1-x344.google.com with SMTP id t7so1148698otp.0 for ; Wed, 26 Aug 2020 03:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NBFS1/HS/zOYoxL94070hIRVoqRtTMgsIpaJj4PD718=; b=s7IhKc7ZOezIrm0P4NN0fruwBeEo1wUd7Twn/SQArkXlB8+BTNcZGueUjxaj1+AJqy v05PunaUUI9CBBQATTOlGdDIDxWVhya8nbQnCJH37pgEddYWitc2X6qT/P8lLIa4b9ar bQRXmccq3L4lxgK4beqUFD7BJydRjcdBZWF43WKC/yn/YWhh7t3dZlCYpN1ZgMi0nvE0 hEVmCJv+XsG3xClmPcBtlviw0em3sn5SQ68CpjCKdUXdus6xtzj9cO0Kg4uZGyKhjM8O jGvMft0TEP3uipUJEHgW31T1DiVQeTgr558tI4ud439JJqypeZdoMRs+8DA96/GAJeZn 9DIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NBFS1/HS/zOYoxL94070hIRVoqRtTMgsIpaJj4PD718=; b=JxR5fsVG40vfwW26zT+iJtzeTQaUuavECVwzjj+hLW9lOqGqAH/h+K6sB/crT/noDk BTaX2Xosw+ozP3baV3Hg1uk9OSRck0ixxXsKDzkqIvQUN0+KKtQhJuApHnw9BWEG/thJ vvBIYdsPRLv3Q0Gg6rCh+1+V2mwe21KpqPY4tQ14LC3CMZe9dRUKX/LdpgUs3NO9TUoK 3EAWVSoommcydBe111fRlQLebuClUDRjLNRao8CYutb0blppf1dgQB3YJmaNDoDM0oLj 5T5So0u8hzjw1Cv9jKwTlVY1QQ9JfnNAb/FfZBcV+XZKdjJoMNC972WroG4woJRmsYYg +Okg== X-Gm-Message-State: AOAM5336pbINCh3hZCxHstK7aIiYJTpbEJuTKMwG95NMPjid49ok9pRo UvFt11IiSi758CMBdPBBEASB/mg11gtz63QsbPE= X-Google-Smtp-Source: ABdhPJyHFtAEQyeppFDRDJBNvYw+CzFKAAnQZJqXNlkoGAKkZ5OtnkRnzf9yZoTQRcNHHtPelzXTX3IRz6wv54S1bzw= X-Received: by 2002:a9d:788:: with SMTP id 8mr2853901oto.181.1598439327729; Wed, 26 Aug 2020 03:55:27 -0700 (PDT) MIME-Version: 1.0 References: <20200814160241.7915-1-pannengyuan@huawei.com> <20200814160241.7915-5-pannengyuan@huawei.com> In-Reply-To: <20200814160241.7915-5-pannengyuan@huawei.com> From: Li Qiang Date: Wed, 26 Aug 2020 18:54:51 +0800 Message-ID: Subject: Re: [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file To: Pan Nengyuan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::344; envelope-from=liq3ea@gmail.com; helo=mail-ot1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , Euler Robot , Qemu Developers , Viktor Prutyanov , zhanghailiang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Pan Nengyuan =E4=BA=8E2020=E5=B9=B48=E6=9C=8814=E6= =97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5=8D=886:51=E5=86=99=E9=81=93=EF=BC=9A > > Missing g_error_free in pdb_init_from_file() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > Cc: Viktor Prutyanov > --- > contrib/elf2dmp/pdb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/elf2dmp/pdb.c b/contrib/elf2dmp/pdb.c > index a5bd40c99d..b3a6547068 100644 > --- a/contrib/elf2dmp/pdb.c > +++ b/contrib/elf2dmp/pdb.c > @@ -285,6 +285,7 @@ int pdb_init_from_file(const char *name, struct pdb_r= eader *reader) > reader->gmf =3D g_mapped_file_new(name, TRUE, &gerr); > if (gerr) { > eprintf("Failed to map PDB file \'%s\'\n", name); > + g_error_free(gerr); > return 1; > } > > -- > 2.18.2 > >