From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965658AbcJYJ5Y (ORCPT ); Tue, 25 Oct 2016 05:57:24 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:40674 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758631AbcJYJ5R (ORCPT ); Tue, 25 Oct 2016 05:57:17 -0400 MIME-Version: 1.0 In-Reply-To: <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-14-ahaslam@baylibre.com> <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> From: Axel Haslam Date: Tue, 25 Oct 2016 11:56:36 +0200 Message-ID: Subject: Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals To: David Lechner Cc: Greg KH , Johan Hovold , robh+dt@kernel.org, Sekhar Nori , Alan Stern , Kevin Hilman , Sergei Shtylyov , Mark Brown , Alexandre Bailon , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 3:12 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: >> >> From: Axel Haslam >> > static const struct ohci_driver_overrides da8xx_overrides __initconst = >> > { >> - .reset = ohci_da8xx_reset >> + .reset = ohci_da8xx_reset, >> + .extra_priv_size = sizeof(struct da8xx_ohci_hcd), > > > nit: since you are changing both lines anyway, you might as well make the > ='s line up. ok, will do. > >> }; >> >> /* >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ahaslam@baylibre.com (Axel Haslam) Date: Tue, 25 Oct 2016 11:56:36 +0200 Subject: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals In-Reply-To: <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-14-ahaslam@baylibre.com> <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 25, 2016 at 3:12 AM, David Lechner wrote: > On 10/24/2016 11:46 AM, ahaslam at baylibre.com wrote: >> >> From: Axel Haslam >> > static const struct ohci_driver_overrides da8xx_overrides __initconst = >> > { >> - .reset = ohci_da8xx_reset >> + .reset = ohci_da8xx_reset, >> + .extra_priv_size = sizeof(struct da8xx_ohci_hcd), > > > nit: since you are changing both lines anyway, you might as well make the > ='s line up. ok, will do. > >> }; >> >> /* >> >