From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941835AbcJYPIC (ORCPT ); Tue, 25 Oct 2016 11:08:02 -0400 Received: from mail-qt0-f171.google.com ([209.85.216.171]:33010 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941820AbcJYPH7 (ORCPT ); Tue, 25 Oct 2016 11:07:59 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-10-ahaslam@baylibre.com> <20161024175320.GO17252@sirena.org.uk> <20161024181937.GP17252@sirena.org.uk> <20161025143304.GW17252@sirena.org.uk> From: Axel Haslam Date: Tue, 25 Oct 2016 17:07:17 +0200 Message-ID: Subject: Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event To: Mark Brown Cc: Greg KH , Johan Hovold , robh+dt@kernel.org, Sekhar Nori , Alan Stern , Kevin Hilman , Sergei Shtylyov , David Lechner , manjunath.goudar@linaro.org, Alexandre Bailon , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 4:57 PM, Axel Haslam wrote: > On Tue, Oct 25, 2016 at 4:33 PM, Mark Brown wrote: >> On Tue, Oct 25, 2016 at 02:55:48PM +0200, Axel Haslam wrote: >> >>> To be able to use regulator to handle the overcurrent pin, i need to be able >>> to somehow retrieve the over current pin state from the regulator driver. >> >> What makes you say that, none of the existing users need this? >> >>> As i was trying your suggestion, i remembered why i thought i should use >>> mode instead of status: Status seems to be for internal regulator driver use, >>> there is no regulator_get_status, function and REGULATOR_STATUS_* are defined >>> in driver.h and not in consumer.h as REGULATOR_MODE_* >> >>> Would you be ok if i allow consumers to get the status via a new >>> "regulator_get_status" call? >> >> What would they do with this information that they can't do with the >> existing error notification? > > the usb core relies in two flags that need too be set properly, one is the > over-current indicator RH_PS_POCI , and the other is the over current > indicator "change" (RH_PS_OCIC). > > The idea was to use the notification to set the over current indicator > "change" flag, > which will happen for both rising and falling edges. And to use > get_status or get_mode > to set the over-current indicator flag which should reflect the actual > pin status. > BTW, for the notification, i should have used a new event flag something like: OVER_CURRENT_CHANGED and not just OVER_CURRENT Regards Axel > > -Axel. From mboxrd@z Thu Jan 1 00:00:00 1970 From: ahaslam@baylibre.com (Axel Haslam) Date: Tue, 25 Oct 2016 17:07:17 +0200 Subject: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event In-Reply-To: References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-10-ahaslam@baylibre.com> <20161024175320.GO17252@sirena.org.uk> <20161024181937.GP17252@sirena.org.uk> <20161025143304.GW17252@sirena.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 25, 2016 at 4:57 PM, Axel Haslam wrote: > On Tue, Oct 25, 2016 at 4:33 PM, Mark Brown wrote: >> On Tue, Oct 25, 2016 at 02:55:48PM +0200, Axel Haslam wrote: >> >>> To be able to use regulator to handle the overcurrent pin, i need to be able >>> to somehow retrieve the over current pin state from the regulator driver. >> >> What makes you say that, none of the existing users need this? >> >>> As i was trying your suggestion, i remembered why i thought i should use >>> mode instead of status: Status seems to be for internal regulator driver use, >>> there is no regulator_get_status, function and REGULATOR_STATUS_* are defined >>> in driver.h and not in consumer.h as REGULATOR_MODE_* >> >>> Would you be ok if i allow consumers to get the status via a new >>> "regulator_get_status" call? >> >> What would they do with this information that they can't do with the >> existing error notification? > > the usb core relies in two flags that need too be set properly, one is the > over-current indicator RH_PS_POCI , and the other is the over current > indicator "change" (RH_PS_OCIC). > > The idea was to use the notification to set the over current indicator > "change" flag, > which will happen for both rising and falling edges. And to use > get_status or get_mode > to set the over-current indicator flag which should reflect the actual > pin status. > BTW, for the notification, i should have used a new event flag something like: OVER_CURRENT_CHANGED and not just OVER_CURRENT Regards Axel > > -Axel.