From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F509C4332B for ; Fri, 20 Mar 2020 23:24:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 088EA20752 for ; Fri, 20 Mar 2020 23:24:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vN1/Ute8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727450AbgCTXYV (ORCPT ); Fri, 20 Mar 2020 19:24:21 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:42040 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbgCTXYV (ORCPT ); Fri, 20 Mar 2020 19:24:21 -0400 Received: by mail-ot1-f65.google.com with SMTP id f66so2246553otf.9; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=vN1/Ute8SimVqT3y3hab78UyOf4VVJ7VRiHOmD/0YEw4RVsLYf+I9I+znQgoZJ4gdB ictTZbD1FHachCP/sbEN+nf5NkPQ3zRL8Ac1BelFOIse/g9g6UpeoAfXXPC7J0vE8auY ePcveIYKTMSHJgWhosQIxl0CCrkGF9pmyNFPTwd0v+oVmX5riIDdzQ03F5K6zEp+Yorg xUhrv1K+sA6wqpG3J43WbuJGu1I6tO2+B7xlqRuhBhDVQUlM25cT94sYTuO+2rNTPHR+ wUJD/jin1TicQd15MZDDptDmvyxFQ3GYs+b1BI3MQaatUfXjIV8IMG9GTl9ZI1NYxiQ/ JVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=QZL1jtNh8XPVs7unt5QmsDE91zm2o+d6HscepsjM8qz3umFWJHFut6LIFLnr/+O+26 ajJ0TQEeL4kOtITohA1I/2eHwsLraFrkh3u18ik3AWrKLZMGhpqgrvXNzW9rtpxAuVCc v0kGmtCJ8uEDMl5p18lPn2lQi20cPNbAPHurVBCpLuBDe8lH7fkGWzpHbSAIJRqL2EEA 6cUraD5laSLsO5X8GoBSj/CirYRexbb4A/GnnRL20QI+vLe05lXEaUxcWT/24LU1OffJ bHn9w/xyadmMpSpWtrOZE1GRBXYG0RKyU+TnHt1ftBxy/TeWL30Savdx/gCL52LAqqeN LwNQ== X-Gm-Message-State: ANhLgQ0L4NL6VJTLyfkHNa6bBh093xQ8sQK+HFBaSBG27aQkVGUqkY2C ns3S3c+jYPPpV6vE+jXVoyv1i1rwigix0DJl5LE= X-Google-Smtp-Source: ADFU+vvk42JpEDDDlDUp6QEGUIHSuidkoO4gJ/JVIxwHCPUSqqRu1OBVOgg9ZhRrthX3kgHdC2yuDHRY3AYH9iDgANA= X-Received: by 2002:a05:6830:1608:: with SMTP id g8mr9414965otr.282.1584746659261; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:8e:0:0:0:0:0 with HTTP; Fri, 20 Mar 2020 16:24:18 -0700 (PDT) In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Message-ID: Subject: Re: [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Junxiao Bi , Joseph Qi , Dave Chinner , John Hubbard , Christoph Hellwig , William Kucharski Content-Type: text/plain; charset="UTF-8" Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Subject: [Ocfs2-devel] [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90BEC4332B for ; Fri, 20 Mar 2020 23:24:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8806C2070A for ; Fri, 20 Mar 2020 23:24:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vN1/Ute8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8806C2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5A6B6B0005; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE3E56B0006; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAB836B0007; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id AF75B6B0005 for ; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6942A5825 for ; Fri, 20 Mar 2020 23:24:20 +0000 (UTC) X-FDA: 76617321480.01.pen60_600ffb7510910 X-HE-Tag: pen60_600ffb7510910 X-Filterd-Recvd-Size: 4496 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 23:24:19 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id j16so7750656otl.1 for ; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=vN1/Ute8SimVqT3y3hab78UyOf4VVJ7VRiHOmD/0YEw4RVsLYf+I9I+znQgoZJ4gdB ictTZbD1FHachCP/sbEN+nf5NkPQ3zRL8Ac1BelFOIse/g9g6UpeoAfXXPC7J0vE8auY ePcveIYKTMSHJgWhosQIxl0CCrkGF9pmyNFPTwd0v+oVmX5riIDdzQ03F5K6zEp+Yorg xUhrv1K+sA6wqpG3J43WbuJGu1I6tO2+B7xlqRuhBhDVQUlM25cT94sYTuO+2rNTPHR+ wUJD/jin1TicQd15MZDDptDmvyxFQ3GYs+b1BI3MQaatUfXjIV8IMG9GTl9ZI1NYxiQ/ JVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=OCDrpld6Y8srMbpQ+6MBDQTxaDPwx8g71FMcm0/1ZgiwMdiuJpT0BSd9/lRSR3SUk4 f6Jr7fLVWkAiPbhcipc53tMkqK1dx/tEIiRP02BXzLv+Cx86z6dbYw3N/SgXCXpU6qfE oOMUDuJ4bBm2gcPlQOKR4Eya7aQzcZaGsvVlQVpzFL/Y+7B1urGNHjyK8Z+lDd4j+TmS ckz7mi4IXgFOo1xiSvZnrP20pPNGSHjbo2TRiEt2DEGAqy2QAdetS3VGQ4TtQmXA7C2I kiZ8K7Uv0rpqMNHlWAUNdGHRM9ICSzPVAwxOn6yXrgZqSQYzZvHRIrUOU8XVt4iUNTZp +2fQ== X-Gm-Message-State: ANhLgQ1u8XtSnSjZ293GUcItol3Xm6+ai5cj6Ghzz2NfUYw3Wddfwo9E VpHkNQ6NW9twB6c63YL3/r1EleDDafs8R8CHUVs= X-Google-Smtp-Source: ADFU+vvk42JpEDDDlDUp6QEGUIHSuidkoO4gJ/JVIxwHCPUSqqRu1OBVOgg9ZhRrthX3kgHdC2yuDHRY3AYH9iDgANA= X-Received: by 2002:a05:6830:1608:: with SMTP id g8mr9414965otr.282.1584746659261; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:8e:0:0:0:0:0 with HTTP; Fri, 20 Mar 2020 16:24:18 -0700 (PDT) In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Message-ID: Subject: Re: [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Junxiao Bi , Joseph Qi , Dave Chinner , John Hubbard , Christoph Hellwig , William Kucharski Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254C7C4332D for ; Fri, 20 Mar 2020 23:24:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB08A2070A; Fri, 20 Mar 2020 23:24:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="TEqBPw1L"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="QkA0z+iV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vN1/Ute8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB08A2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jFR09-00031F-2X; Fri, 20 Mar 2020 23:24:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jFR07-000318-Ds for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Mar 2020 23:24:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=TEqBPw1L9pHjxOT2m1x1pUTeZI tyVn3Q7uNzGcr1aUhNaaJLsDLDAlTnqlv41tJHQkC+yTa8SYxGoWpwQ6AWIGDhel2X3RA2/J+8Qfp kzvcnIzxWwgd5xM7dhH5n9g5xUqyhg0pzbl3zeU/xeYO6ww8HbBZn1bA+62zTwMBkVF4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:References:In-Reply-To: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=QkA0z+iVLwNi64sgjhfaJIRMjV BcUrjs/cCywjlPEdvU8ecNqF2R5EQK97+RtfFg6O1VJZx4wP6tkHgiug2nT0tAKhjMu3mRV9JBvNz dw5OvR1fOY53Wv1SI6qj/R20ZvzWe2/K14z3uR5ArEK++yIiSTWOFuDyCyrKNukTxdgI=; Received: from mail-ot1-f68.google.com ([209.85.210.68]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jFR05-00AiUZ-3A for linux-f2fs-devel@lists.sourceforge.net; Fri, 20 Mar 2020 23:24:27 +0000 Received: by mail-ot1-f68.google.com with SMTP id w26so1818664otp.8 for ; Fri, 20 Mar 2020 16:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=vN1/Ute8SimVqT3y3hab78UyOf4VVJ7VRiHOmD/0YEw4RVsLYf+I9I+znQgoZJ4gdB ictTZbD1FHachCP/sbEN+nf5NkPQ3zRL8Ac1BelFOIse/g9g6UpeoAfXXPC7J0vE8auY ePcveIYKTMSHJgWhosQIxl0CCrkGF9pmyNFPTwd0v+oVmX5riIDdzQ03F5K6zEp+Yorg xUhrv1K+sA6wqpG3J43WbuJGu1I6tO2+B7xlqRuhBhDVQUlM25cT94sYTuO+2rNTPHR+ wUJD/jin1TicQd15MZDDptDmvyxFQ3GYs+b1BI3MQaatUfXjIV8IMG9GTl9ZI1NYxiQ/ JVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=J59DG3VVC9l2RUdY4NE45GVRg7USbHLdhvoD0JQI0jktAm2Wx0arvNWo/zFlTowy1R WWqwO3/wAxD/mAbDb7e+z0AjYj6ouXM+KRGOoYPDFqoN0tc3TrrpKonQZOhjp3CCMfg2 v8BYkQqoIKvTYDMV4W7UG3KbzmTDv0Fxvq+XuafECycUpx6QoAPIvmaXknAdTRkfdb9R RdZrMdB6LrZHhoAwl/B27wiA3WYTs9StusrZsZTes3AgZHlT5sSKvRQ0jMnOrp4VgOPh mNcHjt5DCAusc67hSD7cWecWYvmj+H4A2lFdDVlG2hxgL6zp0s8uP1WdnsS9uHRzWcBK JJ1g== X-Gm-Message-State: ANhLgQ0cNDDXSBpXw1l6cMf/+CCS87KrTe2liRdSMjFo3SQpJjlca436 krheILeU2m+uPa22OK6cDVqfyRGC2vYcXti3soU= X-Google-Smtp-Source: ADFU+vvk42JpEDDDlDUp6QEGUIHSuidkoO4gJ/JVIxwHCPUSqqRu1OBVOgg9ZhRrthX3kgHdC2yuDHRY3AYH9iDgANA= X-Received: by 2002:a05:6830:1608:: with SMTP id g8mr9414965otr.282.1584746659261; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:8e:0:0:0:0:0 with HTTP; Fri, 20 Mar 2020 16:24:18 -0700 (PDT) In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Message-ID: To: Matthew Wilcox X-Headers-End: 1jFR05-00AiUZ-3A Subject: Re: [f2fs-dev] [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, Junxiao Bi , William Kucharski , Joseph Qi , John Hubbard , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Dave Chinner , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0435CC4332B for ; Fri, 20 Mar 2020 23:24:39 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9EA02070A for ; Fri, 20 Mar 2020 23:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vN1/Ute8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9EA02070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48kfxc6DMczDrfP for ; Sat, 21 Mar 2020 10:24:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::344; helo=mail-ot1-x344.google.com; envelope-from=linkinjeon@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=vN1/Ute8; dkim-atps=neutral Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48kfxR3Rm4zDrS7 for ; Sat, 21 Mar 2020 10:24:22 +1100 (AEDT) Received: by mail-ot1-x344.google.com with SMTP id a49so7701096otc.11 for ; Fri, 20 Mar 2020 16:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=vN1/Ute8SimVqT3y3hab78UyOf4VVJ7VRiHOmD/0YEw4RVsLYf+I9I+znQgoZJ4gdB ictTZbD1FHachCP/sbEN+nf5NkPQ3zRL8Ac1BelFOIse/g9g6UpeoAfXXPC7J0vE8auY ePcveIYKTMSHJgWhosQIxl0CCrkGF9pmyNFPTwd0v+oVmX5riIDdzQ03F5K6zEp+Yorg xUhrv1K+sA6wqpG3J43WbuJGu1I6tO2+B7xlqRuhBhDVQUlM25cT94sYTuO+2rNTPHR+ wUJD/jin1TicQd15MZDDptDmvyxFQ3GYs+b1BI3MQaatUfXjIV8IMG9GTl9ZI1NYxiQ/ JVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=nL7+IvNvPKBVQFTkHTH2mhUbzqu0yS/UgplCphJXOKbFB7y0fmDQSFX9IOJkYM0W6r G/qiR1i7X9LNQMzt1EQABZAyqgIH1Rfjv7FVPJeRNCKzC8LtVL8HLqyQddwMK4kSfV6h 3XhVIbG8QOLfBZLWfD4IbCWtTZS7d67VOBPHlpnZofSStWdDX1JQCDWm0owE6NzDzbMo 5yrTUe28FxkTT7rwA6g4vRLgwnLZlV0eZkULez2xmGp9CsX/EYnhZz4yI0DqU0OXMLrn Zk4G+L+Qy59ga39Ruj6TndDcU2Q2V6kJw1DijDnRKOcKfIoC4JEdhGhkqDpa23pgdrIV 8tzQ== X-Gm-Message-State: ANhLgQ3SROF4HqlMHF8IiePdY7ZrBnV9uunJMb9urAOh5QF/DjtDoAT0 DGnZdQLK6ogkUUO/pcLn7mIvyan5I0yjgLP8vhQ= X-Google-Smtp-Source: ADFU+vvk42JpEDDDlDUp6QEGUIHSuidkoO4gJ/JVIxwHCPUSqqRu1OBVOgg9ZhRrthX3kgHdC2yuDHRY3AYH9iDgANA= X-Received: by 2002:a05:6830:1608:: with SMTP id g8mr9414965otr.282.1584746659261; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:8e:0:0:0:0:0 with HTTP; Fri, 20 Mar 2020 16:24:18 -0700 (PDT) In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Message-ID: Subject: Re: [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead To: Matthew Wilcox Content-Type: text/plain; charset="UTF-8" X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-xfs@vger.kernel.org, Junxiao Bi , William Kucharski , Joseph Qi , John Hubbard , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Dave Chinner , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Subject: [Cluster-devel] [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin,